From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795165183; b=MUV0Z6AnLhw3aukTPqsPy1Ma9poGI0ohqt/2G5FHurI2C3yJ+hZ7rAvklgM3vltYGNeS /mNQWUCxZo13deAHm02onQeVbWnCoBharQ06pNxW+nCGJz/Y4k1Kqp0evKlxcHoyY9Z1W DQ3ap5rvrxdKQSofi1JhBJiBo064/riXv6p6zDDn3unlg7cXt5SVyYBH9x3klORa8UGK2 g+V8YC911OHeeWlUgK6YN7os6dQmciPJLLUevmgufNIhBGE4jT/ndKq/QgjftVjDoPIo1 U94xJs6HFKUhnjLyPjZaAJakZNcvJnyls5JRM4ftXtGBTGkc2dBwwkoNHgA66bSQJhQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795165183; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=zbAWU1RlxtAFu9xQZOUCjLW45qkPUbL82Im2/Iuxrx0=; b=ld0UC5egXEmFxmYsb+u0w6cjeo0LyBKM4MkHTeeqE5rDbpJ8q00DE6s5ZwgUgxyMAUqj NdGj98COPY3BWBmgl8H55+M21VK3iI/Ab0JKNIvqMfdCLZWr0OO5N7MCBSXrt//Yb2uIq QnLEULfjYRa/YzN+YvrRyrw+19vH4RrtWNjSM473omkkxrvicvm8KjzPqWVdk26C8mnif Q1iva7U4bjOp8/CDsPXyW5fc/rYeIUK4xs7EYUj1GWN+h0tNr+pSKytGiWV9LMSipitZj eATyaNRjx67LLFXga0rTQVU302EpuZl0zuJ6a2i0h9sW9gzRtv/8/DELDBU1SRiVGzA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=OOPNSvEg; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C2B960A2606; Fri, 20 Nov 2026 08:59:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=OOPNSvEg Received: by smtp.kernel.org (Postfix) with ESMTPSA id C75F01F000C6; Fri, 20 Nov 2026 08:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795165183; bh=zbAWU1RlxtAFu9xQZOUCjLW45qkPUbL82Im2/Iuxrx0=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=OOPNSvEgVhZNW71MC6vuLU503DT49Hfb6ujAimA603hN2D2BPIRbq/J1LIROLHtVH BRbFc6rruEtVLSUW1vP/gv0DlVmQJLaYTbmeP4f+oNrWp0rtg1qQHvV/kSf8o0H+Y1 8rpkoxD/jj7+MORCTIjknilnOwZ18BjxD3lwHz6MhEX1o9xNG/uGhFKJrIb1HoS3Pe /oa/JvcZU1GXm5sCbzr2QmuVf8k/xiugthJSMWKfJMTvkOA8xwGmFPn9VBQLmIPcBH 3AtIleVV7n6A+hkuWPFm5MKnBINRJ2Pz/GnGH1YIAgCc+NQsWf1g12RsrT6HxuNOYg fpfWvtnj9hvZQ== Message-ID: <627410e4-e674-4ea2-bccb-e1842f71fbe6@kernel.org> Date: Fri, 20 Nov 2026 09:58:51 +0100 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 2/2] clk: qcom: Add LPASS VA CSR heartbeat pulse clock To: sarath.ganapathiraju@oss.qualcomm.com, andersson@kernel.org, abelvesa@kernel.org, sboyd@kernel.org, bmasney+clk@redhat.com, jbrunet+clk@baylibre.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, srinivas.kandagatla@oss.qualcomm.com Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, prasad.kumpatla@oss.qualcomm.com References: <20261120-master-v14-0-112cfd63438d@oss.qualcomm.com> <20261120-master-v14-2-112cfd63438d@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20261120-master-v14-2-112cfd63438d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 20/11/2026 09:36, Sarath Ganapathiraju via B4 Relay wrote: > From: Sarath Ganapathiraju > > The HeartBeat Pulse, also known as RateGen Pulse, synchronizes the > start of DMAs and Codec Interfaces for the audio usecases and can > serve as a periodic wakeup source for the DSP. > > Add the LPASS VA CSR driver that models the rate generator as a clock > provider so consumers can enable and disable it through the common > clock framework. > > Attach the DT vote clocks to runtime PM and program the rate generator > counter and delay registers from runtime resume after the votes are > enabled. This restores the state if the LPASS register context is lost > across runtime suspend. > > Rely on the clock core provider runtime PM handling around clock > prepare and unprepare to keep the votes active for regmap gate > accesses. Use the same runtime suspend and resume callbacks for > system sleep so the vote clocks are enabled before restoring the > rate generator after suspend. Track the heartbeat gate state in the > clock callbacks and restore LPASS_RATE_GEN_CTRL on resume when the > clock was enabled before the LPASS register context was lost. > > Reviewed-by: Prasad Kumpatla > Tested-by: Prasad Kumpatla > Signed-off-by: Sarath Ganapathiraju > --- So entire patch will need one more revision because of triviality in the binding... why not making applying tags correctly :/ Best regards, Krzysztof