From: "Rafael J. Wysocki" <rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Adam Thomson
<Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
Cc: Robert Moore
<robert.moore-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Lv Zheng <lv.zheng-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Heikki Krogerus
<heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Len Brown <lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Andy Shevchenko
<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Frank Rowand
<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-acpi <linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
alsa-devel <alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Support Opensource
<support.opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>,
Sathyanarayana Nujella
<sathyanarayana.nujella-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions
Date: Wed, 22 Jun 2016 00:30:06 +0200 [thread overview]
Message-ID: <6274a042-da99-e3e6-20f2-37ce2651645c@intel.com> (raw)
In-Reply-To: <cover.1466523027.git.Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
On 6/21/2016 7:50 PM, Adam Thomson wrote:
> This patch set converts the da7219 codec driver to use device/fwnode functions
> to access properties, instead of the DT only of_* functions, allowing ACPI
> to be used as well.
>
> The DT bindings for da7219 have a device node for the main codec properties,
> and a named child node (da7219_aad), which contains all of the accessory
> detection related properties for the device. ACPI also supports this kind of
> FW hierarchy (data only sub-nodes), but some support in the kernel needs to be
> added to take make use of this in driver code.
>
> The first patch adds functions to allow searching for a named child node of a
> device, for both DT and ACPI, and the second patch updates the codec driver to
> use the standard device/fwnode calls, including this new function.
>
> These changes are based on the v4.7-rc4 kernel.
>
> Changes in v4:
> - Rebase to v4.7-rc4
> - Use strcmp() in acpi_data_node_match() for matching ACPI data nodes.
>
> Changes in v3:
> - Use of_node_cmp() in device_get_named_child_node() to match DT node.
>
> Changes in v2:
> - Rebase to v4.7-rc1
> - Small updates to codec patch based on previous reviewer comments
>
> Adam Thomson (2):
> device property: Add function to search for named child of device
> ASoC: da7219: Convert driver to use generic device/fwnode functions
>
> drivers/base/property.c | 28 ++++++++++++
> include/acpi/acpi_bus.h | 7 +++
> include/linux/acpi.h | 6 +++
> include/linux/of.h | 14 +++---
> include/linux/property.h | 3 ++
> sound/soc/codecs/da7219-aad.c | 103 +++++++++++++++++++++---------------------
> sound/soc/codecs/da7219.c | 34 +++++++-------
> 7 files changed, 119 insertions(+), 76 deletions(-)
>
> --
> 1.9.3
>
I'm fine with the first patch and the second one carries a couple of
ACKs already, so do you want me to apply them both?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-21 22:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 17:50 [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions Adam Thomson
2016-06-21 17:50 ` [PATCH v4 1/2] device property: Add function to search for named child of device Adam Thomson
2016-06-21 17:50 ` [PATCH v4 2/2] ASoC: da7219: Convert driver to use generic device/fwnode functions Adam Thomson
[not found] ` <cover.1466523027.git.Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
2016-06-21 22:30 ` Rafael J. Wysocki [this message]
2016-06-21 22:54 ` [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions Opensource [Adam Thomson]
2016-06-21 23:21 ` Mark Brown
[not found] ` <20160621232116.GG28202-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-06-22 1:05 ` Rafael J. Wysocki
2016-06-23 10:01 ` Mark Brown
2016-06-23 12:57 ` Rafael J. Wysocki
2016-06-26 11:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6274a042-da99-e3e6-20f2-37ce2651645c@intel.com \
--to=rafael.j.wysocki-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lv.zheng-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=robert.moore-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sathyanarayana.nujella-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=support.opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).