From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24558C433EF for ; Tue, 7 Dec 2021 13:52:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232871AbhLGN4Q (ORCPT ); Tue, 7 Dec 2021 08:56:16 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:49428 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232089AbhLGN4Q (ORCPT ); Tue, 7 Dec 2021 08:56:16 -0500 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1B7B1mwh022007; Tue, 7 Dec 2021 14:52:19 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=WVeP9+Hhl3z25pEnaV1aVde+gDQUBf8xrlGxOz2Aasw=; b=7yzorhmnQMSRQKfesnYdXDIzVs3Xzuh8L5T8Ba3Kb98u7qAGK5JHE7D5CDJq8JMfE9dF /kmkZ+q17EUHeBWeQZdArf9bhmZe23iPsE4NIkTSgIeElC+v+1PVMs1if8F+sLd+h90k QAN4hnAR6gcDxr8BqculQ0xQ8m4NYjx2PZYgPnqD4zt3hHNhTKJ7Kd1fL1qyfXFvFNAM RK8bMdD8R0D8ls2wLEF/e8DVbNVIVN9sO0ES/1xVNRPAy1hnnXZhX4wobfFsw3qv1YQw D3x6O98Y1vYwKtoaw23/Ilxj5VALxAUeTM5rp3n1GFsO4wnDl7XY2rp3wqFOWmyjn/d0 9A== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3ct1fxaja0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Dec 2021 14:52:19 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id B44DB10002A; Tue, 7 Dec 2021 14:52:18 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 2412723FA40; Tue, 7 Dec 2021 14:52:18 +0100 (CET) Received: from lmecxl0912.lme.st.com (10.75.127.47) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Tue, 7 Dec 2021 14:52:17 +0100 Subject: Re: [PATCH v2 1/4] ASoC: dt-bindings: stm32: i2s: add audio-graph-card port To: Rob Herring , Olivier MOYSAN CC: , Liam Girdwood , Olivier Moysan , Maxime Coquelin , , , , , , Mark Brown , , , References: <20211125144053.774-1-olivier.moysan@foss.st.com> <20211125144053.774-2-olivier.moysan@foss.st.com> <1637875562.357461.2858318.nullmailer@robh.at.kernel.org> <237f56b3-0597-2526-a182-f1fbdd327338@foss.st.com> From: Alexandre TORGUE Message-ID: <627777a4-7458-88ed-e7c5-d11e3db847b5@foss.st.com> Date: Tue, 7 Dec 2021 14:52:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2021-12-07_06,2021-12-06_02,2021-12-02_01 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob On 12/1/21 11:34 PM, Rob Herring wrote: > On Fri, Nov 26, 2021 at 11:25:27AM +0100, Olivier MOYSAN wrote: >> Hi Rob, >> >> On 11/25/21 10:26 PM, Rob Herring wrote: >>> On Thu, 25 Nov 2021 15:40:50 +0100, Olivier Moysan wrote: >>>> The STM2 I2S DAI can be connected via the audio-graph-card. >>>> Add port entry into the bindings. >>>> >>>> Signed-off-by: Olivier Moysan >>>> --- >>>> Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>> >>> Running 'make dtbs_check' with the schema in this patch gives the >>> following warnings. Consider if they are expected or the schema is >>> incorrect. These may not be new warnings. >>> >>> Note that it is not yet a requirement to have 0 warnings for dtbs_check. >>> This will change in the future. >>> >>> Full log is available here: https://patchwork.ozlabs.org/patch/1559750 >>> >>> >>> audio-controller@4000b000: 'port' does not match any of the regexes: '^port@[0-9]', 'pinctrl-[0-9]+' >>> arch/arm/boot/dts/stm32mp157a-dk1.dt.yaml >>> arch/arm/boot/dts/stm32mp157c-dk2.dt.yaml >>> >> >> This warning is not a new one. >> >> The i2s2 node in stm32mp15xx-dkx.dtsi would require the following binding: >> port: >> $ref: audio-graph-port.yaml# >> unevaluatedProperties: false >> >> However the spi binding requires to introduce a unit address: >> patternProperties: >> '^port@[0-9]': >> $ref: audio-graph-port.yaml# >> unevaluatedProperties: false >> >> The warning can be removed by re-ordering the bindings patches in the serie, >> as "additionalProperties: true" makes the check more tolerant on extra >> properties. > > That's never right. > >> The patch "ASoC: dt-bindings: stm32: i2s: add audio-graph-card port" can >> even be merely dropped. >> So, I suggest to resend the serie without audio-graph-card patch. > > Only if you aren't using audio-graph-card. > >> >> Does it sound too permissive to you ? > > I think perhaps you need to combine the schemas into 1. Or you need to > restructure your dtsi files such that you only add spi specific > properties when spi mode is enabled and only add i2s specific properties > when i2s mode is enabled. Or use the /delete-property/ directive. Initially the aim of this series was to fix a "make W=1" warnings seen on spi and i2s nodes (duplicate unit-address). Moving both nodes in a common node + using a different compatible depending on SPI or I2S usage sounded good) but it is not enough. In this series the common node is named as following: "spi2s2: spi@4000b000". It is fine for a spi usage but if we want to use this "common node" with I2S compatible and specific bindings, the node name remains spi@... and then specific spi checks are done. For this with this series applied we got this issue reported by spi-controller.yaml: spi@4000b000: port@0: 'compatible' is a required property So, if we use two separates nodes we got W=1 warning and if we use a common node we got yaml check issue. One possibility would be to use a common node with a new node name (for example i2spi@...) but I think it is not acceptable. How to progress ? Thanks Alex > Rob >