From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Robin Gong <yibin.gong@nxp.com>,
Martijn de Gouw <martijn.de.gouw@prodrive-technologies.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: regulator: add pca9450: Add regulator-allowed-modes
Date: Sun, 25 May 2025 06:43:17 +0200 [thread overview]
Message-ID: <6277cbd5-d57d-404a-baef-e8d87a027e37@kernel.org> (raw)
In-Reply-To: <aDJKUl2l3l08LPDe@finisterre.sirena.org.uk>
On 25/05/2025 00:38, Mark Brown wrote:
> On Sat, May 24, 2025 at 08:34:41AM +0200, Krzysztof Kozlowski wrote:
>> On 23/05/2025 18:21, Mark Brown wrote:
>
>>> [1/2] dt-bindings: regulator: add pca9450: Add regulator-allowed-modes
>>> commit: 0a4056a444c8d55beea470948c73befd6673aa6c
>>> [2/2] regulator: pca9450: Add support for mode operations
>>> commit: 2616e5f4fe04eb25eb5cbabc0a3a2a374e14008e
>
>> Rob reported binding has failure (which also means binding was not
>> tested). Can you drop the patch?
>
> That seemed to just be due to v1 splitting the header with the constants
> from the binding change (the issue was that the header wasn't there)
> which should be fixed by this version?
No, this v2:
https://lore.kernel.org/all/174801020316.1711348.10193654747801258488.robh@kernel.org/
I must admit after quick look I don't see the cause error, but
nevertheless this should be address by someone, preferably author.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-25 4:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 13:12 [PATCH v2 1/2] dt-bindings: regulator: add pca9450: Add regulator-allowed-modes Martijn de Gouw
2025-05-23 14:01 ` Mark Brown
2025-05-23 14:23 ` Rob Herring (Arm)
2025-05-23 16:21 ` Mark Brown
2025-05-24 6:34 ` Krzysztof Kozlowski
2025-05-24 22:38 ` Mark Brown
2025-05-25 4:43 ` Krzysztof Kozlowski [this message]
2025-05-25 11:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6277cbd5-d57d-404a-baef-e8d87a027e37@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martijn.de.gouw@prodrive-technologies.com \
--cc=robh@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox