From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Komal Bajaj <quic_kbajaj@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_nainmeht@quicinc.com
Subject: Re: [RFC PATCH 2/2] arm64: dts: qcom: qcm6490: Add qcm6490 idp and rb3 board
Date: Sat, 4 Nov 2023 13:32:16 +0100 [thread overview]
Message-ID: <62860baa-4a0f-4a69-bbe4-94579c28a1cb@linaro.org> (raw)
In-Reply-To: <20231103184655.23555-3-quic_kbajaj@quicinc.com>
On 11/3/23 19:46, Komal Bajaj wrote:
> Add qcm6490 devicetree file for QCM6490 IDP and QCM6490 RB3
> platform. QCM6490 is derived from SC7280 meant for various
> form factor including IoT.
>
> Supported features are, as of now:
> * Debug UART
> * eMMC (only in IDP)
> * USB
>
> Co-developed-by: Naina Mehta <quic_nainmeht@quicinc.com>
> Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
> ---
[...]
> +
> +&sdhc_1 {
> + non-removable;
> + no-sd;
> + no-sdio;
> +
> + vmmc-supply = <&vreg_l7b_2p952>;
> + vqmmc-supply = <&vreg_l19b_1p8>;
I think you also need to add regulator-allow-set-mode and something
something regulator allowed modes to VQMMC
[...]
> + model = "Qualcomm Technologies, Inc. QCM6490 RB3";
Is the name just "QCM6490 RB3"? One already exists, based on SDM845.
Otherwise, this looks very good to me now, thanks.
With these nits addressed:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
next prev parent reply other threads:[~2023-11-04 12:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 18:46 [RFC PATCH 0/2] Add support for qcm6490 idp and rb3 board Komal Bajaj
2023-11-03 18:46 ` [RFC PATCH 1/2] dt-bindings: arm: qcom: Add QCM6490 IDP and RB3 board Komal Bajaj
2023-11-05 13:06 ` Krzysztof Kozlowski
2023-11-03 18:46 ` [RFC PATCH 2/2] arm64: dts: qcom: qcm6490: Add qcm6490 idp and rb3 board Komal Bajaj
2023-11-03 22:22 ` Dmitry Baryshkov
2023-11-05 13:08 ` Krzysztof Kozlowski
2023-11-06 11:41 ` Mukesh Ojha
2023-11-06 11:54 ` Dmitry Baryshkov
2023-11-06 14:45 ` Mukesh Ojha
2023-11-06 22:32 ` Dmitry Baryshkov
2023-11-07 8:10 ` Mukesh Ojha
2023-11-13 15:51 ` Luca Weiss
2023-11-14 12:48 ` Mukesh Ojha
2023-11-14 12:53 ` Dmitry Baryshkov
2023-11-06 13:05 ` Krzysztof Kozlowski
2023-11-06 14:51 ` Mukesh Ojha
[not found] ` <4d8c094f-07b0-2b38-4680-145eb2d7c4f5@quicinc.com>
2023-11-17 9:33 ` Dmitry Baryshkov
2023-11-17 12:43 ` Komal Bajaj
2023-11-04 12:32 ` Konrad Dybcio [this message]
2023-11-17 12:49 ` Komal Bajaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62860baa-4a0f-4a69-bbe4-94579c28a1cb@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kbajaj@quicinc.com \
--cc=quic_nainmeht@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).