Re: [PATCH v2 1/2] dt-bindings: memory: Add TI FSS_FSAS binding

[Krzysztof Kozlowski <krzk@kernel.org>]

On 29/06/2026 09:20, Santhosh Kumar K wrote:
> Add DT binding for the TI Flash Subsystem Application Subsystem
> (FSS_FSAS_GENREGS) wrapper present in TI K3 SoCs. This block controls
> XIP read prefetch for the OSPI controller.

A nit, subject: drop second/last, redundant "bindins". The "dt-bindings"
prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23

> 
> Signed-off-by: Santhosh Kumar K <s-k6@ti.com>
> ---
>  .../memory-controllers/ti,am62a-fsas.yaml     | 39 +++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/ti,am62a-fsas.yaml
> 
> diff --git a/Documentation/devicetree/bindings/memory-controllers/ti,am62a-fsas.yaml b/Documentation/devicetree/bindings/memory-controllers/ti,am62a-fsas.yaml
> new file mode 100644
> index 000000000000..5a5cac92082b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/memory-controllers/ti,am62a-fsas.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2025 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/memory-controllers/ti,am62a-fsas.yaml#

Why is this in memory? I have doubts this is a separate device.


> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments K3 Flash SubSystem Application Subsystem (FSS_FSAS)
> +
> +maintainers:
> +  - Santhosh Kumar K <s-k6@ti.com>
> +
> +description:
> +  The FSS_FSAS_GENREGS block is a TI wrapper inside the Flash SubSystem (FSS).
> +
> +properties:
> +  compatible:
> +    const: ti,am62a-fsas
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    bus {
> +        #address-cells = <2>;
> +        #size-cells = <2>;

Just go with default address cells, drop node.


Best regards,
Krzysztof