devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: adrian.ho.yin.ng@intel.com, gregkh@linuxfoundation.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, Thinh.Nguyen@synopsys.com,
	p.zabel@pengutronix.de
Subject: Re: [PATCH v2 2/2] usb: dwc3: of-simple: Add compatible string for Intel Agilex5 platform
Date: Mon, 24 Jul 2023 09:28:04 +0200	[thread overview]
Message-ID: <62995eb7-70c4-3f2c-c874-6a5f196b1859@linaro.org> (raw)
In-Reply-To: <42ae4193a9f1383fae49ae84917c7cf1d1d1bbd9.1690179693.git.adrian.ho.yin.ng@intel.com>

On 24/07/2023 08:37, adrian.ho.yin.ng@intel.com wrote:
> From: Adrian Ng Ho Yin <adrian.ho.yin.ng@intel.com>
> 
> Add compatible string to use this generic glue layer to support
> Intel Agilex5 dwc3 controller.
> 
> Signed-off-by: Adrian Ng Ho Yin <adrian.ho.yin.ng@intel.com>
> ---
>  drivers/usb/dwc3/dwc3-of-simple.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index 7e6ad8fe61a5..3c4640a7e663 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -175,6 +175,7 @@ static const struct of_device_id of_dwc3_simple_match[] = {
>  	{ .compatible = "allwinner,sun50i-h6-dwc3" },
>  	{ .compatible = "hisilicon,hi3670-dwc3" },
>  	{ .compatible = "intel,keembay-dwc3" },
> +	{ .compatible = "intel,agilex5-dwc3" },

NAK. Your binding says something entirely different. Explanation you
gave me also says different.

Best regards,
Krzysztof


      reply	other threads:[~2023-07-24  7:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-24  6:36 [PATCH v2 0/2] Add support for Intel SocFPGA DWC3 USB controller adrian.ho.yin.ng
2023-07-24  6:36 ` [PATCH v2 1/2] dt-bindings: usb: Add Intel SoCFPGA " adrian.ho.yin.ng
2023-07-24  7:04   ` Krzysztof Kozlowski
2023-07-24  7:18     ` Ng, Adrian Ho Yin
2023-07-24  7:27       ` Krzysztof Kozlowski
2023-07-24  7:53         ` Ng, Adrian Ho Yin
2023-07-24  8:55           ` Krzysztof Kozlowski
2023-07-27  2:09             ` Ng, Adrian Ho Yin
2023-07-25 13:25   ` Greg KH
2023-07-27  2:11     ` Ng, Adrian Ho Yin
2023-07-26 16:29   ` Rob Herring
2023-07-27  8:11     ` Ng, Adrian Ho Yin
2023-07-24  6:37 ` [PATCH v2 2/2] usb: dwc3: of-simple: Add compatible string for Intel Agilex5 platform adrian.ho.yin.ng
2023-07-24  7:28   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62995eb7-70c4-3f2c-c874-6a5f196b1859@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=adrian.ho.yin.ng@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).