Re: [PATCH v5 01/14] dt-bindings: pci: cadence: Extend compatible for new RP configuration

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/07/2025 03:35, Manikandan Karunakaran Pillai wrote:

>>> Hi Kryzsztof,
>>>
>>> Are you suggesting to create new file for both RC and EP for HPA host like:
>>> cdns,cdns-pcie-hpa-host.yaml
>>> cdns,cdns-pcie-hpa-ep.yaml
>>> And during the commit log, explain why you need to create a new file for
>> HPA, and not use the legacy one.
>>
>> No, there was no such suggestions in any previous or current
>> discussions. IIRC, this was simply rejected previously. I consider this
>> rejected still, with the same arguments: you should use specific SoC
>> compatibles. The generic compatible alone is rather legacy approach and
>> we have been commenting on this sooooo many times.
>>
> 
> Hi Kryzsztof,
> 
> Thanks for your response. 
> The SoC specific dts patches are already being submitted by CIX team for their SoC based on the same PCIe controller IP. 

There is a SoC, otherwise why is this attached to completely unrelated
patches?

> 
> Since there is no SoC for this platform(it only an FPGA based board),
> are you suggesting to drop the dt-bindings patch altogether as the SoC specific dts bindings are already being in the same patch set.

I have impression I discussed it... either in this thread or other. I am
fine with adding compatible for your virtual setup / FPGA platform, but
this has to reflect that case. Otherwise everyone will use this one
here, just like it happened with other cdns cores.



Best regards,
Krzysztof