From: Christian Marangi <ansuelsmth@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: dma: rework qcom,adm Documentation to yaml schema
Date: Thu, 16 Jun 2022 16:02:34 +0200 [thread overview]
Message-ID: <62ab38f5.1c69fb81.303fc.3bc8@mx.google.com> (raw)
In-Reply-To: <1655388301.055791.3391580.nullmailer@robh.at.kernel.org>
On Thu, Jun 16, 2022 at 08:05:01AM -0600, Rob Herring wrote:
> On Thu, 16 Jun 2022 01:54:03 +0200, Christian Marangi wrote:
> > Rework the qcom,adm Documentation to yaml schema.
> > This is not a pure conversion since originally the driver has changed
> > implementation for the #dma-cells and was wrong from the start.
> > Also the driver now handles the common DMA clients implementation with
> > the first cell that denotes the channel number and nothing else since
> > the client will have to provide the crci information via other means.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > ---
> > v2:
> > - Change Sob to Christian Marangi
> > - Add Bjorn in the maintainers list
> >
> > .../devicetree/bindings/dma/qcom,adm.yaml | 96 +++++++++++++++++++
> > .../devicetree/bindings/dma/qcom_adm.txt | 61 ------------
> > 2 files changed, 96 insertions(+), 61 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/dma/qcom,adm.yaml
> > delete mode 100644 Documentation/devicetree/bindings/dma/qcom_adm.txt
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/
>
>
> dma-controller@18300000: reset-names:1: 'c0' was expected
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
>
> dma-controller@18300000: reset-names:2: 'c1' was expected
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
>
> dma-controller@18300000: reset-names:3: 'c2' was expected
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
>
> dma-controller@18300000: reset-names: ['clk', 'pbus', 'c0', 'c1', 'c2'] is too long
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
>
> dma-controller@18300000: resets: [[11, 13], [11, 12], [11, 11], [11, 10], [11, 9]] is too long
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
>
I should have fixed this with the other patch. Should the conversion fix
this directly?
--
Ansuel
next prev parent reply other threads:[~2022-06-16 14:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 23:54 [PATCH v2 1/2] dt-bindings: dma: rework qcom,adm Documentation to yaml schema Christian Marangi
2022-06-15 23:54 ` [PATCH v2 2/2] dt-bindings: dma: add additional pbus reset to qcom,adm Christian Marangi
2022-06-16 21:32 ` Rob Herring
2022-06-16 14:05 ` [PATCH v2 1/2] dt-bindings: dma: rework qcom,adm Documentation to yaml schema Rob Herring
2022-06-16 14:02 ` Christian Marangi [this message]
2022-06-16 21:32 ` Rob Herring
2022-06-16 21:32 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62ab38f5.1c69fb81.303fc.3bc8@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).