From: Christian Marangi <ansuelsmth@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Taniya Das <quic_tdas@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: gcc-ipq806x: use parent_data for the last remaining entry
Date: Fri, 24 Jun 2022 02:42:05 +0200 [thread overview]
Message-ID: <62b50863.1c69fb81.be104.158e@mx.google.com> (raw)
In-Reply-To: <20220624003714.918ACC3411D@smtp.kernel.org>
On Thu, Jun 23, 2022 at 05:37:12PM -0700, Stephen Boyd wrote:
> Quoting Stephen Boyd (2022-06-23 17:27:18)
> > Quoting Dmitry Baryshkov (2022-06-20 14:51:50)
> > > Use parent_data for the last remaining entry (pll4). This clock is
> > > provided by the lcc device.
> > >
> > > Fixes: cb02866f9a74 ("clk: qcom: gcc-ipq806x: convert parent_names to parent_data")
> > > Cc: Ansuel Smith <ansuelsmth@gmail.com>
> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > > ---
> > > drivers/clk/qcom/gcc-ipq806x.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c
> > > index 718de17a1e60..6447f3e81b55 100644
> > > --- a/drivers/clk/qcom/gcc-ipq806x.c
> > > +++ b/drivers/clk/qcom/gcc-ipq806x.c
> > > @@ -79,7 +79,9 @@ static struct clk_regmap pll4_vote = {
> > > .enable_mask = BIT(4),
> > > .hw.init = &(struct clk_init_data){
> > > .name = "pll4_vote",
> > > - .parent_names = (const char *[]){ "pll4" },
> > > + .parent_data = &(const struct clk_parent_data){
> > > + .fw_name = "pll4", .name = "pll4",
> >
> > Is there a DT binding update?
>
> Also I'd appreciate clk patches be sent to my kernel.org email instead
> of chromium to help my filters.
Sorry for the OT but as you mention... there are many series for ipq806x
all reviewed. Wonder if they can be picked or should I RESEND them?
Some of them are blocking me from sending other fixes as the current
dtsi have wrong definition that would cause kernel panic (if things are
correctly implemented on the driver side)
--
Ansuel
next prev parent reply other threads:[~2022-06-24 0:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 21:51 [PATCH] clk: qcom: gcc-ipq806x: use parent_data for the last remaining entry Dmitry Baryshkov
2022-06-21 15:21 ` Christian Marangi
2022-06-21 17:00 ` Dmitry Baryshkov
2022-06-21 17:06 ` Christian Marangi
2022-06-24 0:27 ` Stephen Boyd
2022-06-24 0:37 ` Stephen Boyd
2022-06-24 0:42 ` Christian Marangi [this message]
2022-06-24 0:49 ` Stephen Boyd
2022-06-27 23:45 ` Bjorn Andersson
2022-06-24 5:23 ` Dmitry Baryshkov
2022-06-24 5:23 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62b50863.1c69fb81.be104.158e@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).