From: Christian Marangi <ansuelsmth@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@somainline.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Subject: Re: [PATCH v4 2/5] dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml
Date: Thu, 30 Jun 2022 00:38:24 +0200 [thread overview]
Message-ID: <62bcd462.1c69fb81.c8b67.4c9f@mx.google.com> (raw)
In-Reply-To: <1656542219.655280.1042481.nullmailer@robh.at.kernel.org>
On Wed, Jun 29, 2022 at 04:36:59PM -0600, Rob Herring wrote:
> On Wed, 29 Jun 2022 14:14:38 +0200, Christian Marangi wrote:
> > Convert kpss-acc driver Documentation to yaml.
> > The original Documentation was wrong all along. Fix it while we are
> > converting it.
> > The example was wrong as kpss-acc-v2 should only expose the regs but we
> > don't have any driver that expose additional clocks. The kpss-acc driver
> > is only specific to v1. For this exact reason, limit all the additional
> > bindings (clocks, clock-names, clock-output-names and #clock-cells) to
> > v1 and also flag that these bindings should NOT be used for v2.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > ---
> > .../bindings/arm/msm/qcom,kpss-acc.txt | 49 ----------
> > .../bindings/arm/msm/qcom,kpss-acc.yaml | 93 +++++++++++++++++++
> > 2 files changed, 93 insertions(+), 49 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt
> > create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/
>
>
> clock-controller@2088000: '#clock-cells' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2088000: 'clock-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2088000: 'clock-output-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2088000: 'clocks' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2098000: '#clock-cells' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2098000: 'clock-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2098000: 'clock-output-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2098000: 'clocks' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@20a8000: '#clock-cells' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20a8000: 'clock-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20a8000: 'clock-output-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20a8000: 'clocks' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20b8000: '#clock-cells' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20b8000: 'clock-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20b8000: 'clock-output-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20b8000: 'clocks' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
(fixed in the last 2 commit of this series)
--
Ansuel
next prev parent reply other threads:[~2022-06-29 22:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 12:14 [PATCH v4 0/5] Krait Documentation conversion Christian Marangi
2022-06-29 12:14 ` [PATCH v4 1/5] dt-bindings: clock: Convert qcom,krait-cc to yaml Christian Marangi
2022-06-29 12:14 ` [PATCH v4 2/5] dt-bindings: arm: msm: Convert kpss-acc driver Documentation " Christian Marangi
2022-06-29 22:36 ` Rob Herring
2022-06-29 22:38 ` Christian Marangi [this message]
2022-07-01 17:26 ` Rob Herring
2022-06-29 12:14 ` [PATCH v4 3/5] dt-bindings: arm: msm: Rework kpss-gcc " Christian Marangi
2022-06-29 22:36 ` Rob Herring
2022-06-30 6:43 ` Dmitry Baryshkov
2022-06-30 11:20 ` Christian Marangi
2022-07-01 17:32 ` Rob Herring
2022-07-01 17:32 ` Christian Marangi
2022-06-29 12:14 ` [PATCH v4 4/5] ARM: dts: qcom: fix various wrong definition for kpss-gcc node Christian Marangi
2022-06-29 12:14 ` [PATCH v4 5/5] ARM: dts: qcom: fix various wrong definition for kpss-acc Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62bcd462.1c69fb81.c8b67.4c9f@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=agross@kernel.org \
--cc=axboe@kernel.dk \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).