* [PATCH 2/2] drm/bridge: tc358768: switch to bus-width
2024-10-03 13:39 [PATCH 1/2] dt-bindings: display: bridge: tc358768: switch to bus-width Krzysztof Kozlowski
@ 2024-10-03 13:39 ` Krzysztof Kozlowski
2024-10-03 16:12 ` Neil Armstrong
2024-10-03 16:12 ` [PATCH 1/2] dt-bindings: display: bridge: " Neil Armstrong
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-10-03 13:39 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Peter Ujfalusi, dri-devel,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
"data-lines" property is way too similar to "data-lanes". It is also
duplicating "bus-width" from video-interfaces.yaml schema. "data-lines"
was deprecated in the bindings and "bus-width" is preferred, so parse it
instead while keeping things backwards compatible.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/gpu/drm/bridge/tc358768.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c
index 0e8813278a2f..fc96fa5aab54 100644
--- a/drivers/gpu/drm/bridge/tc358768.c
+++ b/drivers/gpu/drm/bridge/tc358768.c
@@ -443,7 +443,9 @@ static int tc358768_dsi_host_attach(struct mipi_dsi_host *host,
ret = -EINVAL;
ep = of_graph_get_endpoint_by_regs(host->dev->of_node, 0, 0);
if (ep) {
- ret = of_property_read_u32(ep, "data-lines", &priv->pd_lines);
+ ret = of_property_read_u32(ep, "bus-width", &priv->pd_lines);
+ if (ret)
+ ret = of_property_read_u32(ep, "data-lines", &priv->pd_lines);
of_node_put(ep);
}
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] drm/bridge: tc358768: switch to bus-width
2024-10-03 13:39 ` [PATCH 2/2] drm/bridge: " Krzysztof Kozlowski
@ 2024-10-03 16:12 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2024-10-03 16:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andrzej Hajda, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Peter Ujfalusi, dri-devel,
devicetree, linux-kernel
On 03/10/2024 15:39, Krzysztof Kozlowski wrote:
> "data-lines" property is way too similar to "data-lanes". It is also
> duplicating "bus-width" from video-interfaces.yaml schema. "data-lines"
> was deprecated in the bindings and "bus-width" is preferred, so parse it
> instead while keeping things backwards compatible.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/gpu/drm/bridge/tc358768.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c
> index 0e8813278a2f..fc96fa5aab54 100644
> --- a/drivers/gpu/drm/bridge/tc358768.c
> +++ b/drivers/gpu/drm/bridge/tc358768.c
> @@ -443,7 +443,9 @@ static int tc358768_dsi_host_attach(struct mipi_dsi_host *host,
> ret = -EINVAL;
> ep = of_graph_get_endpoint_by_regs(host->dev->of_node, 0, 0);
> if (ep) {
> - ret = of_property_read_u32(ep, "data-lines", &priv->pd_lines);
> + ret = of_property_read_u32(ep, "bus-width", &priv->pd_lines);
> + if (ret)
> + ret = of_property_read_u32(ep, "data-lines", &priv->pd_lines);
>
> of_node_put(ep);
> }
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: display: bridge: tc358768: switch to bus-width
2024-10-03 13:39 [PATCH 1/2] dt-bindings: display: bridge: tc358768: switch to bus-width Krzysztof Kozlowski
2024-10-03 13:39 ` [PATCH 2/2] drm/bridge: " Krzysztof Kozlowski
@ 2024-10-03 16:12 ` Neil Armstrong
2024-10-05 17:44 ` Rob Herring (Arm)
2024-10-21 12:59 ` Neil Armstrong
3 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2024-10-03 16:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andrzej Hajda, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Peter Ujfalusi, dri-devel,
devicetree, linux-kernel
On 03/10/2024 15:39, Krzysztof Kozlowski wrote:
> "data-lines" property is way too similar to "data-lanes". It is also
> duplicating "bus-width" from video-interfaces.yaml schema. Deprecate
> "data-lines" and use the common property.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> index 779d8c57f854..bb5d3b543800 100644
> --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> @@ -60,6 +60,10 @@ properties:
> data-lines:
> $ref: /schemas/types.yaml#/definitions/uint32
> enum: [ 16, 18, 24 ]
> + deprecated: true
> +
> + bus-width:
> + enum: [ 16, 18, 24 ]
>
> port@1:
> $ref: /schemas/graph.yaml#/properties/port
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: display: bridge: tc358768: switch to bus-width
2024-10-03 13:39 [PATCH 1/2] dt-bindings: display: bridge: tc358768: switch to bus-width Krzysztof Kozlowski
2024-10-03 13:39 ` [PATCH 2/2] drm/bridge: " Krzysztof Kozlowski
2024-10-03 16:12 ` [PATCH 1/2] dt-bindings: display: bridge: " Neil Armstrong
@ 2024-10-05 17:44 ` Rob Herring (Arm)
2024-10-21 12:59 ` Neil Armstrong
3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2024-10-05 17:44 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Robert Foss, linux-kernel, Krzysztof Kozlowski, Neil Armstrong,
Jernej Skrabec, Simona Vetter, Maxime Ripard, Peter Ujfalusi,
Laurent Pinchart, David Airlie, Conor Dooley, dri-devel,
Andrzej Hajda, devicetree, Jonas Karlman, Thomas Zimmermann,
Maarten Lankhorst
On Thu, 03 Oct 2024 15:39:03 +0200, Krzysztof Kozlowski wrote:
> "data-lines" property is way too similar to "data-lanes". It is also
> duplicating "bus-width" from video-interfaces.yaml schema. Deprecate
> "data-lines" and use the common property.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: display: bridge: tc358768: switch to bus-width
2024-10-03 13:39 [PATCH 1/2] dt-bindings: display: bridge: tc358768: switch to bus-width Krzysztof Kozlowski
` (2 preceding siblings ...)
2024-10-05 17:44 ` Rob Herring (Arm)
@ 2024-10-21 12:59 ` Neil Armstrong
3 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2024-10-21 12:59 UTC (permalink / raw)
To: Andrzej Hajda, Robert Foss, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Simona Vetter, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Peter Ujfalusi, dri-devel,
devicetree, linux-kernel, Krzysztof Kozlowski
Hi,
On Thu, 03 Oct 2024 15:39:03 +0200, Krzysztof Kozlowski wrote:
> "data-lines" property is way too similar to "data-lanes". It is also
> duplicating "bus-width" from video-interfaces.yaml schema. Deprecate
> "data-lines" and use the common property.
>
>
Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)
[1/2] dt-bindings: display: bridge: tc358768: switch to bus-width
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/d704a2fe530caa7023949b513b8d1c364b5832fb
[2/2] drm/bridge: tc358768: switch to bus-width
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/bf7c079902c34f8b16ea3484de080a7bb4ad0367
--
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread