From: Neil Armstrong <neil.armstrong@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/7] usb: typec: ucsi: add PMIC Glink UCSI driver
Date: Fri, 10 Feb 2023 16:00:47 +0100 [thread overview]
Message-ID: <62ede719-e7f8-4d7e-883e-a4b8eb47f987@linaro.org> (raw)
In-Reply-To: <Y+YkHZASzN97QtUY@kroah.com>
On 10/02/2023 12:01, Greg Kroah-Hartman wrote:
> On Fri, Feb 10, 2023 at 11:44:22AM +0100, Neil Armstrong wrote:
>> On 10/02/2023 11:38, Greg Kroah-Hartman wrote:
>>> On Fri, Feb 10, 2023 at 11:31:08AM +0100, Neil Armstrong wrote:
>>>> On 31/01/2023 10:16, Greg Kroah-Hartman wrote:
>>>>> On Mon, Jan 30, 2023 at 10:54:32AM +0100, Neil Armstrong wrote:
>>>>>> Introduce the UCSI PMIC Glink aux driver that communicates
>>>>>> with the aDSP firmware with the UCSI protocol which handles
>>>>>> the USB-C Port(s) Power Delivery.
>>>>>>
>>>>>> The UCSI messaging is necessary on newer Qualcomm SoCs to
>>>>>> provide USB role switch and altmode notifications.
>>>>>>
>>>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>>>>> ---
>>>>>> drivers/usb/typec/ucsi/Kconfig | 7 +
>>>>>> drivers/usb/typec/ucsi/Makefile | 1 +
>>>>>> drivers/usb/typec/ucsi/ucsi_glink.c | 321 ++++++++++++++++++++++++++++++++++++
>>>>>> 3 files changed, 329 insertions(+)
>>>>>>
>>>>>> diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig
>>>>>> index 8f9c4b9f31f7..dee6069e46a2 100644
>>>>>> --- a/drivers/usb/typec/ucsi/Kconfig
>>>>>> +++ b/drivers/usb/typec/ucsi/Kconfig
>>>>>> @@ -58,4 +58,11 @@ config UCSI_STM32G0
>>>>>> To compile the driver as a module, choose M here: the module will be
>>>>>> called ucsi_stm32g0.
>>>>>> +config UCSI_PMIC_GLINK
>>>>>> + tristate "UCSI Qualcomm PMIC GLINK Interface Driver"
>>>>>> + depends on QCOM_PMIC_GLINK
>>>>>
>>>>> No way to test build this code without this option?
>>>>
>>>> Nop, the QCOM_PMIC_GLINK is a build dependency, this can't be removed
>>>
>>> Then perhaps the QCOM_PMIC_GLINK code needs to be fixed up to allow for
>>> it to be built on all platforms properly? Otherwise you are
>>> guaranteeing you will not get much, if any, build coverage and api
>>> changes will cause this code to stagnate over time :(
>>
>> The QCOM_PMIC_GLINK deps are:
>> depends on RPMSG
>> depends on TYPEC
>> depends on DRM
>> depends on NET
>> depends on OF
>> select AUXILIARY_BUS
>> select QCOM_PDR_HELPERS
>>
>> What would be the changes needed here ?
>
> I do not know, try unwinding it and maybe just adding a COMPILE_TEST
> build option in a few places is all that is needed?
Sure, I'll investigate and send a separate patch for that.
Thanks,
Neil
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2023-02-10 15:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 9:54 [PATCH 0/7] soc: qcom: add UCSI function to PMIC GLINK Neil Armstrong
2023-01-30 9:54 ` [PATCH 1/7] usb: typec: ucsi: add PMIC Glink UCSI driver Neil Armstrong
2023-01-31 9:16 ` Greg Kroah-Hartman
2023-02-10 10:31 ` Neil Armstrong
2023-02-10 10:38 ` Greg Kroah-Hartman
2023-02-10 10:44 ` Neil Armstrong
2023-02-10 11:01 ` Greg Kroah-Hartman
2023-02-10 15:00 ` Neil Armstrong [this message]
2023-01-30 9:54 ` [PATCH 2/7] dt-bindings: soc: qcom: qcom,pmic-glink: document SM8450 compatible Neil Armstrong
2023-01-30 22:46 ` Rob Herring
2023-01-30 9:54 ` [PATCH 3/7] dt-bindings: soc: qcom: qcom,pmic-glink: document SM8550 compatible Neil Armstrong
2023-01-30 22:46 ` Rob Herring
2023-01-30 9:54 ` [PATCH 4/7] soc: qcom: pmic_glink: register ucsi aux device Neil Armstrong
2023-01-30 9:54 ` [PATCH 5/7] arm64: dts: qcom: sm8450-hdk: add pmic glink node Neil Armstrong
2023-01-30 10:40 ` Konrad Dybcio
2023-01-30 10:58 ` Neil Armstrong
2023-01-30 10:59 ` Konrad Dybcio
2023-01-30 11:01 ` neil.armstrong
2023-01-30 9:54 ` [PATCH 6/7] arm64: dts: qcom: sm8550-mtp: " Neil Armstrong
2023-01-30 10:41 ` Konrad Dybcio
2023-01-30 10:59 ` Neil Armstrong
2023-01-30 9:54 ` [PATCH 7/7] arm64: defconfig: add PMIC GLINK modules Neil Armstrong
2023-02-01 8:31 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62ede719-e7f8-4d7e-883e-a4b8eb47f987@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).