From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 490D3C05027 for ; Fri, 10 Feb 2023 15:01:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232344AbjBJPA7 (ORCPT ); Fri, 10 Feb 2023 10:00:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231748AbjBJPA6 (ORCPT ); Fri, 10 Feb 2023 10:00:58 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A65F57765 for ; Fri, 10 Feb 2023 07:00:50 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id ba1so5341257wrb.5 for ; Fri, 10 Feb 2023 07:00:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=K3+P+KUFXvw1apoaL31HXOu2YL3RmY3Kb2P1uEHJDNc=; b=alUpfBodLxY9kFtV/M3kwZoV13ak/JNqddq/STESMZYMiaKWURdGqY90Iewy/098VT p5QEet9/3knhYcsJ2/CjIQ2xq1UTXLtPTcbviPDN/WF7qeXsU5R8F+tbz/5DcE21CgpV Mx9AFyn5YrEQbE17Th5ZYjo7dK94E63vnYRYxPGnQjV2K+Cb+MllAC2+Q6G8aCqE1L8A AGEzqQDxQt0jybY/Lx9ScPEMPILzAz4ch/bMtPAzwHVUC+WCau2kjVz0ygU1f19/gWSj i7wYIovR4u9cQJJ6JJnuCFWEuPqNsQdxKWSD5JyxnPp4uXavTZQE6Tb5Uk+XicxXr6xw pqhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K3+P+KUFXvw1apoaL31HXOu2YL3RmY3Kb2P1uEHJDNc=; b=XqW1//fJ6Sda23Q3xCChRWoZ5ayjLBZDrqsgkPiCvoq2jeKm/U1/CfU3hIq/S/+QVz pOkopesfBHtmiqtKy8Lmcw5hmrUOfT8wqu9//ku6siGfj2Ti0EnZeE2YPezGz0CLcdZR RWnWgJjJ66GmknofQML/XQaMDxiBHDFLH1QHoNiDoYWbWsi8fl94hOK8dCMy3Z83/0Tz u4Ph3u6sBYY5o3/MgfJoKIP3u5RLcHdcmnEBiSU7wFGQTj1qnr1FBciHaz8SWbsSyQKc O2YCV8cO/VMa/bnWqDWh7Jr9ncAPPMAj8TlyLAVvMA8TP23Wix1WGNt5eaSPjKZX6XZE AqQw== X-Gm-Message-State: AO0yUKW5yPSz3HslrZ0d2udoKNNS11cDB/EZg1omXDzhdVeAc7Aket1a 4jVoReXQJ9Y6gZHRlTWQ8/QcKQ== X-Google-Smtp-Source: AK7set+zJKGiSqj5eqPg+UEcnSf7H71aMVHQPkkvM154artPj3Ez+65Mh8QBqfERGqYAgN/a5FUqog== X-Received: by 2002:adf:f5c8:0:b0:2c3:ed14:8319 with SMTP id k8-20020adff5c8000000b002c3ed148319mr15222290wrp.14.1676041248911; Fri, 10 Feb 2023 07:00:48 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:5a65:5553:55cf:3027? ([2a01:e0a:982:cbb0:5a65:5553:55cf:3027]) by smtp.gmail.com with ESMTPSA id e29-20020a5d595d000000b002c53cc7504csm3603457wri.78.2023.02.10.07.00.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Feb 2023 07:00:48 -0800 (PST) Message-ID: <62ede719-e7f8-4d7e-883e-a4b8eb47f987@linaro.org> Date: Fri, 10 Feb 2023 16:00:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/7] usb: typec: ucsi: add PMIC Glink UCSI driver Content-Language: en-US To: Greg Kroah-Hartman Cc: Heikki Krogerus , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230130-topic-sm8450-upstream-pmic-glink-v1-0-0b0acfad301e@linaro.org> <20230130-topic-sm8450-upstream-pmic-glink-v1-1-0b0acfad301e@linaro.org> <720aee1d-87e8-5291-c6a0-ef53e830a21d@linaro.org> <06670a10-c8e9-6f87-9c16-e88a90a74469@linaro.org> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/02/2023 12:01, Greg Kroah-Hartman wrote: > On Fri, Feb 10, 2023 at 11:44:22AM +0100, Neil Armstrong wrote: >> On 10/02/2023 11:38, Greg Kroah-Hartman wrote: >>> On Fri, Feb 10, 2023 at 11:31:08AM +0100, Neil Armstrong wrote: >>>> On 31/01/2023 10:16, Greg Kroah-Hartman wrote: >>>>> On Mon, Jan 30, 2023 at 10:54:32AM +0100, Neil Armstrong wrote: >>>>>> Introduce the UCSI PMIC Glink aux driver that communicates >>>>>> with the aDSP firmware with the UCSI protocol which handles >>>>>> the USB-C Port(s) Power Delivery. >>>>>> >>>>>> The UCSI messaging is necessary on newer Qualcomm SoCs to >>>>>> provide USB role switch and altmode notifications. >>>>>> >>>>>> Signed-off-by: Neil Armstrong >>>>>> --- >>>>>> drivers/usb/typec/ucsi/Kconfig | 7 + >>>>>> drivers/usb/typec/ucsi/Makefile | 1 + >>>>>> drivers/usb/typec/ucsi/ucsi_glink.c | 321 ++++++++++++++++++++++++++++++++++++ >>>>>> 3 files changed, 329 insertions(+) >>>>>> >>>>>> diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig >>>>>> index 8f9c4b9f31f7..dee6069e46a2 100644 >>>>>> --- a/drivers/usb/typec/ucsi/Kconfig >>>>>> +++ b/drivers/usb/typec/ucsi/Kconfig >>>>>> @@ -58,4 +58,11 @@ config UCSI_STM32G0 >>>>>> To compile the driver as a module, choose M here: the module will be >>>>>> called ucsi_stm32g0. >>>>>> +config UCSI_PMIC_GLINK >>>>>> + tristate "UCSI Qualcomm PMIC GLINK Interface Driver" >>>>>> + depends on QCOM_PMIC_GLINK >>>>> >>>>> No way to test build this code without this option? >>>> >>>> Nop, the QCOM_PMIC_GLINK is a build dependency, this can't be removed >>> >>> Then perhaps the QCOM_PMIC_GLINK code needs to be fixed up to allow for >>> it to be built on all platforms properly? Otherwise you are >>> guaranteeing you will not get much, if any, build coverage and api >>> changes will cause this code to stagnate over time :( >> >> The QCOM_PMIC_GLINK deps are: >> depends on RPMSG >> depends on TYPEC >> depends on DRM >> depends on NET >> depends on OF >> select AUXILIARY_BUS >> select QCOM_PDR_HELPERS >> >> What would be the changes needed here ? > > I do not know, try unwinding it and maybe just adding a COMPILE_TEST > build option in a few places is all that is needed? Sure, I'll investigate and send a separate patch for that. Thanks, Neil > > thanks, > > greg k-h