From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793884902; b=BOGsuQMZsl/O+C4yCjPuXZZ2wXTcG8J51SnIrxBdlKzztTaD+0Zjvy7V6cZHrRl3leTD r7/liULIQuei4DpIxaOhn/Mdh4NTXqo8T+qV18Lpnt6HvS2nONAnGU/Zk7Rf62TTPqLKU tUCAJ/6uEnwpVlbhrJETP5tk1fJmhcIzinw//ij8hVbLSTTAXKNTA4o4ZlIDjiLt9FVzS n5aNmagFLXaYBp+hd1RzuW0cZ/7mh86INgdDyvffGVAMYM8ku7hexWeLqRhZxT8Wqlj3T RSdD2T+dd7Kw7RLvlCXyc1ltIXhxGMOn8oGZUCd/gdqijPvE2oWiBsJSErzPgzNOZwg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793884902; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=G1vXgpVqmyJuwZhE11W0WG7vmVcVTIDLtLjcGetTdWs=; b=b8eEn+tvhX3kGBuBQaYI7mzmC8e50cjjZozKGqtq9pNh/suxSeHJgiIrwYAiNpWSOBmF szWDlxkR4e/EGoMiqKqnTJT7SySUaRAHtfuIYdLVkI/EX2cyVpImmmlHd6rKvUWaZiUj+ iIZC5Z/rFr+Paw1EJpIhQ0u1ikeok0cll/fxJsZR+rOIR6lqlHALph9HWWhpSxdb8NuRP XU5p5g93/6KIiEJXPywiMYU19azaHmJT8yE2LnFN4ucGZcMt3SWtWnaZt0FJ1He3gKgXo /7NscXVMYz0iBhUvpuckIEDNG7tBxFbgKGoOtq29FKaSddzUkVBFX5DSuV4BUq99Csg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=hPYageCw; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79FCA606A31B; Thu, 5 Nov 2026 13:21:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=hPYageCw Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D44B1F000C1; Thu, 5 Nov 2026 13:21:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793884902; bh=G1vXgpVqmyJuwZhE11W0WG7vmVcVTIDLtLjcGetTdWs=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=hPYageCwvFnU9dbNnG0TrgoUzIZyl863gMxPAGz08ia+Bae4V6Ijiwsq7MLi3aGQE ls/XLvMp1RtnbdWZIPdcbcxButjfVC/3tLaagRC7U5nLPWEwR5qGCWeAxaEcQs3dkv nWGxSOChk3O5AFvqedRXoueL6qb19WmP3USie9ouew1CEZXDinzTMvjkwgH43sStmW Hy9aZkF93rD/0Sm4fuGH9kYNDzO9Oae2GMT3jUzrR5xwc2ruu/Am38Bit0ozEgRN+h Vw5vY8vfHKNGgE/Nq+JCdxH81xueUEGi0iYd54DSpWx8hTfkkZ+PY57i2fSGoOlZzy LcGJ1n5KXWcOA== Message-ID: <62fba00d-831c-44cc-8d3e-083a95abfbe8@kernel.org> Date: Thu, 5 Nov 2026 14:21:34 +0100 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: media: qcom,glymur-camss: Use CSIPHY indices for ports To: Loic Poulain Cc: Nihal Kumar Gupta , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Suresh Vankadara , Vikram Sharma References: <20261102-glymur_camss-v1-0-fcb619fc7319@oss.qualcomm.com> <20261102-glymur_camss-v1-1-fcb619fc7319@oss.qualcomm.com> <20261104-real-nebulous-ostrich-017e92@quoll> <72064a9a-1b2e-4c24-99e2-2cc15a8dd7f1@oss.qualcomm.com> <539842db-c672-4549-b861-4a6f3be47556@oss.qualcomm.com> <1db9bf48-01d8-44fe-8dd2-7a3c84ecc556@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 05/11/2026 13:04, Loic Poulain wrote: > On Thu, Nov 5, 2026 at 11:45 AM Krzysztof Kozlowski wrote: >> >> On 05/11/2026 10:53, Loic Poulain wrote: >>> So some chipsets share the same IP blocks, with some block/phy >>> instances disabled. As a result, we need to decide whether we're >>> numbering based on active instances or on the actual hardware instance >>> index/offset. If we use active-instance numbering, then yes, it should >>> be @2 (CSIPHY4 being the third active instance). Alternatively, if the >>> port numbering is intended to reflect the hardware instance offset, >>> matching the register prop, then @4 would be more appropriate. It also >>> has the advantage of directly identifying the underlying hardware >>> instance, without requiring any additional driver-side mapping. In any >>> case, @3 is incorrect. >>> >>> That said, since the bindings have already been merged in its current >>> form, we'll need to preserve backward compatibility when addressing >>> this. >> >> This is the input port to camss, so how is it called in camss, not the >> csi phy? > > The CSIPHYs are connected to the CAMSS input ports, which can then be > multiplexed and routed to different CSIDs. The mux identifies its PHY > inputs using the hardware PHY IDs, so the CSIPHY4 is identified as the > CAMSS PHY4 input. In this configuration, PHY2 and PHY3 inputs are not > connected. I could not find that information in Glymur HPG, but maybe I looked wrong. CSID Wrapper lists CSID 0-2, not 0, 1 and 4, but again maybe I am looking at wrong device description/interface... Best regards, Krzysztof