From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD01BEB64D9 for ; Mon, 26 Jun 2023 18:30:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231802AbjFZSab (ORCPT ); Mon, 26 Jun 2023 14:30:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232242AbjFZS3s (ORCPT ); Mon, 26 Jun 2023 14:29:48 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E82D1BF2 for ; Mon, 26 Jun 2023 11:29:42 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3f9c88ac077so46227095e9.1 for ; Mon, 26 Jun 2023 11:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687804181; x=1690396181; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ciOBPyu+sPG/PKmYcGSQsv3KkzCK7Nt7aYmMhEDjDGY=; b=j4CEk6ctLOsGMGmJWmlUl/9qeH9Ix3rM02o9HB2xpYBYHlFD7BQ5v4L1g7VKorj0eS u+UQ1Q4HEzTwSLikfOUzA4HNfR5a2NOxXMyXV8RhBIjpxxqFpYLTbbQR1r3xoE3IvS9O yT6JTc8aBedyR0boA3VZ0O/M9smdhh8yA0Egk8WSz5j0cX/WMinxVhqOfHN/x9XQqbSV vk5ZKzNueC/weR+IyeNOCGT74B86kM9gGqBQ7Ek/jkgdvsTe1PQX7Fb9AjhkmTBTS82z MsWn0oRUD0wntafSTc5sn1Wt+HHtxP6dg2PuNuVlBfiqbhr1MfUrDYM35dmwIoIyApw9 57pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687804181; x=1690396181; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ciOBPyu+sPG/PKmYcGSQsv3KkzCK7Nt7aYmMhEDjDGY=; b=Spk4bcSmsp+WhsODSLwWzxxtbhQN1Ve/di3mn7g8Pc/JDOS/QqqWwhI/5FTLhAVTUi VMNDN5PrXRUw7NEjwOs3h6Ds29dCuAPYFk5BNiZNr5FWAUgO+mw42dqbtqp94gOgvZge Bmh/+FB7TTECPSSyInctvuvSjhtp7NO8YFN/DEE+Tw0LEelcpPEDAf2ccJB/EE8MBbTR tjAbHaIUkRBqgFQDUH3N7ldUzlQuGNsZibjSzGu4aj2TdSyY/WkhW2ok9W9TOlowsn+E CYUvcMKfZ4AXKmZeKBFFoumWMn5LQ1CDI4ZEbdsilrKqNObwP7d0FgslSkzXSUmlMttd IavQ== X-Gm-Message-State: AC+VfDznxCrgY5+W3bnR1hRJDipaNP5KdfXD+sqSsxAWOmk7gYon509Q XnJYsvaQieQ7pBwO0hvJxpQVlg== X-Google-Smtp-Source: ACHHUZ6SiiVfSIYwx/dCsp5tW8i7z1sIDCnOdX5N2PHNcEVe4w7x5ZWmNvzNg1eUdrPkf/HUzHz1ZQ== X-Received: by 2002:a7b:c7c9:0:b0:3fa:7d11:ad00 with SMTP id z9-20020a7bc7c9000000b003fa7d11ad00mr7893257wmk.25.1687804180787; Mon, 26 Jun 2023 11:29:40 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id c25-20020a7bc019000000b003f819faff24sm11383213wmb.40.2023.06.26.11.29.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jun 2023 11:29:40 -0700 (PDT) Message-ID: <6311f26f-79ee-c471-649f-5e0b4629cfcc@linaro.org> Date: Mon, 26 Jun 2023 20:29:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: Require GCC PLL0 DIV clock Content-Language: en-US To: Marijn Suijten Cc: Konrad Dybcio , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Krishna Manikandan , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Lux Aliaga References: <20230624-sm6125-dpu-v1-0-1d5a638cebf2@somainline.org> <20230624-sm6125-dpu-v1-3-1d5a638cebf2@somainline.org> <55b0ca89-8f2e-5383-59d4-6809e813abf8@linaro.org> <52c57cab-10cf-2e7e-2c1d-fa6506786d45@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/06/2023 19:49, Marijn Suijten wrote: > On 2023-06-26 18:10:44, Krzysztof Kozlowski wrote: >> On 25/06/2023 21:48, Marijn Suijten wrote: >>> On 2023-06-24 11:08:54, Krzysztof Kozlowski wrote: >>>> On 24/06/2023 03:45, Konrad Dybcio wrote: >>>>> On 24.06.2023 02:41, Marijn Suijten wrote: >>>>>> The "gcc_disp_gpll0_div_clk_src" clock is consumed by the driver, will >>>>>> be passed from DT, and should be required by the bindings. >>>>>> >>>>>> Fixes: 8397c9c0c26b ("dt-bindings: clock: add QCOM SM6125 display clock bindings") >>>>>> Signed-off-by: Marijn Suijten >>>>>> --- >>>>> Ideally, you'd stick it at the bottom of the list, as the items: order >>>>> is part of the ABI >>>> >>>> Yes, please add them to the end. Order is fixed. >>> >>> Disagreed for bindings that declare clock-names and when the driver >>> adheres to it, see my reply to Konrad's message. >> >> That's the generic rule, with some exceptions of course. Whether one >> chosen driver (chosen system and chosen version of that system) adheres >> or not, does not change it. Other driver behaves differently and ABI is >> for everyone, not only for your specific version of Linux driver. >> >> Follow the rule. > > This has no relation to the driver (just that our driver adheres to the > bindings, as it is supposed to be). The bindings define a mapping from > a clock-names=<> entry to a clock on the same index in the clocks=<> > array. That relation remains the same with this change. Not really, binding also defines the list of clocks - their order and specific entries. This changes. Best regards, Krzysztof