From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1700AC433F5 for ; Mon, 8 Nov 2021 21:13:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC8BA611C0 for ; Mon, 8 Nov 2021 21:13:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239901AbhKHVP7 (ORCPT ); Mon, 8 Nov 2021 16:15:59 -0500 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:56690 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239887AbhKHVP6 (ORCPT ); Mon, 8 Nov 2021 16:15:58 -0500 Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 32F2B3F1ED for ; Mon, 8 Nov 2021 21:13:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1636405993; bh=XB2KDOBpJiDTxLvN53KaY9Yfn9kq5MuLsy13SYbvRGU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UE+sQ5HC8SwYYYj7RcaBdm8GunNKTsOGQLbKZjuai+rkr4WLHN3crG47WIxD+fnXp jSo7kUuENRJCtm+foTIvhY/Aaz81prUdYLgoSARcMDeYL3Sx8vjuo5rWBVgzloPYCS 3tiI5ks94aMQD3nuAMZ8xCvI5/yAit5u9ig49g4zW1uRjLBqXYocdi0PPqVswEUqyB PmtCe4YQti1t5wSAUaVEzedFOgJGkjACBYrbMghdQaLLvZoaobqJOs0rRPqlH7bXPi ufpUlTbLJnjQnw3TMhyFlGfz0Ur87EyHDzw0+sA2au3MX2U0+rKqv5KlJe+/gMvL9u ucwCabZySCP1Q== Received: by mail-lj1-f200.google.com with SMTP id v13-20020a2e2f0d000000b0021126b5cca2so5619072ljv.19 for ; Mon, 08 Nov 2021 13:13:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=XB2KDOBpJiDTxLvN53KaY9Yfn9kq5MuLsy13SYbvRGU=; b=Iq/+hi3bMzo/OqJi5XCqsxoGP2FL8I5NOD17TuFOP65uzKuIzfjyhISlDMzohoPQhq cyjfXgZmWbuXl3JHTUWXtkHjkf8qVDVJ2AXptxzlX/V2yH0zcDkNnQQFO+CorxAdxxeq fKV+Ipop9erDmQjIJfXywb9AsDq6aCzW0f2HCqo3RdZF/VCgejukzFc8rHWyaEedlcQc 1WOeruAHGOJgMoOGLXugIx0BLdVcqsuh1sU7VimbPNEOrzYkEqTlscpTNOyofWPKHeAt PcdTpLvPjulnrf/a4UWm0JdyweGx4aXemcw3zg77VV508/SIGt/IPxMcgXuUxS/Nhjcr qQCg== X-Gm-Message-State: AOAM531URFmaQZlgWloPotawmIctcCSYj+O4C7RrLdfnfnHX0DTUjEJ7 bsNnfisyMepk8bUttZtuhqRMPHxdg7IS5sObazBfmsauBLzEu6tWiQyq1NDCrwF652UIMgTpFen z1/HsNjPitQZYg7YQwMZz6iUrpMKKohK+SjVKWxg= X-Received: by 2002:a05:651c:10a2:: with SMTP id k2mr2206406ljn.456.1636405992509; Mon, 08 Nov 2021 13:13:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJxJoQJPfASIjl/Ea54GsJrSaswI+eaDTggcHJqauek5OKm03GQ1TdlvoYCWn2ROBLnxiDFlTg== X-Received: by 2002:a05:651c:10a2:: with SMTP id k2mr2206383ljn.456.1636405992327; Mon, 08 Nov 2021 13:13:12 -0800 (PST) Received: from [192.168.3.67] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id b13sm1929260lfb.145.2021.11.08.13.13.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Nov 2021 13:13:12 -0800 (PST) Message-ID: <632cb889-114b-2b44-3a75-e4b9e5bd0bda@canonical.com> Date: Mon, 8 Nov 2021 22:13:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH 05/13] dt-bindings: i2c: add bindings for microchip mpfs i2c Content-Language: en-US To: conor.dooley@microchip.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, robh+dt@kernel.org, jassisinghbrar@gmail.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, a.zummo@towertech.it, alexandre.belloni@bootlin.com, broonie@kernel.org, gregkh@linuxfoundation.org, lewis.hanly@microchip.com, daire.mcnamara@microchip.com, atish.patra@wdc.com, ivan.griffin@microchip.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-riscv@lists.infradead.org, linux-crypto@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org Cc: geert@linux-m68k.org, bin.meng@windriver.com References: <20211108150554.4457-1-conor.dooley@microchip.com> <20211108150554.4457-6-conor.dooley@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <20211108150554.4457-6-conor.dooley@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/11/2021 16:05, conor.dooley@microchip.com wrote: > From: Conor Dooley > > Add device tree bindings for the i2c controller on > the Microchip PolarFire SoC. > > Signed-off-by: Conor Dooley > Signed-off-by: Daire McNamara > --- > .../bindings/i2c/microchip,mpfs-i2c.yaml | 74 +++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/microchip,mpfs-i2c.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/microchip,mpfs-i2c.yaml b/Documentation/devicetree/bindings/i2c/microchip,mpfs-i2c.yaml > new file mode 100644 > index 000000000000..bc4ea4498d35 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/microchip,mpfs-i2c.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/microchip,mpfs-i2c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip MPFS I2C Controller Device Tree Bindings > + > +maintainers: > + - Daire McNamara > + > +description: | > + This I2C controller is found on the Microchip PolarFire SoC. > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + enum: > + - microchip,mpfs-i2c # Microchip PolarFire SoC compatible SoCs > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + description: Phandle of the clock feeding the I2C controller. Skip such descriptions here and in other patches - they do not introduce any meaningful information. > + minItems: 1 Define instead exact number of clocks or maxItems... but why would they be variable? > + > + clock-frequency: > + description: | > + Desired I2C bus clock frequency in Hz. As only Standard and Fast > + modes are supported, possible values are 100000 and 400000. > + enum: [100000, 400000] > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + i2c@2010a000 { > + compatible = "microchip,mpfs-i2c"; > + reg = <0 0x2010a000 0 0x1000>; > + interrupts = <58>; > + clock-frequency = <100000>; > + clocks = <&clkcfg CLK_I2C0>; > + }; > + }; > + - | > + #include > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + i2c@2010b000 { > + compatible = "microchip,mpfs-i2c"; > + reg = <0 0x2010b000 0 0x1000>; > + interrupts = <61>; > + clock-frequency = <100000>; > + clocks = <&clkcfg CLK_I2C1>; This is the same example as above, just with changed numbers. Skip it. > + }; > + }; > +... > Best regards, Krzysztof