devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mirela Rabulea <mirela.rabulea@nxp.com>
To: "mchehab@kernel.org" <mchehab@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"Mirela Rabulea (OSS)" <mirela.rabulea@oss.nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>
Cc: dl-linux-imx <linux-imx@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"laurent.pinchart+renesas@ideasonboard.com" 
	<laurent.pinchart+renesas@ideasonboard.com>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	Laurentiu Palcu <laurentiu.palcu@nxp.com>,
	Robert Chiras <robert.chiras@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"paul.kocialkowski@bootlin.com" <paul.kocialkowski@bootlin.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"niklas.soderlund+renesas@ragnatech.se" 
	<niklas.soderlund+renesas@ragnatech.se>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	"dafna.hirschfeld@collabora.com" <dafna.hirschfeld@collabora.com>,
	"ezequiel@collabora.com" <ezequiel@collabora.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Subject: Re: [EXT] Re: [PATCH v4 00/11] Add V4L2 driver for i.MX8 JPEG Encoder/Decoder
Date: Fri, 6 Nov 2020 01:04:45 +0000	[thread overview]
Message-ID: <6332a0d29721c8cef39c99ef7fd358464d492da1.camel@nxp.com> (raw)
In-Reply-To: <eec89e90-f414-121d-fbe4-ced23b44f6cc@xs4all.nl>

On Wed, 2020-11-04 at 15:08 +0100, Hans Verkuil wrote:
> 
> This was never really well defined. Basically the JPEG standard
> doesn't
> store colorimetry as metadata, instead it is understood to be sRGB
> colorimetry.
> 
> So if you take what a HW JPEG encoder creates and want to show it on
> another
> device, then it will be interpreted as sRGB. Now if userspace adds
> some JPEG
> extension where it declares the colorimetry to be something else,
> then that
> is fine, but that's out of scope of a HW JPEG encoder driver, IMHO.
> 
> I suspect that the coda patch was actually trying to make coda behave
> with
> an older version of v4l2-compliance where a JPEG codec was tested in
> the
> same way as a H264 codec. Later we realized that that didn't make
> sense for
> JPEG codecs and the test was changed. But now coda fails on that
> test.
> 
> > Once I clarify on this, I'll include a fix in v5.
> 
> I hope this helps.
> 
>         Hans
> 

Thanks for clarifying, I fixed the colorspace information to sRGB, for
both capture & output (V4L2_COLORSPACE_SRGB, V4L2_YCBCR_ENC_601 and
V4L2_QUANTIZATION_FULL_RANGE). All pass now. It will be in the next
version.


      reply	other threads:[~2020-11-06  1:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02  3:08 [PATCH v4 00/11] Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Mirela Rabulea (OSS)
2020-11-02  3:08 ` [PATCH v4 01/11] media: v4l: Add packed YUV444 24bpp pixel format Mirela Rabulea (OSS)
2020-11-02  3:08 ` [PATCH v4 02/11] firmware: imx: scu-pd: Add power domains for imx-jpeg Mirela Rabulea (OSS)
2020-11-02  3:08 ` [PATCH v4 03/11] media: dt-bindings: Add bindings for i.MX8QXP/QM JPEG driver Mirela Rabulea (OSS)
2020-11-04 22:38   ` Rob Herring
2020-11-09 21:59     ` [EXT] " Mirela Rabulea
2020-11-02  3:08 ` [PATCH v4 04/11] media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Mirela Rabulea (OSS)
2020-11-02 16:20   ` Laurentiu Palcu
2020-11-06  1:05     ` Mirela Rabulea
2020-11-02  3:08 ` [PATCH v4 05/11] arm64: dts: imx8qxp: Add jpeg encoder/decoder nodes Mirela Rabulea (OSS)
2020-11-02  3:08 ` [PATCH v4 06/11] Add maintainer for IMX jpeg v4l2 driver Mirela Rabulea (OSS)
2020-11-02 16:25   ` Laurentiu Palcu
2020-11-02  3:08 ` [PATCH v4 07/11] media: imx-jpeg: Fix v4l2-compliance streaming tests on decoder Mirela Rabulea (OSS)
2020-11-02  3:08 ` [PATCH v4 08/11] media: Add parsing for APP14 data segment in jpeg helpers Mirela Rabulea (OSS)
2020-11-02  3:08 ` [PATCH v4 09/11] media: Quit parsing stream if doesn't start with SOI Mirela Rabulea (OSS)
2020-11-02  3:08 ` [PATCH v4 10/11] media: Avoid parsing quantization and huffman tables Mirela Rabulea (OSS)
2020-11-02  3:08 ` [PATCH v4 11/11] media: imx-jpeg: Use v4l2 jpeg helpers in mxc-jpeg Mirela Rabulea (OSS)
2020-11-04 11:52 ` [PATCH v4 00/11] Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Hans Verkuil
2020-11-04 11:55   ` Hans Verkuil
2020-11-04 13:27     ` [EXT] " Mirela Rabulea
2020-11-04 14:08       ` Hans Verkuil
2020-11-06  1:04         ` Mirela Rabulea [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6332a0d29721c8cef39c99ef7fd358464d492da1.camel@nxp.com \
    --to=mirela.rabulea@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=dafna.hirschfeld@collabora.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ezequiel@collabora.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurentiu.palcu@nxp.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=mirela.rabulea@oss.nxp.com \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=p.zabel@pengutronix.de \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=robert.chiras@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).