From: Phil Elwell <philip.j.elwell-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: David Gibson
<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: "Pantelis Antoniou"
<pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>,
"Simon Glass" <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
"Boris Brezillon"
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Thomas Petazzoni"
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
"Antoine Ténart"
<antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v7 0/4] libfdt: Add support for device tree overlays
Date: Thu, 6 Oct 2016 22:16:04 +0100 [thread overview]
Message-ID: <6338fcb9-ffda-a04b-6c6e-2fd254b58dda@gmail.com> (raw)
In-Reply-To: <20161006094756.GR18733-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
On 06/10/2016 10:47, David Gibson wrote:
> On Fri, Sep 30, 2016 at 03:57:13PM +0200, Maxime Ripard wrote:
>> Hi,
>>
>> The device tree overlays are a great solution to the issue raised by
>> the bunch expandable boards we find everywhere these days, like the
>> Beaglebone, Raspberry Pi or CHIP.
>>
>> Although for now Linux is the only available tool that can deal with
>> overlays, some other components like bootloaders or user-space tools
>> might need to apply these overlays on top of a base device tree.
>>
>> To address these use cases, we introduce a new function to the libfdt,
>> fdt_overlay_apply, that does just that.
>>
>> You can find a test program here: http://code.bulix.org/792zum-99476?raw
>>
>> This is the last patches sent to U-boot, with the modifications
>> suggested by David, and the additional test cases.
>>
>> Let me know what you think!
>> Maxime
> Looking pretty good. There's a minor error in 3/4 which I've pointed
> out, it can be fixed in a followup.
>
> An error in the conditionals means it's trying to run some of the
> tests which require an overlay-aware dtc on even when that's not
> available - I adjusted 4/4 to correct that.
>
> It also hit build failures on Travis, because the compiler version
> there complains about local variables named 'index' shadowing the
> standard library function. I've corrected that with a followup patch.
>
> With that done, the whole lot has been committed to master.
>
Now that upstream libfdt can resolve and apply overlays we need a way
of generating them. I have a set of three patches from Pantelis that
add "plugin" support to dtc, together with two downstream (Raspberry Pi)
patches that fix an uninitialised memory reference and restrict
__local_fixups__ generation to overlays.
Is there already a plan to get the enhanced dtc upstreamed? If so, can I
get the downstream fixes included?
Phil Elwell
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-06 21:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 13:57 [PATCH v7 0/4] libfdt: Add support for device tree overlays Maxime Ripard
[not found] ` <20160930135717.16511-1-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-09-30 13:57 ` [PATCH v7 1/4] libfdt: Add new errors for the overlay code Maxime Ripard
2016-09-30 13:57 ` [PATCH v7 2/4] libfdt: Extend the reach of FDT_ERR_BADPHANDLE Maxime Ripard
2016-09-30 13:57 ` [PATCH v7 3/4] libfdt: Add overlay application function Maxime Ripard
[not found] ` <20160930135717.16511-4-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-10-06 6:46 ` David Gibson
2016-09-30 13:57 ` [PATCH v7 4/4] tests: Add tests cases for the overlay code Maxime Ripard
[not found] ` <20160930135717.16511-5-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-10-06 8:33 ` David Gibson
[not found] ` <20161006083348.GN18733-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2016-10-06 9:28 ` David Gibson
2016-10-06 9:47 ` [PATCH v7 0/4] libfdt: Add support for device tree overlays David Gibson
[not found] ` <20161006094756.GR18733-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2016-10-06 11:24 ` Maxime Ripard
2016-10-06 15:11 ` Phil Elwell
2016-10-06 21:16 ` Phil Elwell [this message]
[not found] ` <6338fcb9-ffda-a04b-6c6e-2fd254b58dda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-12 15:06 ` Pantelis Antoniou
[not found] ` <965C6014-692F-4021-9E3D-945ED32307B7-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2016-10-12 21:41 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6338fcb9-ffda-a04b-6c6e-2fd254b58dda@gmail.com \
--to=philip.j.elwell-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).