From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 7/9] dt: mb86s7x: add dt files for MB86S7x evbs Date: Fri, 21 Nov 2014 18:09:34 +0100 Message-ID: <6351620.x1OFSWlVbH@wuerfel> References: <1416486442-25200-1-git-send-email-Vincent.Yang@tw.fujitsu.com> <2581182.ZW92kSfUJp@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jassi Brar Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Vincent Yang , Devicetree List , Mark Rutland , Andy Green , Pawel Moll , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , Patch Tracking , Vincent Yang , Rob Herring , Kumar Gala , Olof Johansson , Tetsuya Nuriya List-Id: devicetree@vger.kernel.org On Friday 21 November 2014 22:19:43 Jassi Brar wrote: > > > > This seems weird: rather than have one clock controller node per > > clock source, why not just have one node with #clock-cells = >? > > > > Your controller seems perfectly capable of this, and you even > > put the numbers in the label. It would be much more straightforward > > to do > > > > clocks = <&clk_alw 0 1>; > > > > than > > > > clocks = <&clk_alw_0_1>; > > > > here. Possibly even > > > > clocks = <&clk MB86S70_CRG11_ALW 0 1>; > > > > with #clock-cells = > > > > Is there a way to compact the dtsi and yet populate only clocks that > are actually ever used (instead of 6x16x9)? I believe the clock driver just wouldn't create the clocks until a device driver requests them. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html