From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Billy Tsai <billy_tsai@aspeedtech.com>,
jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au,
andrew@aj.id.au, lee@kernel.org, thierry.reding@gmail.com,
u.kleine-koenig@pengutronix.de, corbet@lwn.net,
p.zabel@pengutronix.de, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-doc@vger.kernel.org,
patrick@stwcx.xyz
Subject: Re: [v5 1/5] dt-bindings: pwm: Add bindings for aspeed pwm controller
Date: Tue, 6 Jun 2023 12:42:05 +0200 [thread overview]
Message-ID: <636526b0-b5b3-aa80-49f7-fa805ebbac5c@linaro.org> (raw)
In-Reply-To: <20230606094535.5388-2-billy_tsai@aspeedtech.com>
On 06/06/2023 11:45, Billy Tsai wrote:
> Add the aspeed pwm device which should be the child-node of pwm-tach mfd.
>
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-06 10:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 9:45 [v5 0/5] Support pwm/tach driver for aspeed ast26xx Billy Tsai
2023-06-06 9:45 ` [v5 1/5] dt-bindings: pwm: Add bindings for aspeed pwm controller Billy Tsai
2023-06-06 10:42 ` Krzysztof Kozlowski [this message]
2023-06-06 9:45 ` [v5 2/5] dt-bindings: hwmon: Add bindings for aspeed tach controller Billy Tsai
2023-06-06 10:46 ` Krzysztof Kozlowski
2023-06-06 9:45 ` [v5 3/5] dt-bindings: mfd: Add aspeed pwm-tach binding Billy Tsai
2023-06-06 10:27 ` Rob Herring
2023-06-06 10:49 ` Krzysztof Kozlowski
2023-06-06 14:06 ` Patrick Williams
2023-06-06 14:23 ` Krzysztof Kozlowski
[not found] ` <SG2PR06MB33652E18980E9CF8E4F0894D8B53A@SG2PR06MB3365.apcprd06.prod.outlook.com>
2023-06-07 7:10 ` Krzysztof Kozlowski
[not found] ` <SG2PR06MB33657063A2E3239AD0A21F718B53A@SG2PR06MB3365.apcprd06.prod.outlook.com>
2023-06-07 8:33 ` Krzysztof Kozlowski
2023-06-07 8:55 ` Krzysztof Kozlowski
2023-06-07 18:26 ` Krzysztof Kozlowski
2023-06-08 15:15 ` Rob Herring
2023-06-06 9:45 ` [v5 4/5] pwm: Add Aspeed ast2600 PWM support Billy Tsai
2023-06-06 10:55 ` Krzysztof Kozlowski
2023-06-06 9:45 ` [v5 5/5] hwmon: Add Aspeed ast2600 TACH support Billy Tsai
2023-06-06 10:56 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=636526b0-b5b3-aa80-49f7-fa805ebbac5c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=patrick@stwcx.xyz \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).