From: Philipp Zabel <p.zabel@pengutronix.de>
To: Michael Tretter <m.tretter@pengutronix.de>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Marek Vasut <marex@denx.de>, Rob Herring <robh+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
kernel@pengutronix.de
Subject: Re: [PATCH v5 3/3] media: i2c: isl7998x: Add driver for Intersil ISL7998x
Date: Thu, 14 Oct 2021 12:17:10 +0200 [thread overview]
Message-ID: <639592c9ca18232c3372ae33d6e561969b1f69e4.camel@pengutronix.de> (raw)
In-Reply-To: <20211014093409.GC31981@pengutronix.de>
On Thu, 2021-10-14 at 11:34 +0200, Michael Tretter wrote:
> On Wed, 13 Oct 2021 10:05:30 +0200, Michael Tretter wrote:
> > On Tue, 12 Oct 2021 15:27:11 +0200, Philipp Zabel wrote:
[...]
> > > > +static int isl7998x_wait_power_on(struct isl7998x *isl7998x)
> > > > +{
> > > > + struct device *dev = isl7998x->subdev.dev;
> > > > + unsigned int retry;
> > > > + u32 chip_id;
> > > > + int ret = -ETIMEDOUT;
> > > > +
> > > > + for (retry = 10; ret && retry > 0; retry--) {
> > > > + ret = regmap_read(isl7998x->regmap,
> > > > + ISL7998x_REG_P0_PRODUCT_ID_CODE, &chip_id);
> > > > + usleep_range(1000, 2000);
> > > > + }
> > >
> > > Consider using regmap_read_poll_timeout() here.
> >
> > Ack. I forgot about this function.
>
> regmap_read_poll_timeout() cannot be used here, because it returns if
> regmap_read() returns an error. The driver uses the return value of
> regmap_read() to detect, if the chip is available, and should continue polling
> if regmap_read() failed. I can implement the necessary behavior with
> read_poll_timeout(), but am not sure if it is really worth it.
Oh, right. I still think so, but your call.
regards
Philipp
next prev parent reply other threads:[~2021-10-14 10:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 8:41 [PATCH v5 0/3] media: i2c: isl7998x: Add driver for Intersil ISL7998x Michael Tretter
2021-10-12 8:41 ` [PATCH v5 1/3] media: imx6-mipi-csi2: use pre_streamon callback to set sensor into LP11 Michael Tretter
2021-10-12 12:22 ` Philipp Zabel
2021-10-12 8:41 ` [PATCH v5 2/3] media: dt-bindings: Add Intersil ISL79987 DT bindings Michael Tretter
2021-10-12 8:41 ` [PATCH v5 3/3] media: i2c: isl7998x: Add driver for Intersil ISL7998x Michael Tretter
2021-10-12 13:27 ` Philipp Zabel
2021-10-13 8:05 ` Michael Tretter
2021-10-14 9:34 ` Michael Tretter
2021-10-14 10:17 ` Philipp Zabel [this message]
2021-10-14 10:45 ` Ian Arkver
2021-10-14 11:04 ` Michael Tretter
2021-10-14 12:07 ` Ian Arkver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=639592c9ca18232c3372ae33d6e561969b1f69e4.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
--cc=marex@denx.de \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).