From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
dmitry.baryshkov@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: ipq9574: Fix USB vdd info
Date: Mon, 10 Feb 2025 20:08:11 +0100 [thread overview]
Message-ID: <63b3f08d-c7c5-4ba9-a74b-5a7e0b8e7eb1@oss.qualcomm.com> (raw)
In-Reply-To: <20250207073545.1768990-2-quic_varada@quicinc.com>
On 7.02.2025 8:35 AM, Varadarajan Narayanan wrote:
> USB phys in ipq9574 use the 'L5' regulator. The commit ec4f047679d5
> ("arm64: dts: qcom: ipq9574: Enable USB") incorrectly specified it as
> 'L2'. Because of this when the phy module turns off/on its regulators,
> the wrong regulator is turned off/on resulting in 2 issues, namely the
> correct regulator related to the USB phy is not turned off/on and the
> module powered by the incorrect regulator is affected.
>
> Fixes: ec4f047679d5 ("arm64: dts: qcom: ipq9574: Enable USB")
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> v2: * Reword the commit message
> * Format to 72 chars
> * No code change
> ---
Thanks
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2025-02-10 19:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 7:35 [PATCH v2 0/1] Fix USB vdd info for IPQ9574 Varadarajan Narayanan
2025-02-07 7:35 ` [PATCH v2 1/1] arm64: dts: qcom: ipq9574: Fix USB vdd info Varadarajan Narayanan
2025-02-10 19:08 ` Konrad Dybcio [this message]
2025-02-07 8:56 ` [PATCH v2 0/1] Fix USB vdd info for IPQ9574 Jie Gan
2025-03-17 2:55 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63b3f08d-c7c5-4ba9-a74b-5a7e0b8e7eb1@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).