[PATCH v2 0/1] Fix USB vdd info for IPQ9574

[PATCH v2 0/1] Fix USB vdd info for IPQ9574

[Varadarajan Narayanan]

Use correct regulator for USB phy.

v2: * Skip the first patch as it has been pulled in
    * Reword and fix commit message formatting for the remaining patch

v1: For some reason, the dt-bindings [1] patch posted and Acked long
    time back seems to have slipped through the cracks and hasn't been
    merged. Including it along with this patch as both are related.
    dt_binding_check & dtbs_check passed.

    1 - https://lore.kernel.org/linux-arm-msm/170266996013.286103.17303148912355511017.robh@kernel.org/

Varadarajan Narayanan (1):
  arm64: dts: qcom: ipq9574: Fix USB vdd info

 arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)


base-commit: 40b8e93e17bff4a4e0cc129e04f9fdf5daa5397e
prerequisite-patch-id: d3da55704446c2222b5c624d9bb3a738357cb2fc
-- 
2.34.1

[PATCH v2 1/1] arm64: dts: qcom: ipq9574: Fix USB vdd info

[Varadarajan Narayanan]

USB phys in ipq9574 use the 'L5' regulator. The commit ec4f047679d5
("arm64: dts: qcom: ipq9574: Enable USB") incorrectly specified it as
'L2'. Because of this when the phy module turns off/on its regulators,
the wrong regulator is turned off/on resulting in 2 issues, namely the
correct regulator related to the USB phy is not turned off/on and the
module powered by the incorrect regulator is affected.

Fixes: ec4f047679d5 ("arm64: dts: qcom: ipq9574: Enable USB")
Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
---
v2: * Reword the commit message
    * Format to 72 chars
    * No code change
---
 arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
index ae12f069f26f..b24b795873d4 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
@@ -111,6 +111,13 @@ mp5496_l2: l2 {
 			regulator-always-on;
 			regulator-boot-on;
 		};
+
+		mp5496_l5: l5 {
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-always-on;
+			regulator-boot-on;
+		};
 	};
 };
 
@@ -146,7 +153,7 @@ &usb_0_dwc3 {
 };
 
 &usb_0_qmpphy {
-	vdda-pll-supply = <&mp5496_l2>;
+	vdda-pll-supply = <&mp5496_l5>;
 	vdda-phy-supply = <&regulator_fixed_0p925>;
 
 	status = "okay";
@@ -154,7 +161,7 @@ &usb_0_qmpphy {
 
 &usb_0_qusbphy {
 	vdd-supply = <&regulator_fixed_0p925>;
-	vdda-pll-supply = <&mp5496_l2>;
+	vdda-pll-supply = <&mp5496_l5>;
 	vdda-phy-dpdm-supply = <&regulator_fixed_3p3>;
 
 	status = "okay";
-- 
2.34.1

Re: [PATCH v2 1/1] arm64: dts: qcom: ipq9574: Fix USB vdd info

[Konrad Dybcio]

On 7.02.2025 8:35 AM, Varadarajan Narayanan wrote:
> USB phys in ipq9574 use the 'L5' regulator. The commit ec4f047679d5
> ("arm64: dts: qcom: ipq9574: Enable USB") incorrectly specified it as
> 'L2'. Because of this when the phy module turns off/on its regulators,
> the wrong regulator is turned off/on resulting in 2 issues, namely the
> correct regulator related to the USB phy is not turned off/on and the
> module powered by the incorrect regulator is affected.
> 
> Fixes: ec4f047679d5 ("arm64: dts: qcom: ipq9574: Enable USB")
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> v2: * Reword the commit message
>     * Format to 72 chars
>     * No code change
> ---

Thanks

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH v2 0/1] Fix USB vdd info for IPQ9574

[Jie Gan]

On 2/7/2025 3:35 PM, Varadarajan Narayanan wrote:
> Use correct regulator for USB phy.
> 
> v2: * Skip the first patch as it has been pulled in
>      * Reword and fix commit message formatting for the remaining patch
> 
You dont need the cover letter patch if you only have one patch.

B4 can handle it automatically.

Thanks,
Jie

> v1: For some reason, the dt-bindings [1] patch posted and Acked long
>      time back seems to have slipped through the cracks and hasn't been
>      merged. Including it along with this patch as both are related.
>      dt_binding_check & dtbs_check passed.
> 
>      1 - https://lore.kernel.org/linux-arm-msm/170266996013.286103.17303148912355511017.robh@kernel.org/
> 
> Varadarajan Narayanan (1):
>    arm64: dts: qcom: ipq9574: Fix USB vdd info
> 
>   arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
> 
> 
> base-commit: 40b8e93e17bff4a4e0cc129e04f9fdf5daa5397e
> prerequisite-patch-id: d3da55704446c2222b5c624d9bb3a738357cb2fc

Re: (subset) [PATCH v2 0/1] Fix USB vdd info for IPQ9574

[Bjorn Andersson]

On Fri, 07 Feb 2025 13:05:44 +0530, Varadarajan Narayanan wrote:
> Use correct regulator for USB phy.
> 
> v2: * Skip the first patch as it has been pulled in
>     * Reword and fix commit message formatting for the remaining patch
> 
> v1: For some reason, the dt-bindings [1] patch posted and Acked long
>     time back seems to have slipped through the cracks and hasn't been
>     merged. Including it along with this patch as both are related.
>     dt_binding_check & dtbs_check passed.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: ipq9574: Fix USB vdd info
      commit: 4f4c905e6a2a4e884f4e9b7326c94fac3500e0f9

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>