From: Alex Bee <knaerzche@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Lee Jones <lee@kernel.org>, Chris Zhong <zyw@rock-chips.com>,
Zhang Qing <zhangqing@rock-chips.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v2 1/5] dt-bindings: mfd: Add rk816 binding
Date: Sat, 23 Mar 2024 12:15:47 +0100 [thread overview]
Message-ID: <63c6caac-536e-49e9-aad2-a0c1f8b783d8@gmail.com> (raw)
In-Reply-To: <f892767c-7e01-4099-b674-0eca6edf7bba@linaro.org>
Am 23.03.24 um 12:02 schrieb Krzysztof Kozlowski:
> On 23/03/2024 11:56, Alex Bee wrote:
>> Hi Krzysztof,
>>
>> Am 23.03.24 um 11:32 schrieb Krzysztof Kozlowski:
>>> On 23/03/2024 09:58, Alex Bee wrote:
>>>> Add DT binding document for Rockchip's RK816 PMIC
>>>>
>>>> Signed-off-by: Alex Bee <knaerzche@gmail.com>
>>>> ---
>>>> changes since v1:
>>>> - lowercase/hyphens for regulator node names
>>>> - rename "-reg" to "-regulator" to make node names generic
>>> I don't understand why did you do it. I did not ask for it. If you want
>>> to rename, drop redundant regulator or reg suffix from node names.
>> You didn't ask for that, thats true.
>>
>> I did it regardless, since node names should be generic and the "-reg"
> device node names, here you do not have devices.
OK. I wasn't aware there's a difference between device nodes and
devices. I'll drop the suffix from the regulators.
> You did not respond to rest of my comments, so I assume you agree 100%
> with them.
I do.
Alex.
>
next prev parent reply other threads:[~2024-03-23 11:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 8:58 [PATCH v2 0/5] Add RK816 PMIC support Alex Bee
2024-03-23 8:58 ` [PATCH v2 1/5] dt-bindings: mfd: Add rk816 binding Alex Bee
2024-03-23 10:32 ` Krzysztof Kozlowski
2024-03-23 10:56 ` Alex Bee
2024-03-23 11:02 ` Krzysztof Kozlowski
2024-03-23 11:15 ` Alex Bee [this message]
2024-03-23 8:58 ` [PATCH v2 2/5] mfd: rk8xx: Add RK816 support Alex Bee
2024-03-23 8:58 ` [PATCH v2 3/5] pinctrl: rk805: Add rk816 pinctrl support Alex Bee
2024-03-23 8:58 ` [PATCH v2 4/5] regulator: rk808: Support apply_bit for rk808_set_suspend_voltage_range Alex Bee
2024-03-23 8:58 ` [PATCH v2 5/5] regulator: rk808: Add RK816 support Alex Bee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63c6caac-536e-49e9-aad2-a0c1f8b783d8@gmail.com \
--to=knaerzche@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox