From: Stephen Boyd <sboyd@kernel.org>
To: Ajit Pandey <quic_ajipan@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Taniya Das <quic_tdas@quicinc.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
Subject: Re: [PATCH V3 7/8] clk: qcom: Add GPUCC driver support for SM4450
Date: Wed, 29 May 2024 12:48:14 -0700 [thread overview]
Message-ID: <63d35ddacc113598f1822486b882552a.sboyd@kernel.org> (raw)
In-Reply-To: <ssnyujhgz64mbxawb43okjkdidd3tbxwjob36ikgbogy64xuqv@ckvir5vfqo63>
Quoting Dmitry Baryshkov (2024-05-28 06:23:27)
> On Tue, May 28, 2024 at 05:12:53PM +0530, Ajit Pandey wrote:
> > Add Graphics Clock Controller (GPUCC) support for SM4450 platform.
> >
> > Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
> > ---
> > drivers/clk/qcom/Kconfig | 9 +
> > drivers/clk/qcom/Makefile | 1 +
> > drivers/clk/qcom/gpucc-sm4450.c | 805 ++++++++++++++++++++++++++++++++
> > 3 files changed, 815 insertions(+)
> > create mode 100644 drivers/clk/qcom/gpucc-sm4450.c
>
> [trimmed]
>
> > +
> > + /* Keep some clocks always enabled */
> > + qcom_branch_set_clk_en(regmap, 0x93a4); /* GPU_CC_CB_CLK */
> > + qcom_branch_set_clk_en(regmap, 0x9004); /* GPU_CC_CXO_AON_CLK */
> > + qcom_branch_set_clk_en(regmap, 0x900c); /* GPU_CC_DEMET_CLK */
>
> I pinged Stephen regarding these clocks. LGTM otherwise.
>
Looks OK to me. I assume that these clks don't get turned off when the
GPU power domain is turned off. If that's the case then presumably we
would need to turn these on and off during power transitions.
next prev parent reply other threads:[~2024-05-29 19:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 11:42 [PATCH V3 0/8] clk: qcom: Add support for DISPCC, CAMCC and GPUCC on SM4450 Ajit Pandey
2024-05-28 11:42 ` [PATCH V3 1/8] clk: qcom: clk-alpha-pll: Fix CAL_L_VAL override for LUCID EVO PLL Ajit Pandey
2024-05-28 11:42 ` [PATCH V3 2/8] dt-bindings: clock: qcom: add DISPCC clocks on SM4450 Ajit Pandey
2024-05-28 11:42 ` [PATCH V3 3/8] clk: qcom: Add DISPCC driver support for SM4450 Ajit Pandey
2024-05-28 11:42 ` [PATCH V3 4/8] dt-bindings: clock: qcom: add CAMCC clocks on SM4450 Ajit Pandey
2024-05-28 11:42 ` [PATCH V3 5/8] clk: qcom: Add CAMCC driver support for SM4450 Ajit Pandey
2024-05-28 11:42 ` [PATCH V3 6/8] dt-bindings: clock: qcom: add GPUCC clocks on SM4450 Ajit Pandey
2024-05-28 11:42 ` [PATCH V3 7/8] clk: qcom: Add GPUCC driver support for SM4450 Ajit Pandey
2024-05-28 13:23 ` Dmitry Baryshkov
2024-05-29 19:48 ` Stephen Boyd [this message]
2024-06-06 6:11 ` Ajit Pandey
2024-06-06 14:18 ` Konrad Dybcio
2024-05-28 11:42 ` [PATCH V3 8/8] arm64: dts: qcom: sm4450: add camera, display and gpu clock controller Ajit Pandey
2024-05-28 13:15 ` Dmitry Baryshkov
2024-05-28 13:14 ` [PATCH V3 0/8] clk: qcom: Add support for DISPCC, CAMCC and GPUCC on SM4450 Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63d35ddacc113598f1822486b882552a.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).