devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>
To: "conor@kernel.org" <conor@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"Singo Chang (張興國)" <Singo.Chang@mediatek.com>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Johnson Wang (王聖鑫)" <Johnson.Wang@mediatek.com>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Jason-ch Chen (陳建豪)" <Jason-ch.Chen@mediatek.com>,
	"Shawn Sung (宋孝謙)" <Shawn.Sung@mediatek.com>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	"Nancy Lin (林欣螢)" <Nancy.Lin@mediatek.com>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v3 2/9] dt-bindings: mailbox: Add mboxes property for CMDQ secure driver
Date: Sat, 23 Dec 2023 18:38:31 +0000	[thread overview]
Message-ID: <63d64568f6c1ee68b81f9d8efb7c3c090e42e5ec.camel@mediatek.com> (raw)
In-Reply-To: <20231222-unpicked-jaundice-837baa3092ed@spud>

Hi Conor,

Thanks for the reviews.

On Fri, 2023-12-22 at 15:07 +0000, Conor Dooley wrote:
> On Fri, Dec 22, 2023 at 12:52:21PM +0800, Jason-JH.Lin wrote:
> > Add mboxes to define a GCE loopping thread as a secure irq handler.
> > This property is only required if CMDQ secure driver is supported.
> 
> What do drivers have to do with this? Either the mailbox channel
> exists
> or it does not. That said, I am not sure why this should be in DT in
> the
> first place, can't the driver for the mailbox controller reserve a
> channel for its own use?
> 
> Thanks,
> Conor.

Since we implemented our mtk-cmdq-mailbox driver with mailbox
frameworks, one mbox channel bounds to a GCE HW thread.
So if we want to request a mbox channel for using a GCE HW thread for
secure irq handler in mtk-cmdq-mailbox driver itself, I think we need
to add this property to DT.

Regards,
Jason-JH.Lin

[snip]

  reply	other threads:[~2023-12-23 18:38 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-22  4:52 [PATCH v3 0/9] Add CMDQ secure driver for SVP Jason-JH.Lin
2023-12-22  4:52 ` [PATCH v3 1/9] dt-bindings: gce: mt8195: Add CMDQ_SYNC_TOKEN_SECURE_THR_EOF event id Jason-JH.Lin
2023-12-22  4:52 ` [PATCH v3 2/9] dt-bindings: mailbox: Add mboxes property for CMDQ secure driver Jason-JH.Lin
2023-12-22 15:07   ` Conor Dooley
2023-12-23 18:38     ` Jason-JH Lin (林睿祥) [this message]
2023-12-22  4:52 ` [PATCH v3 3/9] soc: mediatek: cmdq: Add cmdq_pkt_logic_command to support math operation Jason-JH.Lin
2023-12-22  4:52 ` [PATCH v3 4/9] soc: mediatek: cmdq: Add cmdq_pkt_write_s_reg_value to support write value to reg Jason-JH.Lin
2023-12-22  4:52 ` [PATCH v3 5/9] mailbox: mtk-cmdq: Support GCE loop packets in interrupt handler Jason-JH.Lin
2023-12-22  4:52 ` [PATCH v3 6/9] soc: mediatek: cmdq: Add cmdq_pkt_finalize_loop for looping cmd with irq Jason-JH.Lin
2023-12-22  4:52 ` [PATCH v3 7/9] mailbox: mediatek: Move reuseable definition to header for secure driver Jason-JH.Lin
2023-12-22  4:52 ` [PATCH v3 8/9] mailbox: mediatek: Add CMDQ secure mailbox driver Jason-JH.Lin
2023-12-26  6:15   ` CK Hu (胡俊光)
2023-12-27  3:40     ` Jason-JH Lin (林睿祥)
2023-12-26  6:46   ` CK Hu (胡俊光)
2023-12-27  6:13     ` Jason-JH Lin (林睿祥)
2023-12-28  2:02       ` CK Hu (胡俊光)
2024-01-03  6:51         ` Jason-JH Lin (林睿祥)
2023-12-26  7:57   ` CK Hu (胡俊光)
2023-12-27  6:15     ` Jason-JH Lin (林睿祥)
2023-12-26  8:28   ` CK Hu (胡俊光)
2023-12-27  7:26     ` Jason-JH Lin (林睿祥)
2023-12-26  8:58   ` CK Hu (胡俊光)
2023-12-27  7:25     ` Jason-JH Lin (林睿祥)
2023-12-28  1:38       ` CK Hu (胡俊光)
2024-01-03  6:53         ` Jason-JH Lin (林睿祥)
2023-12-26  9:18   ` CK Hu (胡俊光)
2023-12-27  7:20     ` Jason-JH Lin (林睿祥)
2023-12-28  5:31   ` CK Hu (胡俊光)
2024-01-03  6:54     ` Jason-JH Lin (林睿祥)
2023-12-28  7:35   ` CK Hu (胡俊光)
2024-01-03  6:55     ` Jason-JH Lin (林睿祥)
2023-12-28  7:37   ` CK Hu (胡俊光)
2024-01-03  7:03     ` Jason-JH Lin (林睿祥)
2024-01-04  5:42       ` CK Hu (胡俊光)
2024-01-05  6:37         ` Jason-JH Lin (林睿祥)
2023-12-29  1:27   ` CK Hu (胡俊光)
2024-01-03  7:14     ` Jason-JH Lin (林睿祥)
2023-12-22  4:52 ` [PATCH v3 9/9] mailbox: mediatek: Add secure CMDQ driver support for CMDQ driver Jason-JH.Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63d64568f6c1ee68b81f9d8efb7c3c090e42e5ec.camel@mediatek.com \
    --to=jason-jh.lin@mediatek.com \
    --cc=Jason-ch.Chen@mediatek.com \
    --cc=Johnson.Wang@mediatek.com \
    --cc=Nancy.Lin@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=Shawn.Sung@mediatek.com \
    --cc=Singo.Chang@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).