* [PATCH 1/2] Add sw2_sw4 voltage table to cpcap regulator.
@ 2018-07-21 0:43 Peter Geis
2018-07-23 17:01 ` Mark Brown
0 siblings, 1 reply; 10+ messages in thread
From: Peter Geis @ 2018-07-21 0:43 UTC (permalink / raw)
To: girdwood
Cc: broonie, robh+dt, mark.rutland, linux-kernel, devicetree,
linux-tegra
SW2 and SW4 use a shared table to provide voltage to the cpu core and
devices on Tegra hardware.
Added this table to the cpcap regulator driver as the first step to
supporting this device on Tegra.
Signed-off-by: Peter Geis <pgwipeout@gmail.com>
---
drivers/regulator/cpcap-regulator.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/drivers/regulator/cpcap-regulator.c
b/drivers/regulator/cpcap-regulator.c
index bd910fe123d9..c0b1e04bd90f 100644
--- a/drivers/regulator/cpcap-regulator.c
+++ b/drivers/regulator/cpcap-regulator.c
@@ -271,6 +271,29 @@ static struct regulator_ops cpcap_regulator_ops = {
};
static const unsigned int unknown_val_tbl[] = { 0, };
+static const unsigned int sw2_sw4_val_tbl[] = { 612500, 625000, 637500,
+ 650000, 662500, 675000,
+ 687500, 700000, 712500,
+ 725000, 737500, 750000,
+ 762500, 775000, 787500,
+ 800000, 812500, 825000,
+ 837500, 850000, 862500,
+ 875000, 887500, 900000,
+ 912500, 925000, 937500,
+ 950000, 962500, 975000,
+ 987500, 1000000, 1012500,
+ 1025000, 1037500, 1050000,
+ 1062500, 1075000, 1087500,
+ 1100000, 1112500, 1125000,
+ 1137500, 1150000, 1162500,
+ 1175000, 1187500, 1200000,
+ 1212500, 1225000, 1237500,
+ 1250000, 1262500, 1275000,
+ 1287500, 1300000, 1312500,
+ 1325000, 1337500, 1350000,
+ 1362500, 1375000, 1387500,
+ 1400000, 1412500, 1425000,
+ 1437500, 1450000,
1462500, };
static const unsigned int sw5_val_tbl[] = { 0, 5050000, };
static const unsigned int vcam_val_tbl[] = { 2600000, 2700000, 2800000,
2900000, };
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/2] Add sw2_sw4 voltage table to cpcap regulator.
2018-07-21 0:43 [PATCH 1/2] Add sw2_sw4 voltage table to cpcap regulator Peter Geis
@ 2018-07-23 17:01 ` Mark Brown
2018-07-23 17:57 ` Peter Geis
0 siblings, 1 reply; 10+ messages in thread
From: Mark Brown @ 2018-07-23 17:01 UTC (permalink / raw)
To: Peter Geis
Cc: girdwood, robh+dt, mark.rutland, linux-kernel, devicetree,
linux-tegra
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
On Fri, Jul 20, 2018 at 08:43:49PM -0400, Peter Geis wrote:
> SW2 and SW4 use a shared table to provide voltage to the cpu core and
> devices on Tegra hardware.
> Added this table to the cpcap regulator driver as the first step to
> supporting this device on Tegra.
This fails to apply with:
Applying: Add sw2_sw4 voltage table to cpcap regulator.
.git/rebase-apply/patch:37: trailing whitespace.
1437500, 1450000,
error: corrupt patch at line 38
Patch failed at 0001 Add sw2_sw4 voltage table to cpcap regulator.
Please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/2] Add sw2_sw4 voltage table to cpcap regulator.
2018-07-23 17:01 ` Mark Brown
@ 2018-07-23 17:57 ` Peter Geis
0 siblings, 0 replies; 10+ messages in thread
From: Peter Geis @ 2018-07-23 17:57 UTC (permalink / raw)
To: Mark Brown
Cc: lgirdwood, robh+dt, mark.rutland, linux-kernel, devicetree,
linux-tegra
On 07/23/2018 01:01 PM, Mark Brown wrote:
> On Fri, Jul 20, 2018 at 08:43:49PM -0400, Peter Geis wrote:
>> SW2 and SW4 use a shared table to provide voltage to the cpu core and
>> devices on Tegra hardware.
>> Added this table to the cpcap regulator driver as the first step to
>> supporting this device on Tegra.
>
> This fails to apply with:
>
> Applying: Add sw2_sw4 voltage table to cpcap regulator.
> .git/rebase-apply/patch:37: trailing whitespace.
> 1437500, 1450000,
> error: corrupt patch at line 38
> Patch failed at 0001 Add sw2_sw4 voltage table to cpcap regulator.
>
> Please check and resend.
>
Apologies, I accidentally converted all of the tabs to spaces.
Re-sending both patches with tabulation intact.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] Add sw2_sw4 voltage table to cpcap regulator.
@ 2018-07-21 11:23 Peter Geis
2018-07-23 10:25 ` Mark Brown
0 siblings, 1 reply; 10+ messages in thread
From: Peter Geis @ 2018-07-21 11:23 UTC (permalink / raw)
To: lgirdwood, broonie
Cc: robh+dt, mark.rutland, linux-kernel, devicetree, linux-tegra
Re-sending due to email address typo.
SW2 and SW4 use a shared table to provide voltage to the cpu core and
devices on Tegra hardware.
Added this table to the cpcap regulator driver as the first step to
supporting this device on Tegra.
Signed-off-by: Peter Geis <pgwipeout@gmail.com>
---
drivers/regulator/cpcap-regulator.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/drivers/regulator/cpcap-regulator.c
b/drivers/regulator/cpcap-regulator.c
index bd910fe123d9..c0b1e04bd90f 100644
--- a/drivers/regulator/cpcap-regulator.c
+++ b/drivers/regulator/cpcap-regulator.c
@@ -271,6 +271,29 @@ static struct regulator_ops cpcap_regulator_ops = {
};
static const unsigned int unknown_val_tbl[] = { 0, };
+static const unsigned int sw2_sw4_val_tbl[] = { 612500, 625000, 637500,
+ 650000, 662500, 675000,
+ 687500, 700000, 712500,
+ 725000, 737500, 750000,
+ 762500, 775000, 787500,
+ 800000, 812500, 825000,
+ 837500, 850000, 862500,
+ 875000, 887500, 900000,
+ 912500, 925000, 937500,
+ 950000, 962500, 975000,
+ 987500, 1000000, 1012500,
+ 1025000, 1037500, 1050000,
+ 1062500, 1075000, 1087500,
+ 1100000, 1112500, 1125000,
+ 1137500, 1150000, 1162500,
+ 1175000, 1187500, 1200000,
+ 1212500, 1225000, 1237500,
+ 1250000, 1262500, 1275000,
+ 1287500, 1300000, 1312500,
+ 1325000, 1337500, 1350000,
+ 1362500, 1375000, 1387500,
+ 1400000, 1412500, 1425000,
+ 1437500, 1450000,
1462500, };
static const unsigned int sw5_val_tbl[] = { 0, 5050000, };
static const unsigned int vcam_val_tbl[] = { 2600000, 2700000, 2800000,
2900000, };
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/2] Add sw2_sw4 voltage table to cpcap regulator.
2018-07-21 11:23 Peter Geis
@ 2018-07-23 10:25 ` Mark Brown
0 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2018-07-23 10:25 UTC (permalink / raw)
To: Peter Geis
Cc: lgirdwood, robh+dt, mark.rutland, linux-kernel, devicetree,
linux-tegra
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
On Sat, Jul 21, 2018 at 07:23:31AM -0400, Peter Geis wrote:
> Re-sending due to email address typo.
>
> SW2 and SW4 use a shared table to provide voltage to the cpu core and
> devices on Tegra hardware.
> Added this table to the cpcap regulator driver as the first step to
> supporting this device on Tegra.
I'm missing patch 2 here, what's going on?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] Add sw2_sw4 voltage table to cpcap regulator.
@ 2018-07-23 17:58 Peter Geis
2018-07-23 18:13 ` Mark Brown
0 siblings, 1 reply; 10+ messages in thread
From: Peter Geis @ 2018-07-23 17:58 UTC (permalink / raw)
To: lgirdwood, broonie
Cc: robh+dt, mark.rutland, linux-kernel, devicetree, linux-tegra
SW2 and SW4 use a shared table to provide voltage to the cpu core and
devices on Tegra hardware.
Added this table to the cpcap regulator driver as the first step to
supporting this device on Tegra.
Signed-off-by: Peter Geis <pgwipeout@gmail.com>
---
drivers/regulator/cpcap-regulator.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/drivers/regulator/cpcap-regulator.c
b/drivers/regulator/cpcap-regulator.c
index bd910fe123d9..c0b1e04bd90f 100644
--- a/drivers/regulator/cpcap-regulator.c
+++ b/drivers/regulator/cpcap-regulator.c
@@ -271,6 +271,29 @@ static struct regulator_ops cpcap_regulator_ops = {
};
static const unsigned int unknown_val_tbl[] = { 0, };
+static const unsigned int sw2_sw4_val_tbl[] = { 612500, 625000, 637500,
+ 650000, 662500, 675000,
+ 687500, 700000, 712500,
+ 725000, 737500, 750000,
+ 762500, 775000, 787500,
+ 800000, 812500, 825000,
+ 837500, 850000, 862500,
+ 875000, 887500, 900000,
+ 912500, 925000, 937500,
+ 950000, 962500, 975000,
+ 987500, 1000000, 1012500,
+ 1025000, 1037500, 1050000,
+ 1062500, 1075000, 1087500,
+ 1100000, 1112500, 1125000,
+ 1137500, 1150000, 1162500,
+ 1175000, 1187500, 1200000,
+ 1212500, 1225000, 1237500,
+ 1250000, 1262500, 1275000,
+ 1287500, 1300000, 1312500,
+ 1325000, 1337500, 1350000,
+ 1362500, 1375000, 1387500,
+ 1400000, 1412500, 1425000,
+ 1437500, 1450000, 1462500, };
static const unsigned int sw5_val_tbl[] = { 0, 5050000, };
static const unsigned int vcam_val_tbl[] = { 2600000, 2700000, 2800000,
2900000, };
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/2] Add sw2_sw4 voltage table to cpcap regulator.
2018-07-23 17:58 Peter Geis
@ 2018-07-23 18:13 ` Mark Brown
2018-07-23 18:37 ` Peter Geis
0 siblings, 1 reply; 10+ messages in thread
From: Mark Brown @ 2018-07-23 18:13 UTC (permalink / raw)
To: Peter Geis
Cc: lgirdwood, robh+dt, mark.rutland, linux-kernel, devicetree,
linux-tegra
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
On Mon, Jul 23, 2018 at 01:58:26PM -0400, Peter Geis wrote:
> SW2 and SW4 use a shared table to provide voltage to the cpu core and
> devices on Tegra hardware.
> Added this table to the cpcap regulator driver as the first step to
> supporting this device on Tegra.
This also doesn't apply against current code (though it does now parse
OK), please check and resend - make sure you don't have other out of
tree changes and are using an up to date kernel (ideally my regulator
for-next branch) as a base.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] Add sw2_sw4 voltage table to cpcap regulator.
2018-07-23 18:13 ` Mark Brown
@ 2018-07-23 18:37 ` Peter Geis
2018-07-23 19:20 ` Dmitry Osipenko
0 siblings, 1 reply; 10+ messages in thread
From: Peter Geis @ 2018-07-23 18:37 UTC (permalink / raw)
To: Mark Brown
Cc: lgirdwood, robh+dt, mark.rutland, linux-kernel, devicetree,
linux-tegra
On 07/23/2018 02:13 PM, Mark Brown wrote:
> On Mon, Jul 23, 2018 at 01:58:26PM -0400, Peter Geis wrote:
>> SW2 and SW4 use a shared table to provide voltage to the cpu core and
>> devices on Tegra hardware.
>> Added this table to the cpcap regulator driver as the first step to
>> supporting this device on Tegra.
>
> This also doesn't apply against current code (though it does now parse
> OK), please check and resend - make sure you don't have other out of
> tree changes and are using an up to date kernel (ideally my regulator
> for-next branch) as a base.
>
Good Afternoon,
I thought it was my error in the patches being stripped, unfortunately
it seems to be a known Gmail behavior.
Any ideas on how to get around it?
Thanks,
Peter
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] Add sw2_sw4 voltage table to cpcap regulator.
2018-07-23 18:37 ` Peter Geis
@ 2018-07-23 19:20 ` Dmitry Osipenko
2018-07-23 19:43 ` Peter Geis
0 siblings, 1 reply; 10+ messages in thread
From: Dmitry Osipenko @ 2018-07-23 19:20 UTC (permalink / raw)
To: Peter Geis
Cc: Mark Brown, lgirdwood, robh+dt, mark.rutland, linux-kernel,
devicetree, linux-tegra
On Monday, 23 July 2018 21:37:50 MSK Peter Geis wrote:
> On 07/23/2018 02:13 PM, Mark Brown wrote:
> > On Mon, Jul 23, 2018 at 01:58:26PM -0400, Peter Geis wrote:
> >> SW2 and SW4 use a shared table to provide voltage to the cpu core and
> >> devices on Tegra hardware.
> >> Added this table to the cpcap regulator driver as the first step to
> >> supporting this device on Tegra.
> >
> > This also doesn't apply against current code (though it does now parse
> > OK), please check and resend - make sure you don't have other out of
> > tree changes and are using an up to date kernel (ideally my regulator
> > for-next branch) as a base.
>
> Good Afternoon,
>
> I thought it was my error in the patches being stripped, unfortunately
> it seems to be a known Gmail behavior.
> Any ideas on how to get around it?
Use the "git send-email" instead of email client.
You need to create and send out patches using git, that will be something like
this:
1) "git format-patch -v1 -2 ..." to make patches
2) "git send-email --smtp-server=smtp.gmail.com --smtp-
user=pgwipeout@gmail.com --smtp-encryption=tls --smtp-server-port=587 --
suppress-cc=all --confirm=always --to 'Mark Brown <broonie@kernel.org>' --cc
'linux-tegra@vger.kernel.org' --cc 'linux-kernel@vger.kernel.org' ...
00*.patch" to send out the patches
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] Add sw2_sw4 voltage table to cpcap regulator.
2018-07-23 19:20 ` Dmitry Osipenko
@ 2018-07-23 19:43 ` Peter Geis
0 siblings, 0 replies; 10+ messages in thread
From: Peter Geis @ 2018-07-23 19:43 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Mark Brown, lgirdwood, robh+dt, mark.rutland, linux-kernel,
devicetree, linux-tegra
On 07/23/2018 03:20 PM, Dmitry Osipenko wrote:
> On Monday, 23 July 2018 21:37:50 MSK Peter Geis wrote:
>> On 07/23/2018 02:13 PM, Mark Brown wrote:
>>> On Mon, Jul 23, 2018 at 01:58:26PM -0400, Peter Geis wrote:
>>>> SW2 and SW4 use a shared table to provide voltage to the cpu core and
>>>> devices on Tegra hardware.
>>>> Added this table to the cpcap regulator driver as the first step to
>>>> supporting this device on Tegra.
>>>
>>> This also doesn't apply against current code (though it does now parse
>>> OK), please check and resend - make sure you don't have other out of
>>> tree changes and are using an up to date kernel (ideally my regulator
>>> for-next branch) as a base.
>>
>> Good Afternoon,
>>
>> I thought it was my error in the patches being stripped, unfortunately
>> it seems to be a known Gmail behavior.
>> Any ideas on how to get around it?
>
> Use the "git send-email" instead of email client.
>
> You need to create and send out patches using git, that will be something like
> this:
>
> 1) "git format-patch -v1 -2 ..." to make patches
> 2) "git send-email --smtp-server=smtp.gmail.com --smtp-
> user=pgwipeout@gmail.com --smtp-encryption=tls --smtp-server-port=587 --
> suppress-cc=all --confirm=always --to 'Mark Brown <broonie@kernel.org>' --cc
> 'linux-tegra@vger.kernel.org' --cc 'linux-kernel@vger.kernel.org' ...
> 00*.patch" to send out the patches
>
As always, thanks Dmitry!
Resent through git this time.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-07-23 19:43 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-21 0:43 [PATCH 1/2] Add sw2_sw4 voltage table to cpcap regulator Peter Geis
2018-07-23 17:01 ` Mark Brown
2018-07-23 17:57 ` Peter Geis
-- strict thread matches above, loose matches on Subject: below --
2018-07-21 11:23 Peter Geis
2018-07-23 10:25 ` Mark Brown
2018-07-23 17:58 Peter Geis
2018-07-23 18:13 ` Mark Brown
2018-07-23 18:37 ` Peter Geis
2018-07-23 19:20 ` Dmitry Osipenko
2018-07-23 19:43 ` Peter Geis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).