From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3683C47090 for ; Tue, 6 Dec 2022 08:32:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233790AbiLFIce (ORCPT ); Tue, 6 Dec 2022 03:32:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233826AbiLFIc1 (ORCPT ); Tue, 6 Dec 2022 03:32:27 -0500 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A2F71AF13 for ; Tue, 6 Dec 2022 00:32:20 -0800 (PST) Received: by mail-lj1-x22f.google.com with SMTP id q7so16372611ljp.9 for ; Tue, 06 Dec 2022 00:32:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=g/U0+bRA30/guCjp3BjPsilCOo26Q3nbofGjk/PAYTc=; b=lX64SB0AHg+zC6GCkwFDi3a/DgyIdNKjjPyFEkcPIndhQtcDMtI2HSEpfEdMIEkqBS AaLFtGuGsXA4oywVHcNJmgvU9gAtdbuleQ39BhLTRfWHOY5IxmQ2TqOV+QC8pZlXc5mZ npSqljv47Z+Pyj1GgvgIujBC2PQW/BVYnBK2HD4YR1zTQGvBdWn1e31Wx+r/rXcw0EWi XFq3nELeXTi5gKPzgvc1pHOPsf79eJPIlH9BczTM1iGHdFZI1abKp5nezCzBet1Zs4rR zgztbIYEZ11Tj4F7Vd09Rziw56fQWVajZO+GmBbAub1Qp5LohUgxZ2BGGKS5ay5xL+Ow 000A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g/U0+bRA30/guCjp3BjPsilCOo26Q3nbofGjk/PAYTc=; b=IESjRoZEBDsGjNFmnlJG9ZYKNef91Qc/sonXJjhpCoUSvOekyMbuUW1neebzJfKgtw I2ugRBz2PkdgFLE8rKaPa4lm2zYnramN+WdYaC2T48h9C0hkUsCSGH2Eg3wBFZku8aF2 HnMgtSBhntasPJMRA/21qhx/MHxFCd9+bXN3g3Zf72nJ0FRwMMdA1UH424j1Ij9ZzHRM rVo9beQQRgT5qBw+cmgD+H8ldZV/K+YfsmsTFJvBgXx+PKDFSL/NP39tdab2tR1l/8t1 DIRgmmxpXsIiq6WJNBCwng47EgaCI2pUm4JjJnxNw/ki18nx2QvqsSaNI5SsbqHkdelI 4lSA== X-Gm-Message-State: ANoB5pmBfbsKRaZ96P2nSCeM305io8y9LELYNELJzufLsbiIKE/aHUPG 1/kikQYcHdq8Hf/5ANkJpodwfw== X-Google-Smtp-Source: AA0mqf4TihAnfhidTWmryUNmodx2rjq7DG2qDLZsA/FbwYTTKb5ZxqFKlPpNGD89VRVGzBppANz9IA== X-Received: by 2002:a05:651c:1948:b0:277:21c8:aac5 with SMTP id bs8-20020a05651c194800b0027721c8aac5mr22217972ljb.491.1670315538789; Tue, 06 Dec 2022 00:32:18 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id be11-20020a05651c170b00b002799b5aa42esm1585784ljb.55.2022.12.06.00.32.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Dec 2022 00:32:18 -0800 (PST) Message-ID: <63e1e565-b1e7-ecfc-009a-ee036108f160@linaro.org> Date: Tue, 6 Dec 2022 09:32:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/5] dt-bindings: dma: ti: k3-bcdma: Add bindings for BCDMA CSI RX Content-Language: en-US To: Vignesh Raghavendra , Peter Ujfalusi , Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221206043554.1521522-1-vigneshr@ti.com> <20221206043554.1521522-2-vigneshr@ti.com> From: Krzysztof Kozlowski In-Reply-To: <20221206043554.1521522-2-vigneshr@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/12/2022 05:35, Vignesh Raghavendra wrote: > AM62A SoC has a dedicated BCDMA that serves Camera Serial Interface > (CSI) IP. Add new compatible for the same. Unlike system > BCDMA, this instance only has RX DMA channels and lack TX or block copy > channel. Thus make those properties optional. Additionally CSI RX has > independent power domain, add the binding for the same. > > Signed-off-by: Vignesh Raghavendra > --- > .../devicetree/bindings/dma/ti/k3-bcdma.yaml | 87 ++++++++++++++----- > 1 file changed, 63 insertions(+), 24 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml > index 08627d91e607..d7b5adbb9b2e 100644 > --- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml > +++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml > @@ -32,9 +32,66 @@ allOf: > - $ref: /schemas/dma/dma-controller.yaml# > - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml# > When adding if:then:, please move entire allOf after "required:" part. > + - if: > + properties: > + compatible: > + contains: > + const: ti,am62a-dmss-bcdma-csirx > + then: > + properties: > + ti,sci-rm-range-bchan: false > + ti,sci-rm-range-tchan: false > + > + reg: > + maxItems: 3 > + > + reg-names: > + items: > + - const: gcfg > + - const: rchanrt > + - const: ringrt With my changes further this can be only "maxItems: 3" > + > + required: > + - compatible > + - "#dma-cells" > + - reg > + - reg-names > + - msi-parent > + - ti,sci > + - ti,sci-dev-id > + - ti,sci-rm-range-rchan > + - power-domains > + > + else: > + properties: > + reg: > + maxItems: 5 > + > + reg-names: > + items: > + - const: gcfg > + - const: bchanrt > + - const: rchanrt > + - const: tchanrt > + - const: ringrt With my changes further this can be only "minItems: 5" > + > + required: > + - compatible > + - "#dma-cells" > + - reg > + - reg-names > + - msi-parent > + - ti,sci > + - ti,sci-dev-id > + - ti,sci-rm-range-bchan > + - ti,sci-rm-range-tchan > + - ti,sci-rm-range-rchan > + > properties: > compatible: > - const: ti,am64-dmss-bcdma > + enum: > + - ti,am64-dmss-bcdma > + - ti,am62a-dmss-bcdma-csirx Keep some order, e.g. alphabetical. This reduces later conflicts on simultaneous edits. > > "#dma-cells": > const: 3 > @@ -65,19 +122,13 @@ properties: > > cell 3: ASEL value for the channel > > - reg: > - maxItems: 5 Keep it here with widest constrains - minItems: 3, maxItems: 5 > - > - reg-names: > - items: > - - const: gcfg > - - const: bchanrt > - - const: rchanrt > - - const: tchanrt > - - const: ringrt Keep the list here with minItems: 3 > - > msi-parent: true > > + power-domains: > + description: > + Power domain if available > + maxItems: 1 > + > ti,asel: > $ref: /schemas/types.yaml#/definitions/uint32 > description: ASEL value for non slave channels > @@ -115,18 +166,6 @@ properties: > items: > maximum: 0x3f > > -required: > - - compatible > - - "#dma-cells" > - - reg > - - reg-names > - - msi-parent > - - ti,sci > - - ti,sci-dev-id > - - ti,sci-rm-range-bchan > - - ti,sci-rm-range-tchan > - - ti,sci-rm-range-rchan Keep required here. Customize it if needed in if:then:else. > - > unevaluatedProperties: false > > examples: Best regards, Krzysztof