devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Connor Abbott <cwabbott0@gmail.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Jun Nie <jun.nie@linaro.org>, Rob Clark <robdclark@gmail.com>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	freedreno@lists.freedesktop.org
Subject: Re: [PATCH v2 5/6] drm/msm: Add MSM_PARAM_RAYTRACING uapi
Date: Sat, 27 Apr 2024 14:20:33 +0200	[thread overview]
Message-ID: <63e34870-fb01-4769-aca9-8ac6843c12b3@linaro.org> (raw)
In-Reply-To: <20240426-a750-raytracing-v2-5-562ac9866d63@gmail.com>

On 26.04.2024 8:34 PM, Connor Abbott wrote:
> Expose the value of the software fuse to userspace.
> 
> Signed-off-by: Connor Abbott <cwabbott0@gmail.com>
> ---
>  drivers/gpu/drm/msm/adreno/adreno_gpu.c | 3 +++
>  include/uapi/drm/msm_drm.h              | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> index 074fb498706f..99ad651857b2 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -376,6 +376,9 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_file_private *ctx,
>  	case MSM_PARAM_HIGHEST_BANK_BIT:
>  		*value = adreno_gpu->ubwc_config.highest_bank_bit;
>  		return 0;
> +	case MSM_PARAM_RAYTRACING:
> +		*value = adreno_gpu->has_ray_tracing;
> +		return 0;

I'd personally go with MSM_PARAM_FEATURES as a u64 bitmap, but it's
not me that'll have to deal with this on the userland side, so:

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

  parent reply	other threads:[~2024-04-27 12:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-26 18:33 [PATCH v2 0/6] drm/msm: Support a750 "software fuse" for raytracing Connor Abbott
2024-04-26 18:33 ` [PATCH v2 1/6] arm64: dts: qcom: sm8650: Fix GPU cx_mem size Connor Abbott
2024-04-26 18:36   ` Dmitry Baryshkov
2024-04-27 12:04   ` Konrad Dybcio
2024-05-02  8:03   ` Neil Armstrong
2024-04-26 18:34 ` [PATCH v2 2/6] firmware: qcom_scm: Add gpu_init_regs call Connor Abbott
2024-04-26 18:38   ` Dmitry Baryshkov
2024-04-27 12:07   ` Konrad Dybcio
2024-04-26 18:34 ` [PATCH v2 3/6] drm/msm: Update a6xx registers Connor Abbott
2024-04-26 18:38   ` Dmitry Baryshkov
2024-04-26 18:34 ` [PATCH v2 4/6] drm/msm/a7xx: Initialize a750 "software fuse" Connor Abbott
2024-04-26 18:44   ` Dmitry Baryshkov
2024-04-27 12:19   ` Konrad Dybcio
2024-04-30 10:31     ` Connor Abbott
2024-04-26 18:34 ` [PATCH v2 5/6] drm/msm: Add MSM_PARAM_RAYTRACING uapi Connor Abbott
2024-04-26 18:44   ` Dmitry Baryshkov
2024-04-27 12:20   ` Konrad Dybcio [this message]
2024-04-26 18:34 ` [PATCH v2 6/6] drm/msm/a7xx: Add missing register writes from downstream Connor Abbott
2024-04-27 12:23   ` Konrad Dybcio
2024-05-01 20:20 ` (subset) [PATCH v2 0/6] drm/msm: Support a750 "software fuse" for raytracing Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63e34870-fb01-4769-aca9-8ac6843c12b3@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cwabbott0@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jun.nie@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh@kernel.org \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).