devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: guoniu.zhou@oss.nxp.com, linux-media@vger.kernel.org,
	linux-imx@nxp.com, devicetree@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, xavier.roumegue@oss.nxp.com,
	kernel@pengutronix.de, jacopo.mondi@ideasonboard.com,
	sakari.ailus@linux.intel.com
Subject: Re: [PATCH 3/4] media: dt-bindings: media: nxp,imx-isi: i.MX93 support
Date: Sun, 25 Jun 2023 10:22:08 +0200	[thread overview]
Message-ID: <63eb8605-fa23-fe13-e635-1cfdbcafb5c7@linaro.org> (raw)
In-Reply-To: <20230625080916.3553621-4-guoniu.zhou@oss.nxp.com>

On 25/06/2023 10:09, guoniu.zhou@oss.nxp.com wrote:
> From: "Guoniu.zhou" <guoniu.zhou@nxp.com>
> 
> Add i.MX93 support since it reuse ISI which used in i.MX8M family.
> 
> Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>

Subject: Drop duplicated "media:"

> ---
>  Documentation/devicetree/bindings/media/nxp,imx-isi.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml
> index 1ce9440bde32..ddad1d8778f3 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml
> @@ -21,6 +21,7 @@ properties:
>      enum:
>        - fsl,imx8mn-isi
>        - fsl,imx8mp-isi
> +      - fsl,imx93-isi

Imx93 is a family of devices, not specific device, so I hope you
understand that it is a bit against the recommendation of specific
compatibles and you guarantee that all devices within family will be
identical.



Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


---

This is an automated instruction, just in case, because many review tags
are being ignored. If you do not know the process, here is a short
explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tools like b4 can help
here. However, there's no need to repost patches *only* to add the tags.
The upstream maintainer will do that for acks received on the version
they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

Best regards,
Krzysztof


  reply	other threads:[~2023-06-25  8:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-25  8:09 [PATCH 0/4] add ISI support for i.MX93 guoniu.zhou
2023-06-25  8:09 ` [PATCH 1/4] media: dt-bindings: media: rename nxp,imx8-isi.yaml to nxp,imx-isi.yaml guoniu.zhou
2023-06-25  8:18   ` Krzysztof Kozlowski
2023-06-25  8:09 ` [PATCH 2/4] media: nxp: rename imx8-isi to imx-isi and remove reference to i.MX8 guoniu.zhou
2023-06-25  8:28   ` Krzysztof Kozlowski
2023-06-25  8:09 ` [PATCH 3/4] media: dt-bindings: media: nxp,imx-isi: i.MX93 support guoniu.zhou
2023-06-25  8:22   ` Krzysztof Kozlowski [this message]
2023-06-25  8:27     ` Krzysztof Kozlowski
2023-06-27 14:20       ` Rob Herring
2023-06-25  8:28     ` G.N. Zhou (OSS)
2023-06-25  8:47       ` G.N. Zhou
2023-06-25  9:15         ` Krzysztof Kozlowski
2023-06-26  2:14           ` G.N. Zhou (OSS)
2023-06-25  8:09 ` [PATCH 4/4] media: nxp: imx-isi: add ISI support for i.MX93 guoniu.zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63eb8605-fa23-fe13-e635-1cfdbcafb5c7@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=guoniu.zhou@oss.nxp.com \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=xavier.roumegue@oss.nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).