* [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes
@ 2022-11-08 7:32 Bhavya Kapoor
2022-11-08 18:18 ` Krzysztof Kozlowski
0 siblings, 1 reply; 12+ messages in thread
From: Bhavya Kapoor @ 2022-11-08 7:32 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, linux-kernel, devicetree
Cc: linux-arm-kernel, vigneshr, nm, piyali_g
J721S2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
for 8 channel ADCs for J721S2.
Enable ADCs present on J721S2 soc.
Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
---
.../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
.../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 40 +++++++++++++++++++
2 files changed, 54 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
index b210cc07c539..de9cb40273be 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
@@ -429,3 +429,17 @@
&main_mcan17 {
status = "disabled";
};
+
+&tscadc0 {
+ status = "okay";
+ adc {
+ ti,adc-channels = <0 1 2 3 4 5 6 7>;
+ };
+};
+
+&tscadc1 {
+ status = "okay";
+ adc {
+ ti,adc-channels = <0 1 2 3 4 5 6 7>;
+ };
+};
diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
index 4d1bfabd1313..47a7a6b500c2 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
@@ -299,4 +299,44 @@
ti,cpts-periodic-outputs = <2>;
};
};
+
+ tscadc0: tscadc@40200000 {
+ compatible = "ti,am3359-tscadc";
+ reg = <0x0 0x40200000 0x0 0x1000>;
+ interrupts = <GIC_SPI 892 IRQ_TYPE_LEVEL_HIGH>;
+ power-domains = <&k3_pds 0 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 0 0>;
+ assigned-clocks = <&k3_clks 0 2>;
+ assigned-clock-rates = <60000000>;
+ clock-names = "adc_tsc_fck";
+ dmas = <&main_udmap 0x7400>,
+ <&main_udmap 0x7401>;
+ dma-names = "fifo0", "fifo1";
+ status = "disabled";
+
+ adc {
+ #io-channel-cells = <1>;
+ compatible = "ti,am3359-adc";
+ };
+ };
+
+ tscadc1: tscadc@40210000 {
+ compatible = "ti,am3359-tscadc";
+ reg = <0x0 0x40210000 0x0 0x1000>;
+ interrupts = <GIC_SPI 893 IRQ_TYPE_LEVEL_HIGH>;
+ power-domains = <&k3_pds 1 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 1 0>;
+ assigned-clocks = <&k3_clks 1 2>;
+ assigned-clock-rates = <60000000>;
+ clock-names = "adc_tsc_fck";
+ dmas = <&main_udmap 0x7402>,
+ <&main_udmap 0x7403>;
+ dma-names = "fifo0", "fifo1";
+ status = "disabled";
+
+ adc {
+ #io-channel-cells = <1>;
+ compatible = "ti,am3359-adc";
+ };
+ };
};
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes
2022-11-08 7:32 [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes Bhavya Kapoor
@ 2022-11-08 18:18 ` Krzysztof Kozlowski
2022-11-09 6:47 ` [EXTERNAL] " Bhavya Kapoor
2022-12-20 9:56 ` Bhavya Kapoor
0 siblings, 2 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-08 18:18 UTC (permalink / raw)
To: Bhavya Kapoor, robh+dt, krzysztof.kozlowski+dt, linux-kernel,
devicetree
Cc: linux-arm-kernel, vigneshr, nm, piyali_g
On 08/11/2022 08:32, Bhavya Kapoor wrote:
> J721S2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
> for 8 channel ADCs for J721S2.
>
> Enable ADCs present on J721S2 soc.
>
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 40 +++++++++++++++++++
> 2 files changed, 54 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> index b210cc07c539..de9cb40273be 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> @@ -429,3 +429,17 @@
> &main_mcan17 {
> status = "disabled";
> };
> +
> +&tscadc0 {
> + status = "okay";
> + adc {
> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
> + };
> +};
> +
> +&tscadc1 {
> + status = "okay";
> + adc {
> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
> + };
> +};
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> index 4d1bfabd1313..47a7a6b500c2 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> @@ -299,4 +299,44 @@
> ti,cpts-periodic-outputs = <2>;
> };
> };
> +
> + tscadc0: tscadc@40200000 {
Node names should be generic, so "adc"
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes
2022-11-08 18:18 ` Krzysztof Kozlowski
@ 2022-11-09 6:43 ` Bhavya Kapoor
0 siblings, 0 replies; 12+ messages in thread
From: Bhavya Kapoor @ 2022-11-09 6:43 UTC (permalink / raw)
To: Krzysztof Kozlowski, robh+dt, krzysztof.kozlowski+dt,
linux-kernel, devicetree
Cc: linux-arm-kernel, vigneshr, nm
Hi,
its a mistake as i ended up sending the same patch twice
Regards
BK
On 11/8/22 11:48 PM, Krzysztof Kozlowski wrote:
> On 08/11/2022 08:32, Bhavya Kapoor wrote:
>> J721S2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>> for 8 channel ADCs for J721S2.
>>
>> Enable ADCs present on J721S2 soc.
>>
>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>> ---
> And this is a v2? Or resend? Or something else?
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes
2022-11-08 18:18 ` Krzysztof Kozlowski
@ 2022-11-09 6:47 ` Bhavya Kapoor
2022-12-20 9:56 ` Bhavya Kapoor
1 sibling, 0 replies; 12+ messages in thread
From: Bhavya Kapoor @ 2022-11-09 6:47 UTC (permalink / raw)
To: Krzysztof Kozlowski, robh+dt, krzysztof.kozlowski+dt,
linux-kernel, devicetree
Cc: linux-arm-kernel, vigneshr, nm, piyali_g
On 11/8/22 11:48 PM, Krzysztof Kozlowski wrote:
> On 08/11/2022 08:32, Bhavya Kapoor wrote:
>> J721S2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>> for 8 channel ADCs for J721S2.
>>
>> Enable ADCs present on J721S2 soc.
>>
>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>> ---
>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 40 +++++++++++++++++++
>> 2 files changed, 54 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> index b210cc07c539..de9cb40273be 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> @@ -429,3 +429,17 @@
>> &main_mcan17 {
>> status = "disabled";
>> };
>> +
>> +&tscadc0 {
>> + status = "okay";
>> + adc {
>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>> + };
>> +};
>> +
>> +&tscadc1 {
>> + status = "okay";
>> + adc {
>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>> + };
>> +};
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
>> index 4d1bfabd1313..47a7a6b500c2 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
>> @@ -299,4 +299,44 @@
>> ti,cpts-periodic-outputs = <2>;
>> };
>> };
>> +
>> + tscadc0: tscadc@40200000 {
> Node names should be generic, so "adc"
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
tscadc is just a wrapper node. The actual adc node is inside of tscadc node.
>
> Best regards,
> Krzysztof
>
Regards
BK
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes
2022-11-08 18:18 ` Krzysztof Kozlowski
2022-11-09 6:47 ` [EXTERNAL] " Bhavya Kapoor
@ 2022-12-20 9:56 ` Bhavya Kapoor
1 sibling, 0 replies; 12+ messages in thread
From: Bhavya Kapoor @ 2022-12-20 9:56 UTC (permalink / raw)
To: Krzysztof Kozlowski, robh+dt, krzysztof.kozlowski+dt,
linux-kernel, devicetree
Cc: linux-arm-kernel, vigneshr, nm, piyali_g
Hi, please drop this patch since the interrupt values supplied for
tscadc are incorrect.
On 08/11/22 23:48, Krzysztof Kozlowski wrote:
> On 08/11/2022 08:32, Bhavya Kapoor wrote:
>> J721S2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>> for 8 channel ADCs for J721S2.
>>
>> Enable ADCs present on J721S2 soc.
>>
>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>> ---
>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 40 +++++++++++++++++++
>> 2 files changed, 54 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> index b210cc07c539..de9cb40273be 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> @@ -429,3 +429,17 @@
>> &main_mcan17 {
>> status = "disabled";
>> };
>> +
>> +&tscadc0 {
>> + status = "okay";
>> + adc {
>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>> + };
>> +};
>> +
>> +&tscadc1 {
>> + status = "okay";
>> + adc {
>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>> + };
>> +};
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
>> index 4d1bfabd1313..47a7a6b500c2 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
>> @@ -299,4 +299,44 @@
>> ti,cpts-periodic-outputs = <2>;
>> };
>> };
>> +
>> + tscadc0: tscadc@40200000 {
> Node names should be generic, so "adc"
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes
2022-12-20 10:50 ` Krzysztof Kozlowski
@ 2022-12-21 5:42 ` Bhavya Kapoor
2022-12-21 7:54 ` Krzysztof Kozlowski
0 siblings, 1 reply; 12+ messages in thread
From: Bhavya Kapoor @ 2022-12-21 5:42 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-kernel, devicetree
Cc: linux-arm-kernel, krzysztof.kozlowski+dt, robh+dt, kristo, nm
On 20/12/22 16:20, Krzysztof Kozlowski wrote:
> On 20/12/2022 11:12, Bhavya Kapoor wrote:
>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>> for 8 channel ADCs for J721s2 SoC.
>>
>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>> ---
>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> index a7aa6cf08acd..67593aa69327 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>> phys = <&transceiver2>;
>> };
>> +
>> +&tscadc0 {
>> + status = "okay";
>> + adc {
>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>> + };
>> +};
>> +
>> +&tscadc1 {
>> + status = "okay";
>> + adc {
>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>> + };
>> +};
>> \ No newline at end of file
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> Thank you.
>
> Best regards,
> Krzysztof
Hi , I thought i did addressed the feedback since tscadc is just a
wrapper node.
The actual adc node is inside of tscadc node.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes
2022-12-21 5:42 ` [EXTERNAL] " Bhavya Kapoor
@ 2022-12-21 7:54 ` Krzysztof Kozlowski
2022-12-22 10:39 ` Bhavya Kapoor
0 siblings, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-21 7:54 UTC (permalink / raw)
To: Bhavya Kapoor, linux-kernel, devicetree
Cc: linux-arm-kernel, krzysztof.kozlowski+dt, robh+dt, kristo, nm
On 21/12/2022 06:42, Bhavya Kapoor wrote:
>
> On 20/12/22 16:20, Krzysztof Kozlowski wrote:
>> On 20/12/2022 11:12, Bhavya Kapoor wrote:
>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>>> for 8 channel ADCs for J721s2 SoC.
>>>
>>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>>> ---
>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>> index a7aa6cf08acd..67593aa69327 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>>> phys = <&transceiver2>;
>>> };
>>> +
>>> +&tscadc0 {
>>> + status = "okay";
>>> + adc {
>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>> + };
>>> +};
>>> +
>>> +&tscadc1 {
>>> + status = "okay";
>>> + adc {
>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>> + };
>>> +};
>>> \ No newline at end of file
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my
>> feedback got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all
>> requested changes or keep discussing them.
>>
>> Thank you.
>>
>> Best regards,
>> Krzysztof
>
> Hi , I thought i did addressed the feedback since tscadc is just a
> wrapper node.
>
> The actual adc node is inside of tscadc node.
Read the feedback, from all emails.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes
2022-12-21 7:54 ` Krzysztof Kozlowski
@ 2022-12-22 10:39 ` Bhavya Kapoor
2022-12-22 10:46 ` Krzysztof Kozlowski
0 siblings, 1 reply; 12+ messages in thread
From: Bhavya Kapoor @ 2022-12-22 10:39 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-kernel, devicetree
Cc: linux-arm-kernel, krzysztof.kozlowski+dt, robh+dt, kristo, nm
On 21/12/22 13:24, Krzysztof Kozlowski wrote:
> On 21/12/2022 06:42, Bhavya Kapoor wrote:
>> On 20/12/22 16:20, Krzysztof Kozlowski wrote:
>>> On 20/12/2022 11:12, Bhavya Kapoor wrote:
>>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>>>> for 8 channel ADCs for J721s2 SoC.
>>>>
>>>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>>>> ---
>>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>>>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>> index a7aa6cf08acd..67593aa69327 100644
>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>>>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>>>> phys = <&transceiver2>;
>>>> };
>>>> +
>>>> +&tscadc0 {
>>>> + status = "okay";
>>>> + adc {
>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>> + };
>>>> +};
>>>> +
>>>> +&tscadc1 {
>>>> + status = "okay";
>>>> + adc {
>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>> + };
>>>> +};
>>>> \ No newline at end of file
>>> This is a friendly reminder during the review process.
>>>
>>> It seems my previous comments were not fully addressed. Maybe my
>>> feedback got lost between the quotes, maybe you just forgot to apply it.
>>> Please go back to the previous discussion and either implement all
>>> requested changes or keep discussing them.
>>>
>>> Thank you.
>>>
>>> Best regards,
>>> Krzysztof
>> Hi , I thought i did addressed the feedback since tscadc is just a
>> wrapper node.
>>
>> The actual adc node is inside of tscadc node.
> Read the feedback, from all emails.
> Best regards,
> Krzysztof
Hi , i have gone through all earlier mails but can't find anything else.
Can you point out again whats the issue.
Regards
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes
2022-12-22 10:39 ` Bhavya Kapoor
@ 2022-12-22 10:46 ` Krzysztof Kozlowski
2022-12-22 11:53 ` Bhavya Kapoor
0 siblings, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-22 10:46 UTC (permalink / raw)
To: Bhavya Kapoor, linux-kernel, devicetree
Cc: linux-arm-kernel, krzysztof.kozlowski+dt, robh+dt, kristo, nm
On 22/12/2022 11:39, Bhavya Kapoor wrote:
>
> On 21/12/22 13:24, Krzysztof Kozlowski wrote:
>> On 21/12/2022 06:42, Bhavya Kapoor wrote:
>>> On 20/12/22 16:20, Krzysztof Kozlowski wrote:
>>>> On 20/12/2022 11:12, Bhavya Kapoor wrote:
>>>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>>>>> for 8 channel ADCs for J721s2 SoC.
>>>>>
>>>>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>>>>> ---
>>>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>>>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>>>>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>> index a7aa6cf08acd..67593aa69327 100644
>>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>>>>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>>>>> phys = <&transceiver2>;
>>>>> };
>>>>> +
>>>>> +&tscadc0 {
>>>>> + status = "okay";
>>>>> + adc {
>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>> + };
>>>>> +};
>>>>> +
>>>>> +&tscadc1 {
>>>>> + status = "okay";
>>>>> + adc {
>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>> + };
>>>>> +};
>>>>> \ No newline at end of file
>>>> This is a friendly reminder during the review process.
>>>>
>>>> It seems my previous comments were not fully addressed. Maybe my
>>>> feedback got lost between the quotes, maybe you just forgot to apply it.
>>>> Please go back to the previous discussion and either implement all
>>>> requested changes or keep discussing them.
>>>>
>>>> Thank you.
>>>>
>>>> Best regards,
>>>> Krzysztof
>>> Hi , I thought i did addressed the feedback since tscadc is just a
>>> wrapper node.
>>>
>>> The actual adc node is inside of tscadc node.
>> Read the feedback, from all emails.
>> Best regards,
>> Krzysztof
>
>
> Hi , i have gone through all earlier mails but can't find anything else.
> Can you point out again whats the issue.
"And this is a v2? Or resend? Or something else?"
You miss proper versioning and changelog.
Additionally - I commented just before error in your patch. You must fix
it, not ignore it, even though I did not point it out before.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes
2022-12-22 10:46 ` Krzysztof Kozlowski
@ 2022-12-22 11:53 ` Bhavya Kapoor
2022-12-22 11:58 ` Krzysztof Kozlowski
2022-12-22 12:00 ` Krzysztof Kozlowski
0 siblings, 2 replies; 12+ messages in thread
From: Bhavya Kapoor @ 2022-12-22 11:53 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-kernel, devicetree
Cc: linux-arm-kernel, krzysztof.kozlowski+dt, robh+dt, kristo, nm,
Vignesh Raghavendra
On 22/12/22 16:16, Krzysztof Kozlowski wrote:
> On 22/12/2022 11:39, Bhavya Kapoor wrote:
>> On 21/12/22 13:24, Krzysztof Kozlowski wrote:
>>> On 21/12/2022 06:42, Bhavya Kapoor wrote:
>>>> On 20/12/22 16:20, Krzysztof Kozlowski wrote:
>>>>> On 20/12/2022 11:12, Bhavya Kapoor wrote:
>>>>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>>>>>> for 8 channel ADCs for J721s2 SoC.
>>>>>>
>>>>>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>>>>>> ---
>>>>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>>>>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>>>>>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>> index a7aa6cf08acd..67593aa69327 100644
>>>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>>>>>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>>>>>> phys = <&transceiver2>;
>>>>>> };
>>>>>> +
>>>>>> +&tscadc0 {
>>>>>> + status = "okay";
>>>>>> + adc {
>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>>> + };
>>>>>> +};
>>>>>> +
>>>>>> +&tscadc1 {
>>>>>> + status = "okay";
>>>>>> + adc {
>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>>> + };
>>>>>> +};
>>>>>> \ No newline at end of file
>>>>> This is a friendly reminder during the review process.
>>>>>
>>>>> It seems my previous comments were not fully addressed. Maybe my
>>>>> feedback got lost between the quotes, maybe you just forgot to apply it.
>>>>> Please go back to the previous discussion and either implement all
>>>>> requested changes or keep discussing them.
>>>>>
>>>>> Thank you.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>> Hi , I thought i did addressed the feedback since tscadc is just a
>>>> wrapper node.
>>>>
>>>> The actual adc node is inside of tscadc node.
>>> Read the feedback, from all emails.
>>> Best regards,
>>> Krzysztof
>>
>> Hi , i have gone through all earlier mails but can't find anything else.
>> Can you point out again whats the issue.
> "And this is a v2? Or resend? Or something else?"
>
> You miss proper versioning and changelog.
>
> Additionally - I commented just before error in your patch. You must fix
> it, not ignore it, even though I did not point it out before.
>
> Best regards,
> Krzysztof
Hi, i had replied to that as well earlier. You can check that out
https://lore.kernel.org/all/89ce3639-e979-e369-657a-20aea4295970@ti.com/ .
Maybe you missed out on that.
Regards
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes
2022-12-22 11:53 ` Bhavya Kapoor
@ 2022-12-22 11:58 ` Krzysztof Kozlowski
2022-12-22 12:00 ` Krzysztof Kozlowski
1 sibling, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-22 11:58 UTC (permalink / raw)
To: Bhavya Kapoor, linux-kernel, devicetree
Cc: linux-arm-kernel, krzysztof.kozlowski+dt, robh+dt, kristo, nm,
Vignesh Raghavendra
On 22/12/2022 12:53, Bhavya Kapoor wrote:
>
> On 22/12/22 16:16, Krzysztof Kozlowski wrote:
>> On 22/12/2022 11:39, Bhavya Kapoor wrote:
>>> On 21/12/22 13:24, Krzysztof Kozlowski wrote:
>>>> On 21/12/2022 06:42, Bhavya Kapoor wrote:
>>>>> On 20/12/22 16:20, Krzysztof Kozlowski wrote:
>>>>>> On 20/12/2022 11:12, Bhavya Kapoor wrote:
>>>>>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>>>>>>> for 8 channel ADCs for J721s2 SoC.
>>>>>>>
>>>>>>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>>>>>>> ---
>>>>>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>>>>>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>>>>>>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>>>>>>
>>>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>>> index a7aa6cf08acd..67593aa69327 100644
>>>>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>>>>>>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>>>>>>> phys = <&transceiver2>;
>>>>>>> };
>>>>>>> +
>>>>>>> +&tscadc0 {
>>>>>>> + status = "okay";
>>>>>>> + adc {
>>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>>>> + };
>>>>>>> +};
>>>>>>> +
>>>>>>> +&tscadc1 {
>>>>>>> + status = "okay";
>>>>>>> + adc {
>>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>>>> + };
>>>>>>> +};
>>>>>>> \ No newline at end of file
>>>>>> This is a friendly reminder during the review process.
>>>>>>
>>>>>> It seems my previous comments were not fully addressed. Maybe my
>>>>>> feedback got lost between the quotes, maybe you just forgot to apply it.
>>>>>> Please go back to the previous discussion and either implement all
>>>>>> requested changes or keep discussing them.
>>>>>>
>>>>>> Thank you.
>>>>>>
>>>>>> Best regards,
>>>>>> Krzysztof
>>>>> Hi , I thought i did addressed the feedback since tscadc is just a
>>>>> wrapper node.
>>>>>
>>>>> The actual adc node is inside of tscadc node.
>>>> Read the feedback, from all emails.
>>>> Best regards,
>>>> Krzysztof
>>>
>>> Hi , i have gone through all earlier mails but can't find anything else.
>>> Can you point out again whats the issue.
>> "And this is a v2? Or resend? Or something else?"
>>
>> You miss proper versioning and changelog.
>>
>> Additionally - I commented just before error in your patch. You must fix
>> it, not ignore it, even though I did not point it out before.
>>
>> Best regards,
>> Krzysztof
>
> Hi, i had replied to that as well earlier. You can check that out
> https://lore.kernel.org/all/89ce3639-e979-e369-657a-20aea4295970@ti.com/ .
>
> Maybe you missed out on that.
So this is a duplicate? OK, then this patch can be:
NAK
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes
2022-12-22 11:53 ` Bhavya Kapoor
2022-12-22 11:58 ` Krzysztof Kozlowski
@ 2022-12-22 12:00 ` Krzysztof Kozlowski
1 sibling, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-22 12:00 UTC (permalink / raw)
To: Bhavya Kapoor, linux-kernel, devicetree
Cc: linux-arm-kernel, krzysztof.kozlowski+dt, robh+dt, kristo, nm,
Vignesh Raghavendra
On 22/12/2022 12:53, Bhavya Kapoor wrote:
>
> On 22/12/22 16:16, Krzysztof Kozlowski wrote:
>> On 22/12/2022 11:39, Bhavya Kapoor wrote:
>>> On 21/12/22 13:24, Krzysztof Kozlowski wrote:
>>>> On 21/12/2022 06:42, Bhavya Kapoor wrote:
>>>>> On 20/12/22 16:20, Krzysztof Kozlowski wrote:
>>>>>> On 20/12/2022 11:12, Bhavya Kapoor wrote:
>>>>>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>>>>>>> for 8 channel ADCs for J721s2 SoC.
>>>>>>>
>>>>>>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>>>>>>> ---
>>>>>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>>>>>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>>>>>>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>>>>>>
>>>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>>> index a7aa6cf08acd..67593aa69327 100644
>>>>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>>>>>>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>>>>>>> phys = <&transceiver2>;
>>>>>>> };
>>>>>>> +
>>>>>>> +&tscadc0 {
>>>>>>> + status = "okay";
>>>>>>> + adc {
>>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>>>> + };
>>>>>>> +};
>>>>>>> +
>>>>>>> +&tscadc1 {
>>>>>>> + status = "okay";
>>>>>>> + adc {
>>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>>>> + };
>>>>>>> +};
>>>>>>> \ No newline at end of file
>>>>>> This is a friendly reminder during the review process.
>>>>>>
>>>>>> It seems my previous comments were not fully addressed. Maybe my
>>>>>> feedback got lost between the quotes, maybe you just forgot to apply it.
>>>>>> Please go back to the previous discussion and either implement all
>>>>>> requested changes or keep discussing them.
>>>>>>
>>>>>> Thank you.
>>>>>>
>>>>>> Best regards,
>>>>>> Krzysztof
>>>>> Hi , I thought i did addressed the feedback since tscadc is just a
>>>>> wrapper node.
>>>>>
>>>>> The actual adc node is inside of tscadc node.
>>>> Read the feedback, from all emails.
>>>> Best regards,
>>>> Krzysztof
>>>
>>> Hi , i have gone through all earlier mails but can't find anything else.
>>> Can you point out again whats the issue.
>> "And this is a v2? Or resend? Or something else?"
>>
>> You miss proper versioning and changelog.
>>
>> Additionally - I commented just before error in your patch. You must fix
>> it, not ignore it, even though I did not point it out before.
>>
>> Best regards,
>> Krzysztof
>
> Hi, i had replied to that as well earlier. You can check that out
> https://lore.kernel.org/all/89ce3639-e979-e369-657a-20aea4295970@ti.com/ .
BTW, there is nothing there about the patch error I wrote here. If not,
please point me to the quote which addresses this patch error.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-12-22 12:10 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-08 7:32 [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes Bhavya Kapoor
2022-11-08 18:18 ` Krzysztof Kozlowski
2022-11-09 6:47 ` [EXTERNAL] " Bhavya Kapoor
2022-12-20 9:56 ` Bhavya Kapoor
-- strict thread matches above, loose matches on Subject: below --
2022-11-08 7:32 Bhavya Kapoor
2022-11-08 18:18 ` Krzysztof Kozlowski
2022-11-09 6:43 ` [EXTERNAL] " Bhavya Kapoor
2022-12-20 10:12 Bhavya Kapoor
2022-12-20 10:50 ` Krzysztof Kozlowski
2022-12-21 5:42 ` [EXTERNAL] " Bhavya Kapoor
2022-12-21 7:54 ` Krzysztof Kozlowski
2022-12-22 10:39 ` Bhavya Kapoor
2022-12-22 10:46 ` Krzysztof Kozlowski
2022-12-22 11:53 ` Bhavya Kapoor
2022-12-22 11:58 ` Krzysztof Kozlowski
2022-12-22 12:00 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).