From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A83C67871 for ; Mon, 16 Jan 2023 08:11:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231966AbjAPILj (ORCPT ); Mon, 16 Jan 2023 03:11:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232135AbjAPILh (ORCPT ); Mon, 16 Jan 2023 03:11:37 -0500 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCD2565B1 for ; Mon, 16 Jan 2023 00:11:33 -0800 (PST) Received: by mail-ej1-x631.google.com with SMTP id vw16so3018112ejc.12 for ; Mon, 16 Jan 2023 00:11:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D4ymnYKhsS5iGv9bsc4wQY9ntYFsPX+jp5KzAaLzQD4=; b=xWuVPpbqSPdKQoVpn+evZUOz92Ak0AkA2LERHD4T1TTO28wKqxKz+bFsrqX98liYZF fjdr/eMRiJVOss4qNo+G76S+TTDHjGBMM9DAuvnm/GGJXfjrJ2xlUz4kP4qXGxN53s1E xFiK8JauJxOfzcqUK9wQa7qzhLMDUhDg3XV+CdjZdxKNUmvOxI+jzq2UWgRk29a7NuPj GdTdXacEmxT4M5N/oSjUAtwyz8dEkrKFRW5gRpVnQLX9ijd6jRxMDH9pfuedkr2TGG9M yP+FmlEeTcD+UhTP+xPqLIVtLJegrmApSkNpggApjFjAVpWpcQckA+yT6lT5BlqVB4SF ta2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D4ymnYKhsS5iGv9bsc4wQY9ntYFsPX+jp5KzAaLzQD4=; b=X9g2c/Rn3BtyYP/L6L72yhxDhL7UEG4irrmXvn7iyBFrsjvPPQTqTL53vx4eGj1Bn1 zZG/JqzZbBunfFtfZA2Y2vpGmByEy0sON7AxBKCUAfoPoX09gPbYme/MQRSAUrmqtE2e kAzZhx292oc9rK7A6QwMGxGsnHQP3kxjJu0snEXj1X7CJvT7pZuRzjdusuhuoHVT3CY5 n2nQxC0YA87Dv9/Yvq1p9jsVSRgKHegOsBSoRRRxhjb+ZLkYdE90DH4Ddh7HOwsKxnEl S9J1IimOh06xU8tWC9Xy1ei9xg102/ohUg69tkk2qLinYYuDEJbDTlzrVYuDXlmYy6e/ 5YlA== X-Gm-Message-State: AFqh2kpqE9EAFFJp+Wg1RFVvjI+/yLpBHzZeN0mi3cKjBnWWO2yCKJLm TSVwWWdR1EEb/EQXthUbxLe5ZQ== X-Google-Smtp-Source: AMrXdXsBdP72AkcKF65oxwlJ7ZJRCVcEpKDcRDmYVyokU253P4At6lvgwyuEbeN/2E/ruNFGCMa3rQ== X-Received: by 2002:a17:906:b00d:b0:7c1:8ba6:6eb3 with SMTP id v13-20020a170906b00d00b007c18ba66eb3mr81757639ejy.35.1673856692269; Mon, 16 Jan 2023 00:11:32 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id v18-20020aa7cd52000000b0047eeaae9558sm3158160edw.60.2023.01.16.00.11.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 00:11:31 -0800 (PST) Message-ID: <63f3d41a-1aa3-396a-b515-bc805f4a19b4@linaro.org> Date: Mon, 16 Jan 2023 09:11:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RESEND v3 02/13] arm64: dts: mediatek: mt8195: add MDP3 nodes Content-Language: en-US To: Moudy Ho , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20230116032147.23607-1-moudy.ho@mediatek.com> <20230116032147.23607-3-moudy.ho@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20230116032147.23607-3-moudy.ho@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/01/2023 04:21, Moudy Ho wrote: > Add device nodes for Media Data Path 3 (MDP3) modules. > > Signed-off-by: Moudy Ho > --- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 420 +++++++++++++++++++++++ > 1 file changed, 420 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index 206dd534c3f6..d2d1ba71222d 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -1706,6 +1706,133 @@ > #clock-cells = <1>; > }; > > + mdp3-rdma0@14001000 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation 0 is definitely not generic Isn't this dma-controller? or if not then just rdma? > + compatible = "mediatek,mt8195-mdp3-rdma"; > + reg = <0 0x14001000 0 0x1000>; > + mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0x1000 0x1000>; > + mediatek,gce-events = , > + ; > + power-domains = <&spm MT8195_POWER_DOMAIN_VPPSYS0>, > + <&spm MT8195_POWER_DOMAIN_VPPSYS1>; > + iommus = <&iommu_vpp M4U_PORT_L4_MDP_RDMA>, > + <&iommu_vpp M4U_PORT_L4_MDP_WROT>; > + clocks = <&vppsys0 CLK_VPP0_MDP_RDMA>, > + <&topckgen CLK_TOP_CFG_VPP0>, > + <&topckgen CLK_TOP_CFG_26M_VPP0>, > + <&vppsys0 CLK_VPP0_WARP0_ASYNC_TX>, > + <&vppsys0 CLK_VPP0_WARP0_RELAY>, > + <&vppsys0 CLK_VPP0_WARP0_MDP_DL_ASYNC>, > + <&vppsys0 CLK_VPP0_WARP1_ASYNC_TX>, > + <&vppsys0 CLK_VPP0_WARP1_RELAY>, > + <&vppsys0 CLK_VPP0_WARP1_MDP_DL_ASYNC>, > + <&vppsys0 CLK_VPP0_VPP02VPP1_RELAY>, > + <&vppsys1 CLK_VPP1_DL_ASYNC>, > + <&vppsys1 CLK_VPP1_VPP0_DL_ASYNC>, > + <&vppsys1 CLK_VPP1_VPP0_DL_RELAY>, > + <&vppsys0 CLK_VPP0_VPP12VPP0_ASYNC>, > + <&vppsys1 CLK_VPP1_VPP0_DL1_RELAY>, > + <&vppsys1 CLK_VPP1_SVPP2_VDO0_DL_RELAY>, > + <&vppsys1 CLK_VPP1_SVPP3_VDO1_DL_RELAY>, > + <&vppsys1 CLK_VPP1_SVPP2_VDO1_DL_RELAY>, > + <&vppsys1 CLK_VPP1_SVPP3_VDO0_DL_RELAY>; > + mboxes = <&gce1 12 CMDQ_THR_PRIO_1>, > + <&gce1 13 CMDQ_THR_PRIO_1>, > + <&gce1 14 CMDQ_THR_PRIO_1>, > + <&gce1 21 CMDQ_THR_PRIO_1>, > + <&gce1 22 CMDQ_THR_PRIO_1>; > + }; > + > + mdp3-fg0@14002000 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation "0" suffix is definitely nothing generic. Drop such suffixes everywhere. Drop also "mdp3" prefix everywhere. Best regards, Krzysztof