Re: [PATCH 03/10] pmdomain: samsung: use to devm_kstrdup_const() to simplify error handling

["André Draszik" <andre.draszik@linaro.org>]

On Thu, 2025-10-09 at 14:31 +0100, André Draszik wrote:
> On Thu, 2025-10-09 at 09:13 +0900, Krzysztof Kozlowski wrote:
> > On 07/10/2025 01:43, André Draszik wrote:
> > > Convert to using devm_kstrdup_const() so as to simplify cleanup during
> > > error handling.
> > 
> > 
> > This is either a fix (then describe the fixed issue and add Fixed tag)
> > or you change the logic, not only simplify.
> > 
> > Previously on of_genpd_add_provider_simple() the memory was not
> > kfree_const. Now it will be.
> 
> Indeed it's a fix after all - While the driver doesn't allow unbind,

Thinking more about it - at this stage, this patch is not a fix. The driver
can not unbind, hence there is no leak to be plugged, hence no fix.

> I added this patch due to the followup patches that add potential error
> returns during probe,

since it makes the error paths in those follow-up patches simpler

>  but somehow missed an already-existing error
> return after this call.

Ignore this last part. I forgot that I simplified this error path in this
patch myself :-)

So, I'm not sure how to rephrase, tbh.


Cheers,
A