From: Jarkko Sakkinen <jarkko@kernel.org>
To: amirmizi6@gmail.com, Eyal.Cohen@nuvoton.com,
oshrialkoby85@gmail.com, alexander.steffen@infineon.com,
robh+dt@kernel.org, mark.rutland@arm.com, peterhuewe@gmx.de,
jgg@ziepe.ca, arnd@arndb.de, gregkh@linuxfoundation.org,
benoit.houyere@st.com, eajames@linux.ibm.com, joel@jms.id.au
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org, oshri.alkoby@nuvoton.com,
tmaimon77@gmail.com, gcwilson@us.ibm.com, kgoldman@us.ibm.com,
Dan.Morav@nuvoton.com, oren.tanami@nuvoton.com,
shmulik.hager@nuvoton.com, amir.mizinski@nuvoton.com
Subject: Re: [PATCH v19 2/5] tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()"
Date: Wed, 17 Nov 2021 10:03:58 +0200 [thread overview]
Message-ID: <640dd9a5bdb4c28b7429a6ab9507d645de06c125.camel@kernel.org> (raw)
In-Reply-To: <20211104140211.6258-3-amirmizi6@gmail.com>
On Thu, 2021-11-04 at 16:02 +0200, amirmizi6@gmail.com wrote:
> From: Amir Mizinski <amirmizi6@gmail.com>
>
> tpm_tis_req_canceled() function is used to check if the caller requested
> to abort the current operation. It was found that in some cases
> tpm_tis_req_canceled() wrongly returned true.
Please, bring some context, i.e. please describe the scenarios.
> Since a cancel request sets the TPM_STS.commandReady field to TRUE, the
~~~~~~~~~~~~~~
What the heck is this? Please refer the exact things.
> tpm_tis_req_canceled() function should check only the TPM_STS.commandReady
> field value.
Why?
> The case for TPM_VID_WINBOND is wrong and was therefore removed.
Why?
It is not removed in the existing mainline, so it definitely *was not*
removed.
> Also, the default comparison is wrong. Only cmdReady bit needs to be
> compared instead of the full lower status register byte.
You should split this into two patches, if it fixes two different
issues.
/Jarkko
next prev parent reply other threads:[~2021-11-17 8:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 14:02 [PATCH v19 0/5] Add tpm i2c ptp driver amirmizi6
2021-11-04 14:02 ` [PATCH v19 1/5] tpm_tis: Fix expected bit handling amirmizi6
2021-11-04 14:02 ` [PATCH v19 2/5] tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()" amirmizi6
2021-11-17 8:03 ` Jarkko Sakkinen [this message]
2021-11-04 14:02 ` [PATCH v19 3/5] tpm: tpm_tis: Verify TPM_STS register is valid after locality request amirmizi6
2021-11-17 8:10 ` Jarkko Sakkinen
2021-11-17 8:10 ` Jarkko Sakkinen
2021-11-04 14:02 ` [PATCH v19 4/5] tpm: tpm_tis: Add tpm_tis_i2c driver amirmizi6
2021-11-17 8:19 ` Jarkko Sakkinen
2022-01-14 4:12 ` Joel Stanley
2021-11-04 14:02 ` [PATCH v19 5/5] tpm: Add YAML schema for TPM TIS I2C options amirmizi6
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=640dd9a5bdb4c28b7429a6ab9507d645de06c125.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=Dan.Morav@nuvoton.com \
--cc=Eyal.Cohen@nuvoton.com \
--cc=alexander.steffen@infineon.com \
--cc=amir.mizinski@nuvoton.com \
--cc=amirmizi6@gmail.com \
--cc=arnd@arndb.de \
--cc=benoit.houyere@st.com \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=gcwilson@us.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=joel@jms.id.au \
--cc=kgoldman@us.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oren.tanami@nuvoton.com \
--cc=oshri.alkoby@nuvoton.com \
--cc=oshrialkoby85@gmail.com \
--cc=peterhuewe@gmx.de \
--cc=robh+dt@kernel.org \
--cc=shmulik.hager@nuvoton.com \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).