From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 898EEC6FD19 for ; Sun, 12 Mar 2023 17:26:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229749AbjCLR0O (ORCPT ); Sun, 12 Mar 2023 13:26:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbjCLR0N (ORCPT ); Sun, 12 Mar 2023 13:26:13 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E730360AE for ; Sun, 12 Mar 2023 10:26:12 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id d36so12885027lfv.8 for ; Sun, 12 Mar 2023 10:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678641970; h=subject:in-reply-to:cc:to:from:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=JtCwiValjsr2h1P8SRv71t+eIe5q6n+42gVTAnSj95M=; b=jwAImpv5C1Ul25lVTnv+YccK0g30OMGwguwqcVf6CLqqzAfSWsa0Pu07FbPaRb4cwu K8tT5Tlr6X8Bi+Q+PsaWXft67UzAKMLVDNE2DEPvAKA4wXjxKmItGw+ZSxpD2aHBgReK MQjl9RmrHLwxCMzQLoxDERnmrCxAMej99nMVel7Hu9of2p5DMwA9gP7fEHYwZHyNAZMK 24hQ7RkFsN5qO6+OI9Lcr5WgMcCjwl+2fP1HYtuB6SU+oqdEc+lK1towvhrYGCFcnsnc X95VNmbtZusx3dONw9rV7DbsFPFA7XzOv1RKJrxWZLfMj0FCAFquDWV410zHh8BcMgMA bCVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678641970; h=subject:in-reply-to:cc:to:from:date:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=JtCwiValjsr2h1P8SRv71t+eIe5q6n+42gVTAnSj95M=; b=0OqSjqOcyaVFfDAQnNijtvU4h5HXFfcGvG8cNIQ/+Pui9nOGxzWlaOftIxjcN1i59A oM+H7uBMCtj6/5Ko36DuuJRK3aMVGV7N6seyoVdqrsrvDmxBpiwAxvyMrV4OA6Bzh0c2 /vVyTJCE3PUepNuK7MFGgueyvq21t1c/Fh8Aesduwsaeg/61JsK96Cqxm3RJn7/CoAtH qE3znax0uYp6Pvk2M9/UhBRWpZsUzEzPG6nmfPgv6JaCv6OUcJ+wXSOt/didJSt37a14 zEp6jlISYo7oHxEatdn4Vcz43cTD8G87kGS6pxEe2meRfNGWDIzmzxYAowZXBZsxh7T+ MPvA== X-Gm-Message-State: AO0yUKVsC/ozlsJYU5q/dYqhBi0AW/Hy62Df1AJFw4h6zpZGeGsbk9vK 04aboeKxIjdkcnlqXoPYMhVeBpG7/zU3jkEa X-Google-Smtp-Source: AK7set+JvNXcL3XfDaUdqQroIZ4R6cnFtoEhtmR8ZLBPkUAuBFgoNDncAfGjx+8fNr16UWybiriK+w== X-Received: by 2002:ac2:598b:0:b0:4db:513b:6ef4 with SMTP id w11-20020ac2598b000000b004db513b6ef4mr9432336lfn.11.1678641970585; Sun, 12 Mar 2023 10:26:10 -0700 (PDT) Received: from letter7.txt (46-138-144-249.dynamic.spd-mgts.ru. [46.138.144.249]) by smtp.gmail.com with ESMTPSA id y13-20020a19750d000000b004cb1e2f8f4dsm701873lfe.152.2023.03.12.10.26.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Mar 2023 10:26:10 -0700 (PDT) Message-ID: <640e0b32.190a0220.e2264.1998@mx.google.com> Date: Sun, 12 Mar 2023 10:26:10 -0700 (PDT) From: Sergey Lisov To: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Jaehoon Chung Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: Subject: Re: [PATCH v3 1/2] dt-bindings: exynos-dw-mshc-common: add exynos78xx variants Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > Thanks for letting me know. > > https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 OK, at least its codified somewhere. Still, this results in the opposite effect: DTBs written for one SoC, using compatibles from other SoCs just because "they are the same anyway". And doing this properly, well, results in essentially duplicate compatibles. And "fallback compatibles" won't solve this case anyway, as there is no common compatible that denotes "Exynos7 DW-MMC that has the bug". >>> That's non-bisectable change (also breaking other users of DTS), so you >>> need to explain in commit msg rationale - devices were never compatible >>> and using exynos7 does not work in certain cases. Probably it makes sense to put this patch after the actual implementation, so that git bisect always gives a working setup. > BTW, this rationale was only example - you need to come with something real. Pretty much the only thing that is broken are SDIO cards, because they run very short transfers (below the DMA threshold) over the data lines. That's exactly what I stated.