* [PATCH v5 1/3] dt-bindings: exynos-dw-mshc-common: add exynos7885 variants
@ 2023-03-12 17:58 Sergey Lisov
0 siblings, 0 replies; 5+ messages in thread
From: Sergey Lisov @ 2023-03-12 17:58 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
Jaehoon Chung
Cc: linux-mmc, devicetree, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Some Samsung Exynos boards using the arm64 architecture have DW MMC
controllers configured for a 32-bit data bus but a 64-bit FIFO. On these
systems the 64-bit FIFO registers must be accessed in two 32-bit halves.
Add two new compatible strings, "samsung,exynos7885-dw-mshc" and
"samsung,exynos7885-dw-mshc-smu" respectively, to denote exynos7885
boards that need this quirk. But it's very possible that all
"samsung,exynos7-dw-mshc" boards are actually affected.
---
.../devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml
index fdaa18481..3eebaed2c 100644
--- a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml
+++ b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml
@@ -22,6 +22,8 @@ properties:
- samsung,exynos5420-dw-mshc-smu
- samsung,exynos7-dw-mshc
- samsung,exynos7-dw-mshc-smu
+ - samsung,exynos7885-dw-mshc
+ - samsung,exynos7885-dw-mshc-smu
- axis,artpec8-dw-mshc
reg:
--
2.38.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v5 1/3] dt-bindings: exynos-dw-mshc-common: add exynos7885 variants
2023-03-12 17:58 [PATCH v5 0/3] mmc: dw_mmc: fix DW MMC cores with 32-bit bus on 64-bit Linux systems Sergey Lisov
@ 2023-03-12 17:58 ` Sergey Lisov
2023-03-12 18:11 ` Krzysztof Kozlowski
2023-03-14 19:49 ` Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Sergey Lisov @ 2023-03-12 17:58 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
Jaehoon Chung
Cc: linux-mmc, devicetree, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Some Samsung Exynos boards using the arm64 architecture have DW MMC
controllers configured for a 32-bit data bus but a 64-bit FIFO. On these
systems the 64-bit FIFO registers must be accessed in two 32-bit halves.
Add two new compatible strings, "samsung,exynos7885-dw-mshc" and
"samsung,exynos7885-dw-mshc-smu" respectively, to denote exynos7885
boards that need this quirk. But it's very possible that all
"samsung,exynos7-dw-mshc" boards are actually affected.
---
.../devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml
index fdaa18481..3eebaed2c 100644
--- a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml
+++ b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml
@@ -22,6 +22,8 @@ properties:
- samsung,exynos5420-dw-mshc-smu
- samsung,exynos7-dw-mshc
- samsung,exynos7-dw-mshc-smu
+ - samsung,exynos7885-dw-mshc
+ - samsung,exynos7885-dw-mshc-smu
- axis,artpec8-dw-mshc
reg:
--
2.38.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v5 1/3] dt-bindings: exynos-dw-mshc-common: add exynos7885 variants
2023-03-12 17:58 ` [PATCH v5 1/3] dt-bindings: exynos-dw-mshc-common: add exynos7885 variants Sergey Lisov
@ 2023-03-12 18:11 ` Krzysztof Kozlowski
2023-03-14 19:49 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-12 18:11 UTC (permalink / raw)
To: Sergey Lisov, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Alim Akhtar, Jaehoon Chung
Cc: linux-mmc, devicetree, linux-arm-kernel, linux-samsung-soc,
linux-kernel
On 12/03/2023 18:58, Sergey Lisov wrote:
> Some Samsung Exynos boards using the arm64 architecture have DW MMC
> controllers configured for a 32-bit data bus but a 64-bit FIFO. On these
> systems the 64-bit FIFO registers must be accessed in two 32-bit halves.
>
> Add two new compatible strings, "samsung,exynos7885-dw-mshc" and
> "samsung,exynos7885-dw-mshc-smu" respectively, to denote exynos7885
> boards that need this quirk. But it's very possible that all
> "samsung,exynos7-dw-mshc" boards are actually affected.
And now this is third copy of the same email. This is not acceptable.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v5 1/3] dt-bindings: exynos-dw-mshc-common: add exynos7885 variants
2023-03-12 17:58 ` [PATCH v5 1/3] dt-bindings: exynos-dw-mshc-common: add exynos7885 variants Sergey Lisov
2023-03-12 18:11 ` Krzysztof Kozlowski
@ 2023-03-14 19:49 ` Krzysztof Kozlowski
2023-03-15 18:57 ` Sergey Lisov
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-14 19:49 UTC (permalink / raw)
To: Sergey Lisov, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Alim Akhtar, Jaehoon Chung
Cc: linux-mmc, devicetree, linux-arm-kernel, linux-samsung-soc,
linux-kernel
On 12/03/2023 18:58, Sergey Lisov wrote:
> Some Samsung Exynos boards using the arm64 architecture have DW MMC
> controllers configured for a 32-bit data bus but a 64-bit FIFO. On these
> systems the 64-bit FIFO registers must be accessed in two 32-bit halves.
>
> Add two new compatible strings, "samsung,exynos7885-dw-mshc" and
> "samsung,exynos7885-dw-mshc-smu" respectively, to denote exynos7885
> boards that need this quirk. But it's very possible that all
> "samsung,exynos7-dw-mshc" boards are actually affected.
> ---
> .../devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml
> index fdaa18481..3eebaed2c 100644
> --- a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml
> @@ -22,6 +22,8 @@ properties:
> - samsung,exynos5420-dw-mshc-smu
> - samsung,exynos7-dw-mshc
> - samsung,exynos7-dw-mshc-smu
> + - samsung,exynos7885-dw-mshc
> + - samsung,exynos7885-dw-mshc-smu
What about the if-then at the end? Since this is pretty compatible with
exynos7, then I would expect being added also there.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v5 1/3] dt-bindings: exynos-dw-mshc-common: add exynos7885 variants
2023-03-14 19:49 ` Krzysztof Kozlowski
@ 2023-03-15 18:57 ` Sergey Lisov
0 siblings, 0 replies; 5+ messages in thread
From: Sergey Lisov @ 2023-03-15 18:57 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
Jaehoon Chung
Cc: linux-mmc, devicetree, linux-arm-kernel, linux-samsung-soc,
linux-kernel
>> + - samsung,exynos7885-dw-mshc
>> + - samsung,exynos7885-dw-mshc-smu
>
> What about the if-then at the end? Since this is pretty compatible with
> exynos7, then I would expect being added also there.
Makes sense. Also it probably makes sense to add "samsung,exynos7-dw-mshc"
as a fallback compatible to the jackpotlte.dts, because it probably
somewhat worked for whoever contributed that.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-15 18:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-12 17:58 [PATCH v5 1/3] dt-bindings: exynos-dw-mshc-common: add exynos7885 variants Sergey Lisov
-- strict thread matches above, loose matches on Subject: below --
2023-03-12 17:58 [PATCH v5 0/3] mmc: dw_mmc: fix DW MMC cores with 32-bit bus on 64-bit Linux systems Sergey Lisov
2023-03-12 17:58 ` [PATCH v5 1/3] dt-bindings: exynos-dw-mshc-common: add exynos7885 variants Sergey Lisov
2023-03-12 18:11 ` Krzysztof Kozlowski
2023-03-14 19:49 ` Krzysztof Kozlowski
2023-03-15 18:57 ` Sergey Lisov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).