From: Suman Anna <s-anna@ti.com>
To: Rob Herring <robh@kernel.org>, Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: <linux-remoteproc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, "Nagalla, Hari" <hnagalla@ti.com>
Subject: Re: [PATCH] dt-bindings: remoteproc: ti: Fix the number of mailboxes
Date: Fri, 7 Jan 2022 08:13:54 -0600 [thread overview]
Message-ID: <642312db-4af8-7087-45bf-e86923396038@ti.com> (raw)
In-Reply-To: <20220107030457.2383750-1-robh@kernel.org>
Hi Rob,
On 1/6/22 9:04 PM, Rob Herring wrote:
> Based on the example, the TI K3 DSP and R5 have 2 mailboxes, but the schema
> says 1. Fix the schema.
No, 1 is correct. The OMAP Mailbox binding uses #mbox-cells as 1 and not 0, and
uses a phandle as the cell-value.
regards
Suman
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 2 +-
> .../devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> index 5ec6505ac408..648144fa1582 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> @@ -53,7 +53,7 @@ properties:
> OMAP Mailbox specifier denoting the sub-mailbox, to be used for
> communication with the remote processor. This property should match
> with the sub-mailbox node used in the firmware image.
> - maxItems: 1
> + maxItems: 2
>
> memory-region:
> minItems: 2
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> index eeef255c4045..2c5f91ea5296 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> @@ -135,7 +135,7 @@ patternProperties:
> OMAP Mailbox specifier denoting the sub-mailbox, to be used for
> communication with the remote processor. This property should match
> with the sub-mailbox node used in the firmware image.
> - maxItems: 1
> + maxItems: 2
>
> memory-region:
> description: |
>
next prev parent reply other threads:[~2022-01-07 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 3:04 [PATCH] dt-bindings: remoteproc: ti: Fix the number of mailboxes Rob Herring
2022-01-07 14:13 ` Suman Anna [this message]
2022-01-07 14:17 ` Suman Anna
2022-01-07 17:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=642312db-4af8-7087-45bf-e86923396038@ti.com \
--to=s-anna@ti.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).