From: Krzysztof Kozlowski <krzk@kernel.org>
To: Erik Beck <xunil@tahomasoft.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] arm64: dts: rockchip: add LinkStar-H68k-1432v1
Date: Mon, 28 Jul 2025 07:08:41 +0200 [thread overview]
Message-ID: <642df1ee-5e92-4f0a-bcdf-7e10dbc0d59b@kernel.org> (raw)
In-Reply-To: <20250727-linkstarpatch_v4_6-16-rc1-v4-2-0dfa7aa06ec9@tahomasoft.com>
On 28/07/2025 02:03, Erik Beck wrote:
> Add DTS.
>
> This device:
> - Has not been supported previously in the mainline Linux kernel;
> - Is a single board travel router made by Seeed, using an rk3568;
> - Has four ethernet ports;
> - Has four USB ports;
> - Has WiFi (MediaTek MT7921e);
> - Has a real-time clock (rk809)
>
> Base commit:
> - Commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 (tag: v6.16-rc1);
Drop entire commit msg, you are duplicating the binding. Instead:
Add DTS for foo bar board, a travel router using Rockchip baz foo SoC.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-07-28 5:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 0:03 [PATCH v4 0/2] Add Support for LinkStar H68K board: ARM64 and RK3568: dts and dt-bindings Erik Beck
2025-07-28 0:03 ` [PATCH v4 1/2] dt-bindings: arm: rockchip: add LinkStar-H68k-1432v1 Erik Beck
2025-07-28 5:07 ` Krzysztof Kozlowski
2025-07-28 5:11 ` Krzysztof Kozlowski
2025-07-28 0:03 ` [PATCH v4 2/2] arm64: dts: " Erik Beck
2025-07-28 5:08 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=642df1ee-5e92-4f0a-bcdf-7e10dbc0d59b@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=xunil@tahomasoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).