devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arun Kumar K <arun.kk@samsung.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: "linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Kamil Debski <k.debski@samsung.com>,
	Jeongtae Park <jtp.park@samsung.com>,
	"thomas.abraham@linaro.org" <thomas.abraham@linaro.org>,
	Karol Lewandowski <k.lewandowsk@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	NAVEEN KRISHNA CHATRADHI <ch.naveen@samsung.com>,
	SUNIL JOSHI <joshi@samsung.com>
Subject: Re: [PATCH v4] ARM: EXYNOS: Add MFC device tree support
Date: Wed, 26 Sep 2012 12:57:42 +0000 (GMT)	[thread overview]
Message-ID: <6434789.294181348664261514.JavaMail.weblogic@epml02> (raw)

Hi Tomasz,

> Maybe the base address and size could be merged into one property with two
> values, as it is done with the reg property? What do you think?
>
>> +     codec@11000000 {
>> +             samsung,mfc-r = <0x43000000>;
>> +             samsung,mfc-r-size = <8388608>;
>> +             samsung,mfc-l = <0x51000000>;
>> +             samsung,mfc-l-size = <8388608>;
>
> It would look like this:
>
>                 samsung-mfc-r = <0x43000000 0x800000>;
>                 samsung-mfc-l = <0x51000000 0x800000>;
>

Thanks for the suggestion. It sure looks better this way.
I will include this change and post updated patch.

Regards
Arun

             reply	other threads:[~2012-09-26 12:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26 12:57 Arun Kumar K [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-09-26 11:00 [PATCH v4] ARM: EXYNOS: Add MFC device tree support Arun Kumar K
2012-09-22 18:07 [PATCH v4] " Arun Kumar K
2012-09-22 18:07 ` [PATCH v4] ARM: EXYNOS: " Arun Kumar K
2012-09-24  8:22   ` Karol Lewandowski
2012-09-26  2:12     ` Kukjin Kim
2012-09-26  6:54   ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6434789.294181348664261514.JavaMail.weblogic@epml02 \
    --to=arun.kk@samsung.com \
    --cc=ch.naveen@samsung.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=joshi@samsung.com \
    --cc=jtp.park@samsung.com \
    --cc=k.debski@samsung.com \
    --cc=k.lewandowsk@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=thomas.abraham@linaro.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).