From: Arnd Bergmann <arnd@arndb.de>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: davem@davemloft.net, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, f.fainelli@gmail.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH RFC 2/2] net: qualcomm: new Ethernet over SPI driver for QCA7000
Date: Wed, 30 Apr 2014 11:32:05 +0200 [thread overview]
Message-ID: <6454465.sI3RdtNGTO@wuerfel> (raw)
In-Reply-To: <5360AFC7.6020107@i2se.com>
On Wednesday 30 April 2014 10:09:43 Stefan Wahren wrote:
> >
> > You print a 'netdev_warn' message here when the queue is full, expecting
> > this to be rare. If the device is so slow, why doesn't this happen
> > all the time?
> >
> Until now, i never experienced that the queue runs full. But i will do
> some tests to reproduce this.
You could try making the queue shorter to see if you get into this case.
However, when using netdev_sent_queue(), it might become harder to trigger,
so better try this first.
Arnd
next prev parent reply other threads:[~2014-04-30 9:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 17:54 [PATCH RFC 0/2] add Qualcomm QCA7000 ethernet driver Stefan Wahren
2014-04-28 17:54 ` [PATCH RFC 1/2] Documentation: add Device tree bindings for QCA7000 Stefan Wahren
2014-04-28 19:57 ` Arnd Bergmann
2014-04-29 6:30 ` Stefan Wahren
2014-04-29 7:57 ` Arnd Bergmann
2014-04-29 22:36 ` Mark Rutland
2014-04-30 7:30 ` Stefan Wahren
2014-04-28 17:54 ` [PATCH RFC 2/2] net: qualcomm: new Ethernet over SPI driver " Stefan Wahren
2014-04-28 20:09 ` Arnd Bergmann
2014-04-29 6:51 ` Stefan Wahren
2014-04-29 8:14 ` Arnd Bergmann
2014-04-29 15:54 ` Stefan Wahren
2014-04-29 18:14 ` Arnd Bergmann
2014-04-30 8:09 ` Stefan Wahren
2014-04-30 9:32 ` Arnd Bergmann [this message]
2014-04-30 15:36 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6454465.sI3RdtNGTO@wuerfel \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).