From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v3 6/6] watchdog: ts4600: add driver for TS-4600 watchdog Date: Sun, 14 May 2017 19:30:38 -0700 Message-ID: <647826a6-7b85-997f-d283-35458a789ccc@roeck-us.net> References: <20170505193259.16517-1-sebastien.bourdelin@savoirfairelinux.com> <20170505193259.16517-7-sebastien.bourdelin@savoirfairelinux.com> <20170511072231.GD5833@dragon> <20170515020001.GI8471@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170515020001.GI8471@dragon> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shawn Guo Cc: Sebastien Bourdelin , robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mark-L1vi/lXTdtvnC/t2CciAbw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kris-L1vi/lXTdtvnC/t2CciAbw@public.gmane.org, kernel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org, fabio.estevam-3arQi8VN3Tc@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 05/14/2017 07:00 PM, Shawn Guo wrote: > On Sun, May 14, 2017 at 07:39:33AM -0700, Guenter Roeck wrote: >> On 05/11/2017 12:22 AM, Shawn Guo wrote: >>> On Fri, May 05, 2017 at 03:32:59PM -0400, Sebastien Bourdelin wrote: >>>> This watchdog is instantiated in a FPGA and can only be access using a >>>> GPIOs bit-banged bus, called the NBUS by Technologic Systems. >>>> The watchdog is made of only one register, called the feed register. >>>> Writing to this register will re-arm the watchdog for a given time (and >>>> enable it if it was disable). It can be disabled by writing a special >>>> value into it. >>>> >>>> Signed-off-by: Sebastien Bourdelin >>>> --- >>>> Changes v2 -> v3: >>>> - rebase on master >>>> - remove the timeout table to simplify the logic (suggested by >>>> Guenter Roeck) >>>> - fix the set_timeout function (suggested by Guenter Roeck) >>>> - hardcode the max_hw_heartbeat_ms value based on the ts4600 max >>>> timeout value supported (suggested by Guenter Roeck) >>>> - remove the max_timeout usage and set a default timeout value >>>> (suggested by Guenter Roeck) >>>> - use the devm_watchdog_register_device function instead of >>>> watchdog_register_device (suggested by Guenter Roeck) >>>> >>>> Changes v1 -> v2: >>>> - rebase on master >>>> - retrieve the ts_nbus instantiated by the parent node (suggested by >>>> Linus Walleij) >>>> - rename the wdt by watchdog in the device tree and in the >>>> documentation (suggested by Rob Herring) >>>> - add a dependency to the TS_NBUS driver in the Kconfig (suggested by >>>> Guenter Roeck) >>>> - simplify the set_timeout function (suggested by Guenter Roeck) >>>> - use the max_hw_heartbeat_ms callback instead of the max_timeout >>>> callback (suggested by Guenter Roeck) >>>> --- >>>> .../devicetree/bindings/watchdog/ts4600-wdt.txt | 16 ++ >>>> arch/arm/boot/dts/imx28-ts4600-common.dtsi | 5 + >>> >>> The dts change shouldn't be mixed within driver patch. >>> >> >> Maybe, but Rob Acked the devicetree changes, so I don't see a reason >> for splitting it up now. > > What Rob Acked is devicetree bindings, and ARM dts changes should > normally go via arm-soc tree, unless there is a good reason they > shouldn't. > Ok, good point. Guenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html