From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D33BA3164DB for ; Fri, 14 Nov 2025 11:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763121338; cv=none; b=N/nJyJO59XO6Kje5tX/BLO1A0+yu9j8mturXGhuz/pPpfuxsWU9Mu/i+TTRCj/N9Gu+YYaTwrbPAWwb7HPiE2IARkhoQfEKFvOjOudXnT+GVjW31s1KtEMHZp/8qv/ldSZ8Tsfj8HeBqVDGvSmwh7hRjoLN3UyivYgVa7vbIkaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763121338; c=relaxed/simple; bh=kSsVcz8630KwHo4IO7LJsqMTZrFWGAD+oaRzx2FLL3w=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=LNJdXup1uYznYg2jc65ifcFOOknybduIBPwtGf+BRWWZnU2CWznI9MoHPahnUJwp/ZlxV3srolZZjwgVt5NOSK1eskYcgoyKGwMcIo3vLCWRmP4GZJ+7JsKaRM5VHZHhMKtgKTd5lqi2r5UqFwgkzLzRCYLcHz4xvPwx6B9XaDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SLawjDEm; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SLawjDEm" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-477770019e4so22403015e9.3 for ; Fri, 14 Nov 2025 03:55:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763121335; x=1763726135; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=kSsVcz8630KwHo4IO7LJsqMTZrFWGAD+oaRzx2FLL3w=; b=SLawjDEmIkye7FklV/K0NRjVRjISwZlLXhh7NLhMp5I8d6eIDNFW3ENbEsrnKlOEbK wP0JiezJ6FXzc0YP0NiJOoRTpo2jTNUHgpttC37nd6OidVHmg+Z64cRg9Honr90y+7fD vY4U5+gOET7UBDi2+6m0nE3IHVqTC+n8b2MjOoukKLSqOQdSZcbd7UFfL1zB8pbmmyxV nzCfQmH8JdYSC1KDcjNxE6slEewY9NdKw+gPg7Qt9glB4DcEfcCKGThdsdB/7uqtGY+c Icm6rA+EMa6fppbBYI178ND65UVjuOU36LmpQdA7TaLx/mqrvylgW2CLEK+1YSXtpTqF //2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763121335; x=1763726135; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kSsVcz8630KwHo4IO7LJsqMTZrFWGAD+oaRzx2FLL3w=; b=K/wtmv+0PSr1GW3RUY8AzWj3iXKZWOzO/5V6zF0vucjB3S+VoNrR6ueO5uQQsEaRkm UYfq2xmRCJ0vo50yJtvrFd0TAISOi6v5oDHKIgLr8A19FJYSVBP8aHNuCKm0bGfM9L7d rPcZlHV09+AP16yx2XkYMP4h7cqUvxmPD8b6v9+EZqOlhDP5lJg2A7VX1G33lviXYmDI 531f8qDqDMpI+6460qywP1piwPEaZe0onhCBnqfASB6D/rtH3EgmvQZf33HGTmtVQE42 MwxPOIOx9p3Elx4xnFNb0gTnrR0zJ6rjcwTRht+BMjBSkcAIY6ItE3HTW8jkJTr081so LVsQ== X-Forwarded-Encrypted: i=1; AJvYcCVMmUsOHWGZX0fwC10Kv4q2Sktp8Qwkq39x5I5Eeqv20dAXzVOcrELkldNBNfXDvSI+0zjAEK1r9eQY@vger.kernel.org X-Gm-Message-State: AOJu0YxtQ0TzWgDIdu/+MUxhNoLxcMXif545ebd1C+4Dk4m0XqozDpi2 NdQ7fUTLlic+ku2aYRypkXFfConYJPqy4UsM5gF7GQ/Zax/USHGdUmmi/Ozymx7Oo84= X-Gm-Gg: ASbGncv2LZ4x2B/qf9hgj3ijIngPkpnVEdKv3RaXVx1yxZ0/p3H+Wuxyszqpw0oVD8i NNoK1Bs8sB0NjBXAkHJnqJfBPHr9F8TYPSRS9swRQwe39eKLUvatzGw+9QM+J+/OohMr7yJ0X35 Bn1x3vYvM6dNd7hPdEWIjrzRkc6juoZY56ZcR/61xFzazITpHt9kApDmr1ixPHnN7qTFL7+F1fa /USh1JJC/kG4SJGSUIg7uuC7BHLKwz6oQgZcy3Y3cXbvG0k45Es81ColDA4M4+i1Nse3PxrW5Ta b68oGoBMyOqHzf/wNG8PoQr+Id78vOdJGz+tX0ckLTADwS+u4vOsKPJ6Xs4MgJnRgHpaJXfaGCW ph5b2Hk2bu7pSoBRdQmvxFy09NntInmxaiG08f/hza8it3nt7k65FdEPvdBu6sG1ReYhg9E6gGy P5C+i/zg== X-Google-Smtp-Source: AGHT+IGaX63VyG7288bvhFhh9mADvgY7EJnU+zr1vNcvBNVERTkgMmla9vn+invb7igtQmyDtjSXdw== X-Received: by 2002:a05:600c:1c16:b0:476:4efc:8ed4 with SMTP id 5b1f17b1804b1-4778fe49c3bmr26839345e9.11.1763121335290; Fri, 14 Nov 2025 03:55:35 -0800 (PST) Received: from draszik.lan ([212.129.74.29]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e85e6fsm9688761f8f.18.2025.11.14.03.55.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 03:55:34 -0800 (PST) Message-ID: <6479a8d84052b326ffeb5609959aaf3a1aac9ff8.camel@linaro.org> Subject: Re: [PATCH 06/13] mfd: sec-irq: add support for creating multiple IRQ chips From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Alexandre Belloni , Kaustabh Chakraborty Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , Jonathan Corbet , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org Date: Fri, 14 Nov 2025 11:55:34 +0000 In-Reply-To: <20251114075004a444bff0@mail.local> References: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> <20251114-s2mu005-pmic-v1-6-9e3184d3a0c9@disroot.org> <20251114075004a444bff0@mail.local> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-2+build3 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2025-11-14 at 08:50 +0100, Alexandre Belloni wrote: > On 14/11/2025 00:35:07+0530, Kaustabh Chakraborty wrote: > > The current state of the driver only allows creating only one IRQ chip > > per PMIC. On some PMICs, such as Samsung's S2MU005, there are multiple > > interrupt blocks, for which the current implementation stands insuffici= ent. > >=20 > > Add support for creating multiple IRQ chips for a PMIC. Every IRQ chip = is > > given it's own index, which is used by sub-device drivers to request IR= Qs. > >=20 > > A macro is defined which states the maximum number of chips supported. > > It's set to 1 as currently, no PMIC requires more than one IRQ chip. Th= e > > value must be changed accordingly on adding new PMICs requiring multipl= e > > IRQ chips. > >=20 > > Moreover, adjust the s5m RTC driver to initialize IRQs with the > > appropriate IRQ chip index. > >=20 > > Signed-off-by: Kaustabh Chakraborty > Acked-by: Alexandre Belloni >=20 > > --- > > =C2=A0drivers/mfd/sec-irq.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 | 163 +++++++++++++++++++++++---------------- > > =C2=A0drivers/rtc/rtc-s5m.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 15 +++- > > =C2=A0include/linux/mfd/samsung/core.h |=C2=A0=C2=A0 5 +- > > =C2=A0include/linux/mfd/samsung/irq.h=C2=A0 |=C2=A0 14 ++++ > > =C2=A04 files changed, 127 insertions(+), 70 deletions(-) Your patch reminded me to finally send https://lore.kernel.org/all/20251114-s5m-alarm-v1-0-c9b3bebae65f@linaro.org= / If applied first, you wouldn't need to touch rtc-s5m.c I believe. Equally, I can rebase mine on top of yours - no strong feelings. Cheers, Andre'