* [PATCH] ASoC: dt-bindings: realtek,rt5659: Convert to dtschema
@ 2024-06-22 15:37 Animesh Agarwal
2024-06-23 7:10 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Animesh Agarwal @ 2024-06-22 15:37 UTC (permalink / raw)
Cc: animeshagarwal28, Daniel Baluta, Liam Girdwood, Mark Brown,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-sound,
devicetree, linux-kernel
Convert the RT5659/RT5658 audio CODEC bindings to DT schema.
Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>
---
.../bindings/sound/realtek,rt5659.yaml | 132 ++++++++++++++++++
.../devicetree/bindings/sound/rt5659.txt | 89 ------------
2 files changed, 132 insertions(+), 89 deletions(-)
create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5659.yaml
delete mode 100644 Documentation/devicetree/bindings/sound/rt5659.txt
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5659.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5659.yaml
new file mode 100644
index 000000000000..da6966c65c02
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5659.yaml
@@ -0,0 +1,132 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/realtek,rt5659.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: RT5659/RT5658 audio CODEC
+
+maintainers:
+ - Animesh Agarwal <animeshagarwal28@gmail.com>
+
+description: |
+ This device supports I2C only.
+
+ Pins on the device (for linking into audio routes) for RT5659/RT5658:
+ * DMIC L1
+ * DMIC R1
+ * DMIC L2
+ * DMIC R2
+ * IN1P
+ * IN1N
+ * IN2P
+ * IN2N
+ * IN3P
+ * IN3N
+ * IN4P
+ * IN4N
+ * HPOL
+ * HPOR
+ * SPOL
+ * SPOR
+ * LOUTL
+ * LOUTR
+ * MONOOUT
+ * PDML
+ * PDMR
+ * SPDIF
+
+allOf:
+ - $ref: dai-common.yaml#
+
+properties:
+ compatible:
+ enum:
+ - realtek,rt5659
+ - realtek,rt5658
+
+ reg:
+ maxItems: 1
+ description: The I2C address of the device.
+
+ interrupts:
+ maxItems: 1
+ description: The CODEC's interrupt output.
+
+ clocks:
+ maxItems: 1
+ description: phandle and clock specifier for codec MCLK.
+
+ clock-names:
+ const: mclk
+
+ realtek,dmic1-data-pin:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum:
+ - 0 # dmic1 is not used
+ - 1 # using IN2N pin as dmic1 data pin
+ - 2 # using GPIO5 pin as dmic1 data pin
+ - 3 # using GPIO9 pin as dmic1 data pin
+ - 4 # using GPIO11 pin as dmic1 data pin
+ description: Specify which pin to be used as DMIC1 data pin.
+
+ realtek,dmic2-data-pin:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum:
+ - 0 # dmic1 is not used
+ - 1 # using IN2P pin as dmic1 data pin
+ - 2 # using GPIO6 pin as dmic1 data pin
+ - 3 # using GPIO10 pin as dmic1 data pin
+ - 4 # using GPIO12 pin as dmic1 data pin
+ description: Specify which pin to be used as DMIC2 data pin.
+
+ realtek,jd-src:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum:
+ - 0 # No JD is used
+ - 1 # using JD3 as JD source
+ - 2 # JD source for Intel HDA header
+ description: Specify which JD source be used.
+
+ realtek,ldo1-en-gpios:
+ maxItems: 1
+ description: The GPIO that controls the CODEC's LDO1_EN pin.
+
+ realtek,reset-gpios:
+ maxItems: 1
+ description: The GPIO that controls the CODEC's RESET pin.
+
+ sound-name-prefix: true
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ port:
+ $ref: audio-graph-port.yaml#
+ unevaluatedProperties: false
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ codec@1b {
+ compatible = "realtek,rt5659";
+ reg = <0x1b>;
+ interrupt-parent = <&gpio>;
+ interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
+ realtek,ldo1-en-gpios =
+ <&gpio 3 GPIO_ACTIVE_HIGH>;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/sound/rt5659.txt b/Documentation/devicetree/bindings/sound/rt5659.txt
deleted file mode 100644
index 8f3f62c0226a..000000000000
--- a/Documentation/devicetree/bindings/sound/rt5659.txt
+++ /dev/null
@@ -1,89 +0,0 @@
-RT5659/RT5658 audio CODEC
-
-This device supports I2C only.
-
-Required properties:
-
-- compatible : One of "realtek,rt5659" or "realtek,rt5658".
-
-- reg : The I2C address of the device.
-
-- interrupts : The CODEC's interrupt output.
-
-Optional properties:
-
-- clocks: The phandle of the master clock to the CODEC
-- clock-names: Should be "mclk"
-
-- realtek,in1-differential
-- realtek,in3-differential
-- realtek,in4-differential
- Boolean. Indicate MIC1/3/4 input are differential, rather than single-ended.
-
-- realtek,dmic1-data-pin
- 0: dmic1 is not used
- 1: using IN2N pin as dmic1 data pin
- 2: using GPIO5 pin as dmic1 data pin
- 3: using GPIO9 pin as dmic1 data pin
- 4: using GPIO11 pin as dmic1 data pin
-
-- realtek,dmic2-data-pin
- 0: dmic2 is not used
- 1: using IN2P pin as dmic2 data pin
- 2: using GPIO6 pin as dmic2 data pin
- 3: using GPIO10 pin as dmic2 data pin
- 4: using GPIO12 pin as dmic2 data pin
-
-- realtek,jd-src
- 0: No JD is used
- 1: using JD3 as JD source
- 2: JD source for Intel HDA header
-
-- realtek,ldo1-en-gpios : The GPIO that controls the CODEC's LDO1_EN pin.
-- realtek,reset-gpios : The GPIO that controls the CODEC's RESET pin.
-
-- sound-name-prefix: Please refer to dai-common.yaml
-
-- ports: A Codec may have a single or multiple I2S interfaces. These
- interfaces on Codec side can be described under 'ports' or 'port'.
- When the SoC or host device is connected to multiple interfaces of
- the Codec, the connectivity can be described using 'ports' property.
- If a single interface is used, then 'port' can be used. The usage
- depends on the platform or board design.
- Please refer to Documentation/devicetree/bindings/graph.txt
-
-Pins on the device (for linking into audio routes) for RT5659/RT5658:
-
- * DMIC L1
- * DMIC R1
- * DMIC L2
- * DMIC R2
- * IN1P
- * IN1N
- * IN2P
- * IN2N
- * IN3P
- * IN3N
- * IN4P
- * IN4N
- * HPOL
- * HPOR
- * SPOL
- * SPOR
- * LOUTL
- * LOUTR
- * MONOOUT
- * PDML
- * PDMR
- * SPDIF
-
-Example:
-
-rt5659 {
- compatible = "realtek,rt5659";
- reg = <0x1b>;
- interrupt-parent = <&gpio>;
- interrupts = <TEGRA_GPIO(W, 3) IRQ_TYPE_LEVEL_HIGH>;
- realtek,ldo1-en-gpios =
- <&gpio TEGRA_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
-};
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: dt-bindings: realtek,rt5659: Convert to dtschema
2024-06-22 15:37 [PATCH] ASoC: dt-bindings: realtek,rt5659: Convert to dtschema Animesh Agarwal
@ 2024-06-23 7:10 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-23 7:10 UTC (permalink / raw)
To: Animesh Agarwal
Cc: Daniel Baluta, Liam Girdwood, Mark Brown, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-sound, devicetree,
linux-kernel
On 22/06/2024 17:37, Animesh Agarwal wrote:
> Convert the RT5659/RT5658 audio CODEC bindings to DT schema.
>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - realtek,rt5659
> + - realtek,rt5658
> +
> + reg:
> + maxItems: 1
> + description: The I2C address of the device.
Drop description, redundant.
> +
> + interrupts:
> + maxItems: 1
> + description: The CODEC's interrupt output.
Drop description, redundant.
> +
> + clocks:
> + maxItems: 1
> + description: phandle and clock specifier for codec MCLK.
Drop description, redundant.
> +
> + clock-names:
> + const: mclk
> +
> + realtek,dmic1-data-pin:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # dmic1 is not used
> + - 1 # using IN2N pin as dmic1 data pin
> + - 2 # using GPIO5 pin as dmic1 data pin
> + - 3 # using GPIO9 pin as dmic1 data pin
> + - 4 # using GPIO11 pin as dmic1 data pin
> + description: Specify which pin to be used as DMIC1 data pin.
> +
> + realtek,dmic2-data-pin:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # dmic1 is not used
> + - 1 # using IN2P pin as dmic1 data pin
> + - 2 # using GPIO6 pin as dmic1 data pin
> + - 3 # using GPIO10 pin as dmic1 data pin
> + - 4 # using GPIO12 pin as dmic1 data pin
> + description: Specify which pin to be used as DMIC2 data pin.
default:
> +
> + realtek,jd-src:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # No JD is used
> + - 1 # using JD3 as JD source
> + - 2 # JD source for Intel HDA header
> + description: Specify which JD source be used.
default:
> +
> + realtek,ldo1-en-gpios:
> + maxItems: 1
> + description: The GPIO that controls the CODEC's LDO1_EN pin.
It's enough:
CODEC's LDO1_EN pin
> +
> + realtek,reset-gpios:
> + maxItems: 1
> + description: The GPIO that controls the CODEC's RESET pin.
> +
> + sound-name-prefix: true
Drop
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + port:
> + $ref: audio-graph-port.yaml#
> + unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + codec@1b {
> + compatible = "realtek,rt5659";
> + reg = <0x1b>;
> + interrupt-parent = <&gpio>;
> + interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
> + realtek,ldo1-en-gpios =
> + <&gpio 3 GPIO_ACTIVE_HIGH>;
This can be one line.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-23 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-22 15:37 [PATCH] ASoC: dt-bindings: realtek,rt5659: Convert to dtschema Animesh Agarwal
2024-06-23 7:10 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).