From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F22F527453; Sun, 23 Jun 2024 07:10:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719126645; cv=none; b=ASNMaDsN+Hq+1jrztPXmb7uVu+QvsfX1nm74ZiTccE/uLls4WafF09TpbUBG2n8UJA/Yjx+yV6WXkozJj5pq8Ot8quFaZVIU1qMWXUBJ/NjanJVR+gGwHzc0SRDVt2JddIRCOzhgpsHVJQE5FRxaFOoIZFRRNwur73y588RHiuk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719126645; c=relaxed/simple; bh=FtNfR56Pj5/tidnoeH44U3Y6/IK9Voc/EmcuJYq/Wqw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LkGHeYSYOqXvyl3dFw2BK2cp7DrI/MFxJ32wTmkotQXmq1te17XUQuoCBXg1b6hGfy/TuvNVdy3KtPv+PNBzy+LMPMSGDtn8Z5kGY0jqQHCe0K1r3j0p3+LscEMOoTfsI2O9M01dX/4MxFqqolq7j45AeXCC0pNDYghohckyhDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MHAUN/o9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MHAUN/o9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2374C2BD10; Sun, 23 Jun 2024 07:10:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719126644; bh=FtNfR56Pj5/tidnoeH44U3Y6/IK9Voc/EmcuJYq/Wqw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MHAUN/o91AHZW8P7vB3L+C/Hp1SONJqV3yVPwrFsSCWS2VduF1SwJ6VPURLh6b9/K YeVmMenYWXkdFw70vCRzZqusmh+cgZqXEQBNVmaUHwt4pOE1wrNy0Uy4Etog4Y87+5 gazxEiKiyXbS51O5i3TYanM2VnZeM7PKqAZrfNyK2QkgFhA+jraI0MsZ2FhCrOf70K BWo+IkazDWLzRfupEMyvte4WzY7LsFue4BdjCHVYfXoF01OT58K3mz7G7C+gZU5D+7 qRHgocI9gh8ptra+hXbT1HMKcV/22VVNP4wMJzJc6UiSHHdf7PsGC3gLRp/nWfWUvL C1wlpDPz1y0kQ== Message-ID: <647b4d99-1c1e-41fa-929d-ffd6cda6584d@kernel.org> Date: Sun, 23 Jun 2024 09:10:38 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ASoC: dt-bindings: realtek,rt5659: Convert to dtschema To: Animesh Agarwal Cc: Daniel Baluta , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240622153752.94644-1-animeshagarwal28@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240622153752.94644-1-animeshagarwal28@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 22/06/2024 17:37, Animesh Agarwal wrote: > Convert the RT5659/RT5658 audio CODEC bindings to DT schema. > > Signed-off-by: Animesh Agarwal > Cc: Daniel Baluta > + > +allOf: > + - $ref: dai-common.yaml# > + > +properties: > + compatible: > + enum: > + - realtek,rt5659 > + - realtek,rt5658 > + > + reg: > + maxItems: 1 > + description: The I2C address of the device. Drop description, redundant. > + > + interrupts: > + maxItems: 1 > + description: The CODEC's interrupt output. Drop description, redundant. > + > + clocks: > + maxItems: 1 > + description: phandle and clock specifier for codec MCLK. Drop description, redundant. > + > + clock-names: > + const: mclk > + > + realtek,dmic1-data-pin: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: > + - 0 # dmic1 is not used > + - 1 # using IN2N pin as dmic1 data pin > + - 2 # using GPIO5 pin as dmic1 data pin > + - 3 # using GPIO9 pin as dmic1 data pin > + - 4 # using GPIO11 pin as dmic1 data pin > + description: Specify which pin to be used as DMIC1 data pin. > + > + realtek,dmic2-data-pin: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: > + - 0 # dmic1 is not used > + - 1 # using IN2P pin as dmic1 data pin > + - 2 # using GPIO6 pin as dmic1 data pin > + - 3 # using GPIO10 pin as dmic1 data pin > + - 4 # using GPIO12 pin as dmic1 data pin > + description: Specify which pin to be used as DMIC2 data pin. default: > + > + realtek,jd-src: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: > + - 0 # No JD is used > + - 1 # using JD3 as JD source > + - 2 # JD source for Intel HDA header > + description: Specify which JD source be used. default: > + > + realtek,ldo1-en-gpios: > + maxItems: 1 > + description: The GPIO that controls the CODEC's LDO1_EN pin. It's enough: CODEC's LDO1_EN pin > + > + realtek,reset-gpios: > + maxItems: 1 > + description: The GPIO that controls the CODEC's RESET pin. > + > + sound-name-prefix: true Drop > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + port: > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + codec@1b { > + compatible = "realtek,rt5659"; > + reg = <0x1b>; > + interrupt-parent = <&gpio>; > + interrupts = <3 IRQ_TYPE_LEVEL_HIGH>; > + realtek,ldo1-en-gpios = > + <&gpio 3 GPIO_ACTIVE_HIGH>; This can be one line. Best regards, Krzysztof