Re: [PATCH] dt-bindings: timer: sprd-timer: convert to YAML

[Baolin Wang <baolin.wang@linux.alibaba.com>]

On 2024/7/3 20:02, Stanislav Jakubek wrote:
> Convert the Spreadtrum SC9860 timer bindings to DT schema.
> 
> Changes during conversion:
>    - rename file to match compatible
>    - add sprd,sc9860-suspend-timer which was previously undocumented
>    - minor grammar fix in description
> 
> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>

Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

> ---
>   .../bindings/timer/sprd,sc9860-timer.yaml     | 68 +++++++++++++++++++
>   .../bindings/timer/spreadtrum,sprd-timer.txt  | 20 ------
>   2 files changed, 68 insertions(+), 20 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/timer/sprd,sc9860-timer.yaml
>   delete mode 100644 Documentation/devicetree/bindings/timer/spreadtrum,sprd-timer.txt
> 
> diff --git a/Documentation/devicetree/bindings/timer/sprd,sc9860-timer.yaml b/Documentation/devicetree/bindings/timer/sprd,sc9860-timer.yaml
> new file mode 100644
> index 000000000000..62c6da8bab5a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/sprd,sc9860-timer.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/timer/sprd,sc9860-timer.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Spreadtrum SC9860 timer
> +
> +maintainers:
> +  - Orson Zhai <orsonzhai@gmail.com>
> +  - Baolin Wang <baolin.wang7@gmail.com>
> +  - Chunyan Zhang <zhang.lyra@gmail.com>
> +
> +description:
> +  The Spreadtrum SC9860 platform provides 3 general-purpose timers.
> +  These timers can support 32bit or 64bit counter, as well as supporting
> +  period mode or one-shot mode, and they can be a wakeup source
> +  during deep sleep.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - sprd,sc9860-timer
> +      - sprd,sc9860-suspend-timer
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: sprd,sc9860-timer
> +    then:
> +      required:
> +        - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    soc {
> +      #address-cells = <2>;
> +      #size-cells = <2>;
> +
> +      timer@40050000 {
> +        compatible = "sprd,sc9860-timer";
> +        reg = <0 0x40050000 0 0x20>;
> +        interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> +        clocks = <&ext_32k>;
> +      };
> +    };
> +...
> diff --git a/Documentation/devicetree/bindings/timer/spreadtrum,sprd-timer.txt b/Documentation/devicetree/bindings/timer/spreadtrum,sprd-timer.txt
> deleted file mode 100644
> index 6d97e7d0f6e8..000000000000
> --- a/Documentation/devicetree/bindings/timer/spreadtrum,sprd-timer.txt
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -Spreadtrum timers
> -
> -The Spreadtrum SC9860 platform provides 3 general-purpose timers.
> -These timers can support 32bit or 64bit counter, as well as supporting
> -period mode or one-shot mode, and they are can be wakeup source
> -during deep sleep.
> -
> -Required properties:
> -- compatible: should be "sprd,sc9860-timer" for SC9860 platform.
> -- reg: The register address of the timer device.
> -- interrupts: Should contain the interrupt for the timer device.
> -- clocks: The phandle to the source clock (usually a 32.768 KHz fixed clock).
> -
> -Example:
> -	timer@40050000 {
> -		compatible = "sprd,sc9860-timer";
> -		reg = <0 0x40050000 0 0x20>;
> -		interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> -		clocks = <&ext_32k>;
> -	};