* dwc3-qcom: tx-fifo-resize regression on Poco F1 (sdm845) with v5.15-rc1 @ 2021-09-20 20:45 Amit Pundir 2021-09-20 21:13 ` Wesley Cheng 0 siblings, 1 reply; 6+ messages in thread From: Amit Pundir @ 2021-09-20 20:45 UTC (permalink / raw) To: Wesley Cheng Cc: Felipe Balbi, Greg Kroah-Hartman, Andy Gross, Bjorn Andersson, Rob Herring, Jack Pham, Thinh Nguyen, John Stultz, linux-usb, lkml, linux-arm-msm, dt Hi Wesley, All, I see a reboot loop on Xiaomi Pocophone F1 (sdm845) with TX FIFO resize patches which landed in v5.15-rc1. Upstream commit cefdd52fa045 "usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default" to be specific, which switched on this feature by default. At times the phone crashes into the fastboot mode after the reboot loop, but mostly end up booting to UI after a while. This is what it looks like https://people.linaro.org/~amit.pundir/beryllium-userdebug/PXL_20210920_162749483.mp4. PocoF1 does support TX fifo resizing as I can see that in the downstream dts. So maybe it is the tx-fifo-max-num which need to be adjusted for the device? I couldn't find the tx-fifo-max-num equivalent in the downstream tree though https://github.com/MiCode/Xiaomi_Kernel_OpenSource/tree/dipper-q-oss/ Curious if you had any ideas what might be going wrong? For now I'll keep digging around tx-fifo-max-num, but I figured I'd ask just in case it's obvious to you. Regards, Amit Pundir ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: dwc3-qcom: tx-fifo-resize regression on Poco F1 (sdm845) with v5.15-rc1 2021-09-20 20:45 dwc3-qcom: tx-fifo-resize regression on Poco F1 (sdm845) with v5.15-rc1 Amit Pundir @ 2021-09-20 21:13 ` Wesley Cheng 2021-09-21 7:04 ` Amit Pundir 0 siblings, 1 reply; 6+ messages in thread From: Wesley Cheng @ 2021-09-20 21:13 UTC (permalink / raw) To: Amit Pundir Cc: Felipe Balbi, Greg Kroah-Hartman, Andy Gross, Bjorn Andersson, Rob Herring, Jack Pham, Thinh Nguyen, John Stultz, linux-usb, lkml, linux-arm-msm, dt Hi Amit, On 9/20/2021 1:45 PM, Amit Pundir wrote: > Hi Wesley, All, > > I see a reboot loop on Xiaomi Pocophone F1 (sdm845) with TX FIFO > resize patches which landed in v5.15-rc1. Upstream commit cefdd52fa045 > "usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default" to > be specific, which switched on this feature by default. > > At times the phone crashes into the fastboot mode after the reboot > loop, but mostly end up booting to UI after a while. This is what it > looks like https://people.linaro.org/~amit.pundir/beryllium-userdebug/PXL_20210920_162749483.mp4. > I believe Android will attempt a number of bootup sequences and if it fails, it falls back to fastboot mode. Are there any available logs you might be able to collect to see where the issue is? > PocoF1 does support TX fifo resizing as I can see that in the > downstream dts. So maybe it is the tx-fifo-max-num which need to be > adjusted for the device? I couldn't find the tx-fifo-max-num > equivalent in the downstream tree though > https://github.com/MiCode/Xiaomi_Kernel_OpenSource/tree/dipper-q-oss/ > I assume that you've already confirmed reverting that change resolves the constant reboots? > Curious if you had any ideas what might be going wrong? For now I'll > keep digging around tx-fifo-max-num, but I figured I'd ask just in > case it's obvious to you. > The tx-fifo-max-num parameter should still be set to 6 for SDM845, which would be the same for more recent targets as well. Thanks Wesley Cheng -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: dwc3-qcom: tx-fifo-resize regression on Poco F1 (sdm845) with v5.15-rc1 2021-09-20 21:13 ` Wesley Cheng @ 2021-09-21 7:04 ` Amit Pundir 2021-09-21 7:30 ` Wesley Cheng 0 siblings, 1 reply; 6+ messages in thread From: Amit Pundir @ 2021-09-21 7:04 UTC (permalink / raw) To: Wesley Cheng Cc: Felipe Balbi, Greg Kroah-Hartman, Andy Gross, Bjorn Andersson, Rob Herring, Jack Pham, Thinh Nguyen, John Stultz, linux-usb, lkml, linux-arm-msm, dt Hi Wesley, On Tue, 21 Sept 2021 at 02:44, Wesley Cheng <wcheng@codeaurora.org> wrote: > > Hi Amit, > > On 9/20/2021 1:45 PM, Amit Pundir wrote: > > Hi Wesley, All, > > > > I see a reboot loop on Xiaomi Pocophone F1 (sdm845) with TX FIFO > > resize patches which landed in v5.15-rc1. Upstream commit cefdd52fa045 > > "usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default" to > > be specific, which switched on this feature by default. > > > > At times the phone crashes into the fastboot mode after the reboot > > loop, but mostly end up booting to UI after a while. This is what it > > looks like https://people.linaro.org/~amit.pundir/beryllium-userdebug/PXL_20210920_162749483.mp4. > > > > I believe Android will attempt a number of bootup sequences and if it > fails, it falls back to fastboot mode. Are there any available logs you > might be able to collect to see where the issue is? It is a stock phone with no UART access, so I can't get early crash logs unless I'm booted up to adb shell. I can try getting some info using pstore-ramoops but warm reset support for sdm845 was not upstreamed when I tried using that the last time. > > > PocoF1 does support TX fifo resizing as I can see that in the > > downstream dts. So maybe it is the tx-fifo-max-num which need to be > > adjusted for the device? I couldn't find the tx-fifo-max-num > > equivalent in the downstream tree though > > https://github.com/MiCode/Xiaomi_Kernel_OpenSource/tree/dipper-q-oss/ > > > > I assume that you've already confirmed reverting that change resolves > the constant reboots? Yes reverting that change resolves the reboot loop issue. Speaking of which, since no other platform seem to be running into this issue and "tx-fifo-max-num" property is apparently not at fault either, is it reasonable to skip adding "tx-fifo-resize" property for PocoF1 using of_machine_is_compatible("xiaomi,beryllium") as a workaround? > > > Curious if you had any ideas what might be going wrong? For now I'll > > keep digging around tx-fifo-max-num, but I figured I'd ask just in > > case it's obvious to you. > > > > The tx-fifo-max-num parameter should still be set to 6 for SDM845, which > would be the same for more recent targets as well. Ack. Regards, Amit Pundir > > Thanks > Wesley Cheng > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: dwc3-qcom: tx-fifo-resize regression on Poco F1 (sdm845) with v5.15-rc1 2021-09-21 7:04 ` Amit Pundir @ 2021-09-21 7:30 ` Wesley Cheng 2021-09-21 10:18 ` Amit Pundir 0 siblings, 1 reply; 6+ messages in thread From: Wesley Cheng @ 2021-09-21 7:30 UTC (permalink / raw) To: Amit Pundir Cc: Felipe Balbi, Greg Kroah-Hartman, Andy Gross, Bjorn Andersson, Rob Herring, Jack Pham, Thinh Nguyen, John Stultz, linux-usb, lkml, linux-arm-msm, dt Hi Amit, On 9/21/2021 12:04 AM, Amit Pundir wrote: > Hi Wesley, > > On Tue, 21 Sept 2021 at 02:44, Wesley Cheng <wcheng@codeaurora.org> wrote: >> >> Hi Amit, >> >> On 9/20/2021 1:45 PM, Amit Pundir wrote: >>> Hi Wesley, All, >>> >>> I see a reboot loop on Xiaomi Pocophone F1 (sdm845) with TX FIFO >>> resize patches which landed in v5.15-rc1. Upstream commit cefdd52fa045 >>> "usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default" to >>> be specific, which switched on this feature by default. >>> >>> At times the phone crashes into the fastboot mode after the reboot >>> loop, but mostly end up booting to UI after a while. This is what it >>> looks like https://people.linaro.org/~amit.pundir/beryllium-userdebug/PXL_20210920_162749483.mp4. >>> >> >> I believe Android will attempt a number of bootup sequences and if it >> fails, it falls back to fastboot mode. Are there any available logs you >> might be able to collect to see where the issue is? > > It is a stock phone with no UART access, so I can't get early crash > logs unless I'm booted up to adb shell. I can try getting some info > using pstore-ramoops but warm reset support for sdm845 was not > upstreamed when I tried using that the last time. > I see, can we maybe avoid the actual resizing by commenting out the following writel() calls, but let the fifo resize logic calculate the EPs? void dwc3_gadget_clear_tx_fifos(struct dwc3 *dwc) { ... /* Don't change TXFRAMNUM on usb31 version */ size = DWC3_IP_IS(DWC3) ? 0 : dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1)) & DWC31_GTXFIFOSIZ_TXFRAMNUM; /* Comment the dwc3_writel() */ //dwc3_writel(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1), size); and static int dwc3_gadget_resize_tx_fifos(struct dwc3_ep *dep) { ... /* Comment the dwc3_writel() */ //dwc3_writel(dwc->regs, DWC3_GTXFIFOSIZ(dep->number >> 1), fifo_size); dwc->num_ep_resized++; Those 2 writel() would be the one that actually programs the TXFIFO register. I hope when commented out, no resize should actually happen anymore. With this, hopefully we can get some logs from the device at least :) >> >>> PocoF1 does support TX fifo resizing as I can see that in the >>> downstream dts. So maybe it is the tx-fifo-max-num which need to be >>> adjusted for the device? I couldn't find the tx-fifo-max-num >>> equivalent in the downstream tree though >>> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/tree/dipper-q-oss/ >>> >> >> I assume that you've already confirmed reverting that change resolves >> the constant reboots? > > Yes reverting that change resolves the reboot loop issue. Speaking of > which, since no other platform seem to be running into this issue and > "tx-fifo-max-num" property is apparently not at fault either, is it > reasonable to skip adding "tx-fifo-resize" property for PocoF1 using > of_machine_is_compatible("xiaomi,beryllium") as a workaround? > Since SDM845 does technically support txfifo resize downstream, let me see if I can figure out what is different on this particular device after getting the logs. Thanks Wesley Cheng -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: dwc3-qcom: tx-fifo-resize regression on Poco F1 (sdm845) with v5.15-rc1 2021-09-21 7:30 ` Wesley Cheng @ 2021-09-21 10:18 ` Amit Pundir 2021-09-22 8:53 ` Wesley Cheng 0 siblings, 1 reply; 6+ messages in thread From: Amit Pundir @ 2021-09-21 10:18 UTC (permalink / raw) To: Wesley Cheng Cc: Felipe Balbi, Greg Kroah-Hartman, Andy Gross, Bjorn Andersson, Rob Herring, Jack Pham, Thinh Nguyen, John Stultz, linux-usb, lkml, linux-arm-msm, dt On Tue, 21 Sept 2021 at 13:00, Wesley Cheng <wcheng@codeaurora.org> wrote: > > Hi Amit, > > On 9/21/2021 12:04 AM, Amit Pundir wrote: > > Hi Wesley, > > > > On Tue, 21 Sept 2021 at 02:44, Wesley Cheng <wcheng@codeaurora.org> wrote: > >> > >> Hi Amit, > >> > >> On 9/20/2021 1:45 PM, Amit Pundir wrote: > >>> Hi Wesley, All, > >>> > >>> I see a reboot loop on Xiaomi Pocophone F1 (sdm845) with TX FIFO > >>> resize patches which landed in v5.15-rc1. Upstream commit cefdd52fa045 > >>> "usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default" to > >>> be specific, which switched on this feature by default. > >>> > >>> At times the phone crashes into the fastboot mode after the reboot > >>> loop, but mostly end up booting to UI after a while. This is what it > >>> looks like https://people.linaro.org/~amit.pundir/beryllium-userdebug/PXL_20210920_162749483.mp4. > >>> > >> > >> I believe Android will attempt a number of bootup sequences and if it > >> fails, it falls back to fastboot mode. Are there any available logs you > >> might be able to collect to see where the issue is? > > > > It is a stock phone with no UART access, so I can't get early crash > > logs unless I'm booted up to adb shell. I can try getting some info > > using pstore-ramoops but warm reset support for sdm845 was not > > upstreamed when I tried using that the last time. > > > > I see, can we maybe avoid the actual resizing by commenting out the > following writel() calls, but let the fifo resize logic calculate the EPs? > > void dwc3_gadget_clear_tx_fifos(struct dwc3 *dwc) > { > ... > /* Don't change TXFRAMNUM on usb31 version */ > size = DWC3_IP_IS(DWC3) ? 0 : > dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1)) & > DWC31_GTXFIFOSIZ_TXFRAMNUM; > /* Comment the dwc3_writel() */ > //dwc3_writel(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1), size); > > and > > static int dwc3_gadget_resize_tx_fifos(struct dwc3_ep *dep) > { > ... > /* Comment the dwc3_writel() */ > //dwc3_writel(dwc->regs, DWC3_GTXFIFOSIZ(dep->number >> 1), fifo_size); > dwc->num_ep_resized++; > > Those 2 writel() would be the one that actually programs the TXFIFO > register. I hope when commented out, no resize should actually happen > anymore. > > With this, hopefully we can get some logs from the device at least :) I can boot fine with above 2 writel() removed but I don't see EP counts being printed in the log anywhere and the only relevant message in dmesg I see is this: Duplicate name in dwc3@a600000, renamed to "tx-fifo-resize#1" which is interesting because I don't see tx-fifo-resize property being set by any of the upstream sdm845 or relevant dtsi files. > > >> > >>> PocoF1 does support TX fifo resizing as I can see that in the > >>> downstream dts. So maybe it is the tx-fifo-max-num which need to be > >>> adjusted for the device? I couldn't find the tx-fifo-max-num > >>> equivalent in the downstream tree though > >>> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/tree/dipper-q-oss/ > >>> > >> > >> I assume that you've already confirmed reverting that change resolves > >> the constant reboots? > > > > Yes reverting that change resolves the reboot loop issue. Speaking of > > which, since no other platform seem to be running into this issue and > > "tx-fifo-max-num" property is apparently not at fault either, is it > > reasonable to skip adding "tx-fifo-resize" property for PocoF1 using > > of_machine_is_compatible("xiaomi,beryllium") as a workaround? > > > > Since SDM845 does technically support txfifo resize downstream, let me > see if I can figure out what is different on this particular device > after getting the logs. > > Thanks > Wesley Cheng > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: dwc3-qcom: tx-fifo-resize regression on Poco F1 (sdm845) with v5.15-rc1 2021-09-21 10:18 ` Amit Pundir @ 2021-09-22 8:53 ` Wesley Cheng 0 siblings, 0 replies; 6+ messages in thread From: Wesley Cheng @ 2021-09-22 8:53 UTC (permalink / raw) To: Amit Pundir Cc: Felipe Balbi, Greg Kroah-Hartman, Andy Gross, Bjorn Andersson, Rob Herring, Jack Pham, Thinh Nguyen, John Stultz, linux-usb, lkml, linux-arm-msm, dt Hi Amit, On 9/21/2021 3:18 AM, Amit Pundir wrote: > On Tue, 21 Sept 2021 at 13:00, Wesley Cheng <wcheng@codeaurora.org> wrote: >> >> Hi Amit, >> >> On 9/21/2021 12:04 AM, Amit Pundir wrote: >>> Hi Wesley, >>> >>> On Tue, 21 Sept 2021 at 02:44, Wesley Cheng <wcheng@codeaurora.org> wrote: >>>> >>>> Hi Amit, >>>> >>>> On 9/20/2021 1:45 PM, Amit Pundir wrote: >>>>> Hi Wesley, All, >>>>> >>>>> I see a reboot loop on Xiaomi Pocophone F1 (sdm845) with TX FIFO >>>>> resize patches which landed in v5.15-rc1. Upstream commit cefdd52fa045 >>>>> "usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default" to >>>>> be specific, which switched on this feature by default. >>>>> >>>>> At times the phone crashes into the fastboot mode after the reboot >>>>> loop, but mostly end up booting to UI after a while. This is what it >>>>> looks like https://people.linaro.org/~amit.pundir/beryllium-userdebug/PXL_20210920_162749483.mp4. >>>>> >>>> >>>> I believe Android will attempt a number of bootup sequences and if it >>>> fails, it falls back to fastboot mode. Are there any available logs you >>>> might be able to collect to see where the issue is? >>> >>> It is a stock phone with no UART access, so I can't get early crash >>> logs unless I'm booted up to adb shell. I can try getting some info >>> using pstore-ramoops but warm reset support for sdm845 was not >>> upstreamed when I tried using that the last time. >>> >> >> I see, can we maybe avoid the actual resizing by commenting out the >> following writel() calls, but let the fifo resize logic calculate the EPs? >> >> void dwc3_gadget_clear_tx_fifos(struct dwc3 *dwc) >> { >> ... >> /* Don't change TXFRAMNUM on usb31 version */ >> size = DWC3_IP_IS(DWC3) ? 0 : >> dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1)) & >> DWC31_GTXFIFOSIZ_TXFRAMNUM; >> /* Comment the dwc3_writel() */ >> //dwc3_writel(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1), size); >> >> and >> >> static int dwc3_gadget_resize_tx_fifos(struct dwc3_ep *dep) >> { >> ... >> /* Comment the dwc3_writel() */ >> //dwc3_writel(dwc->regs, DWC3_GTXFIFOSIZ(dep->number >> 1), fifo_size); >> dwc->num_ep_resized++; >> >> Those 2 writel() would be the one that actually programs the TXFIFO >> register. I hope when commented out, no resize should actually happen >> anymore. >> >> With this, hopefully we can get some logs from the device at least :) > > I can boot fine with above 2 writel() removed but I don't see EP > counts being printed in the log anywhere and the only relevant > message in dmesg I see is this: > > Duplicate name in dwc3@a600000, renamed to "tx-fifo-resize#1" > > which is interesting because I don't see tx-fifo-resize property being > set by any of the upstream sdm845 or relevant dtsi files. > > Thanks for testing. What is the current composition the device is exposing to the host? Can we get a ftrace log w/ the DWC3 events enabled, as well as the kernel log? (if not at boot up then maybe a plug in/out) This will at least help us identify when the DWC3 ep enable is being called (which triggers the resize routine) Thanks Wesley Cheng -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-22 8:53 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-09-20 20:45 dwc3-qcom: tx-fifo-resize regression on Poco F1 (sdm845) with v5.15-rc1 Amit Pundir 2021-09-20 21:13 ` Wesley Cheng 2021-09-21 7:04 ` Amit Pundir 2021-09-21 7:30 ` Wesley Cheng 2021-09-21 10:18 ` Amit Pundir 2021-09-22 8:53 ` Wesley Cheng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).