From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D52D1C433FE for ; Tue, 4 Oct 2022 13:10:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229805AbiJDNKg (ORCPT ); Tue, 4 Oct 2022 09:10:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229806AbiJDNKf (ORCPT ); Tue, 4 Oct 2022 09:10:35 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAB6E2A40A for ; Tue, 4 Oct 2022 06:10:33 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id d18so8001155lfb.0 for ; Tue, 04 Oct 2022 06:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=1Zs5AYtIbgN30Vpk1RFYyv899QtIhQ6er/wUtO6Qq6E=; b=BecqeHF+CHlOOFHthq4vfzkmI7poaVVdECpaRivrcOemqlWxzb24h+kIOJX2iOX0Hp WW4+ssamQk98jtcWnNmizmosI12yw1xQE5HvLbXpnZa74zZRkf6adOfRaVCnrv1hWL3d AEfQPwN67DM7h1yQVICeLRdYb17MaQcqlzEwmEZ6s2FRhrh+VQtvL9XL2UDxIC+mF5di etCZsBWCgV90NT980vVfEvHXI923IPqffBfXq8QYED0B+ABU12EsbNno+r/eYDbskRP5 8GxTcRh+r6BMcClCDB6CUG12ZtTsjL/JpXfVKwdRASM19NHJCgpZcnZnqGucQ3TcMcnO dhkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=1Zs5AYtIbgN30Vpk1RFYyv899QtIhQ6er/wUtO6Qq6E=; b=uKV7GhLa0KtiCtpWG67e8rbYC3KAvLfz3vNQzHcyVw+hB/QwF6vF2VP0+tEYApbIYT oe6o5lqWQJlfWg+5wtBhJk8HeRzJ7aV+bZyd3IzxXRIejd2sSdZP9FJfkzLHUuvjNrI5 LVnhNdmL/u6ckYoxfLdbq2HkfpjFAC/m+ri/31zh/cvkqFijgYxBG4l1x1gHCWIUp+kR X/V8o95aU0tBu2urhJrj75GUlH9SZjQbBwwf/qcMbtnIFRQVhcMEi23VsmLQ6LDc/1ZD mUK/z/EmOQtgJfPTFITkR4MMPNBCLOvC3gTzcC7Fm6ZJtECFn/C/GSgQWRS3VbzBv41H hzQA== X-Gm-Message-State: ACrzQf0OETQXE7KPyk3rbZCpeZz0ZnzA0mN8QS5Rqm+/KHItzNTuL4uo agEHcoSb+WTsYQnPiTc3tdarpg== X-Google-Smtp-Source: AMsMyM4g1VTiHI/xh6oQYaaI0i8Df44upYXlbUFk6fAawopFjhjHB4pKoEXsPqf2xp+ZlX8j7NPn/Q== X-Received: by 2002:ac2:4c48:0:b0:4a2:5937:6f5e with SMTP id o8-20020ac24c48000000b004a259376f5emr680892lfk.677.1664889031960; Tue, 04 Oct 2022 06:10:31 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id h13-20020a2ea48d000000b0026bdb7ad643sm1231743lji.50.2022.10.04.06.10.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 06:10:31 -0700 (PDT) Message-ID: <64a355f2-e9a1-dcca-cb86-48805acae8d5@linaro.org> Date: Tue, 4 Oct 2022 15:10:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] dt-bindings: display: panel: use spi-peripheral-props.yaml Content-Language: en-US To: Laurent Pinchart Cc: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Linus Walleij , Markuss Broks , Daniel Mack , Dillon Min , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221004120907.72767-1-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/10/2022 15:03, Laurent Pinchart wrote: > Hi Krzysztof, > > Thank you for the patch. > > On Tue, Oct 04, 2022 at 02:09:07PM +0200, Krzysztof Kozlowski wrote: >> For devices connectable by SPI bus (e.g. already using >> "spi-max-frequency" property), reference the "spi-peripheral-props.yaml" >> schema to allow using all SPI device properties, even these which device >> bindings author did not tried yet. > > Isn't this done implicitly by spi-controller.yaml ? SPI devices that are > children of an SPI controller should match the patternProperties > "^.*@[0-9a-f]+$" in that file, which has a $ref: spi-peripheral-props.yaml. > Is there something I'm missing ? > You are correct about one side of this - SPI controller bindings. However these schemas here have clear: additional/unevaluatedProperties: false, thus when they find DTS like: panel@xxx { compatible = "one of these spi panels"; ... spi-cs-high; spi-rx-delay-us = <50>; ... and some more from specific controllers } you will get errors, because the panel schema does not allow them. The bindings were done (some time ago) in such way, that they require that both SPI controller and SPI device reference spi-props. Best regards, Krzysztof