public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, wim@linux-watchdog.org
Cc: linux@roeck-us.net, linux-watchdog@vger.kernel.org,
	linux-kernel@vger.kernel.org, S32@nxp.com,
	ghennadi.procopciuc@nxp.com, thomas.fossati@linaro.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: watchdog: Add NXP Software Watchdog Timer
Date: Thu, 3 Apr 2025 09:19:18 +0300	[thread overview]
Message-ID: <64b6d599-fe67-586a-e4b0-73d9b73499de@oss.nxp.com> (raw)
In-Reply-To: <20250402154942.3645283-2-daniel.lezcano@linaro.org>

On 4/2/2025 6:49 PM, Daniel Lezcano wrote:
[ ... ]
> +examples:
> +  - |
> +    watchdog@0x40100000 {
> +        compatible = "nxp,s32g2-swt";
> +        reg = <0x40100000 0x1000>;
> +        clocks = <&clks 0x3a>;
> +        timeout-sec = <10>;
> +    };

The S32G reference manual specifies two clocks for the SWT module: one
for the registers and another for the counter itself. Shouldn't both
clocks be represented in the bindings?

-- 
Regards,
Ghennadi


  parent reply	other threads:[~2025-04-03  6:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-02 15:49 [PATCH v2 0/2] Add the NXP S32 Watchdog Daniel Lezcano
2025-04-02 15:49 ` [PATCH v2 1/2] dt-bindings: watchdog: Add NXP Software Watchdog Timer Daniel Lezcano
2025-04-02 15:56   ` Krzysztof Kozlowski
2025-04-02 23:01     ` Daniel Lezcano
2025-04-03 14:16       ` Krzysztof Kozlowski
2025-04-03 15:33         ` Daniel Lezcano
2025-04-03 15:35           ` Krzysztof Kozlowski
2025-04-03 21:52             ` Daniel Lezcano
2025-04-02 18:56   ` Rob Herring (Arm)
2025-04-03  6:19   ` Ghennadi Procopciuc [this message]
2025-04-03 15:10     ` Daniel Lezcano
2025-04-04  6:35       ` Ghennadi Procopciuc
2025-04-06 20:33         ` Daniel Lezcano
2025-04-07  4:53           ` Ghennadi Procopciuc
2025-04-02 15:49 ` [PATCH v2 2/2] watchdog: Add the Watchdog Timer for the NXP S32 platform Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64b6d599-fe67-586a-e4b0-73d9b73499de@oss.nxp.com \
    --to=ghennadi.procopciuc@oss.nxp.com \
    --cc=S32@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ghennadi.procopciuc@nxp.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh@kernel.org \
    --cc=thomas.fossati@linaro.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox