From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7474B28F7; Tue, 20 Aug 2024 00:46:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724114807; cv=none; b=SDVwxzjJgDGXTO0FNmtYS2kSBWIMZtX/AL/lJ9mVJVj1ZGAOP4pu5SqMriQHHc5FItBhTctaz82LM1pmtjs/eh+WIn9AnY+Lpv9dnBX6BC6jVuAHiLih5wxuENU9m5RRBaVGtstWG8FSLk1NaGD1TqJIGjGfr3+EDUfNgSbobB4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724114807; c=relaxed/simple; bh=ydMPJXWc+4mN/5YqZSgXd1nsM2YsWEVgelc+2JMc2jU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=o0d3JdX4UOSQTpvagtBkpNOLwnQpe3A2kZ9shBwpjk99JzLfTMefyLny0gmVOZhL6k7kxTTd5c2Ujr8bUoPLnx70V1M/bBfnIoHsX938pyXNvjhlxF5BBCQYhYHZsCei7sIdF2OxWVGF4No+lhklvvt3rkxqozOgS0zdO6jFSFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=mN3V//KB; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="mN3V//KB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1724114795; bh=VztiBRbygHwYDHzQLX/sFAU+p1PMMXCRuAONMaebNSM=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=mN3V//KBwJs/nv5+Hjs8ob0frnNNWB/TfsJWVXHZRZwentWdco/b7jhrK/Bn2RmGr Z5ybwCTdeiTgd7tZ2UM44tr9EbnxQo80V4fV04rHpjmv1ynBTi/XTePCGVt8kGFK3y rbXp7UEWU1qwrFTDq4qnSRzsOZVTUdaJ/5x7FHVpVgSmIDC4VzmzJ2OLXwhND9vAjO +V/zqc7vNVC0L5dt5PC6JDcmZoSxwfiHZMUSa1QuSDZhkaHeg8r3+XN2vlD53E+Nwm M2xzTrrnhgmZ1+EV+gUpGgHwicdtjL/j4/n2+R4noJRfaHhw3Perc++M9Zb9DDkctd bjjw0EQN0h64A== Received: from [192.168.68.112] (ppp118-210-94-119.adl-adc-lon-bras32.tpg.internode.on.net [118.210.94.119]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 574D364B84; Tue, 20 Aug 2024 08:46:32 +0800 (AWST) Message-ID: <64d13efd3119429ed876ad7ea499cff62e100fb9.camel@codeconstruct.com.au> Subject: Re: [PATCH 1/4] dt-bindings: mfd: aspeed: support for AST2700 From: Andrew Jeffery To: Ryan Chen , Rob Herring Cc: "devicetree@vger.kernel.org" , Conor Dooley , "linux-aspeed@lists.ozlabs.org" , Stephen Boyd , Michael Turquette , Lee Jones , "linux-kernel@vger.kernel.org" , Krzysztof Kozlowski , Philipp Zabel , Krzysztof Kozlowski , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Date: Tue, 20 Aug 2024 10:16:30 +0930 In-Reply-To: References: <20240808075937.2756733-1-ryan_chen@aspeedtech.com> <20240808075937.2756733-2-ryan_chen@aspeedtech.com> <2f27285e-6aa5-4e42-b361-224d8d164113@kernel.org> <10809e91-31be-4110-86c1-1e1ccb05b664@kernel.org> <20240813191454.GA1570645-robh@kernel.org> <7e1dc98e0f69a095a8f7725b742df3c8d8436a67.camel@codeconstruct.com.au> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2024-08-19 at 03:05 +0000, Ryan Chen wrote: > > > Subject: Re: [PATCH 1/4] dt-bindings: mfd: aspeed: support for > > > AST2700 > > >=20 > > > On Wed, 2024-08-14 at 06:35 +0000, Ryan Chen wrote: > > > > > Subject: Re: [PATCH 1/4] dt-bindings: mfd: aspeed: support > > > > > for > > > > > AST2700 > > > > >=20 > > > > > On Fri, Aug 09, 2024 at 06:10:22AM +0000, Ryan Chen wrote: > > > > > > > Subject: Re: [PATCH 1/4] dt-bindings: mfd: aspeed: > > > > > > > support for > > > > > > > AST2700 > > > > > > >=20 > > > > > > > On 09/08/2024 07:55, Ryan Chen wrote: > > > > > > > > > Subject: Re: [PATCH 1/4] dt-bindings: mfd: aspeed: > > > > > > > > > support > > > > > > > > > for > > > > > > > > > AST2700 > > > > > > > > >=20 > > > > > > > > > On 08/08/2024 09:59, Ryan Chen wrote: > > > > > > > > > > Add compatible support for AST2700 clk, reset, > > > > > > > > > > pinctrl, > > > > > > > > > > silicon-id and example for AST2700 scu. > > > > > > > > > >=20 > > > > > > > > > > Signed-off-by: Ryan Chen > > > > > > > > > > --- > > > > > > > > > > =C2=A0.../bindings/mfd/aspeed,ast2x00-scu.yaml | 3= 1 > > > > > > > > > +++++++++++++++++-- > > > > > > > > > > =C2=A01 file changed, 29 insertions(+), 2 deletions(-) > > > > > > > > > >=20 > > > > > > > > > > diff --git > > > > > > > > > > a/Documentation/devicetree/bindings/mfd/aspeed,ast2 > > > > > > > > > > x00- > > > > > > > > > > scu.yaml > > > > > > > > > > b/Documentation/devicetree/bindings/mfd/aspeed,ast2 > > > > > > > > > > x00- > > > > > > > > > > scu.yaml > > > > > > > > > > index 86ee69c0f45b..c0965f08ae8c 100644 > > > > > > > > > > --- > > > > > > > > > > a/Documentation/devicetree/bindings/mfd/aspeed,ast2 > > > > > > > > > > x00- > > > > > > > > > > scu.yaml > > > > > > > > > > +++ > > > > > > > > > > b/Documentation/devicetree/bindings/mfd/aspeed,ast2 > > > > > > > > > > x00- > > > > > > > > > > scu.y > > > > > > > > > > +++ aml > > > > > > > > > > @@ -21,6 +21,8 @@ properties: > > > > > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0- aspeed,ast2400-scu > > > > > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0- aspeed,ast2500-scu > > > > > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0- aspeed,ast2600-scu > > > > > > > > > > + - aspeed,ast2700-scu0 > > > > > > > > > > + - aspeed,ast2700-scu1 > > > > > > > > >=20 > > > > > > > > > What are the differences between these two? > > > > > > > >=20 > > > > > > > > The next [PATCH 4/4] is scu driver that include > > > > > > > > ast2700-scu0 > > > > > > > > and > > > > > > > > ast2700-scu1 CLK_OF_DECLARE_DRIVER(ast2700_soc0, > > > > > > > > "aspeed,ast2700-scu0", ast2700_soc0_clk_init); > > > > > > > > CLK_OF_DECLARE_DRIVER(ast2700_soc1, "aspeed,ast2700- > > > > > > > > scu1", > > > > > > > > ast2700_soc1_clk_init); > > > > > > >=20 > > > > > > > What are hardware differences? Entirely different > > > > > > > devices? > > > > > >=20 > > > > > > AST2700 have two soc die connected each other. > > > > > > Each soc die have it own scu, so the naming is ast2700-scu0 > > > > > > for > > > > > > soc0, > > > > > another is ast2700-scu1 for soc1. > > > > >=20 > > > > > Didn't I see in another patch one die is cpu and one is io? > > > > > Use > > > > > those in the compatible rather than 0 and 1 if so. > > > > >=20 > > > > Sorry, I want to align with our datasheet description. > > > > It will but scu0 and scu1 register setting. > > >=20 > > > Can we document that relationship in the binding? Rob's > > > suggestion > > > seems more descriptive. > > Hello, > > Do you want me document it in yaml file or just in commit > > message? >=20 > Hello Rob, Andrew, > I will add in yaml file in description. Like following. >=20 > description: > =C2=A0=C2=A0The Aspeed System Control Unit manages the global behaviour o= f the > SoC, > =C2=A0=C2=A0configuring elements such as clocks, pinmux, and reset. > + In AST2700, it has two soc combination. Each soc include its own > scu register control. > + ast2700-scu0 for soc0, ast2700-scu1 for soc1. >=20 > Is that will be better way ? What Rob is suggesting is to add the compatibles "aspeed,ast2700-scu- cpu" and "aspeed,ast2700-scu-io", and then in the description say something like: The AST2700 integrates both a CPU and an IO die, each with their own SCU. The "aspeed,ast2700-scu-cpu" and "aspeed,ast2700-scu-io" compatibles correspond to SCU0 and SCU1 respectively. Andrew